From e34c5a350321c6c1997bdcc15fbd85cfb521f51b Mon Sep 17 00:00:00 2001 From: unarist Date: Tue, 6 Jun 2017 23:44:48 +0900 Subject: [PATCH] Fix 500 errors on searching invalid URLs (#3613) --- app/services/fetch_remote_resource_service.rb | 2 +- spec/services/fetch_remote_resource_service_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/services/fetch_remote_resource_service.rb b/app/services/fetch_remote_resource_service.rb index a0c270673..5dfa3a0ff 100644 --- a/app/services/fetch_remote_resource_service.rb +++ b/app/services/fetch_remote_resource_service.rb @@ -5,7 +5,7 @@ class FetchRemoteResourceService < BaseService def call(url) @url = url - process_url unless atom_url.nil? + process_url unless fetched_atom_feed.nil? end private diff --git a/spec/services/fetch_remote_resource_service_spec.rb b/spec/services/fetch_remote_resource_service_spec.rb index 79834842a..81b0e48e3 100644 --- a/spec/services/fetch_remote_resource_service_spec.rb +++ b/spec/services/fetch_remote_resource_service_spec.rb @@ -10,7 +10,7 @@ describe FetchRemoteResourceService do url = 'http://example.com/missing-atom' service = double allow(FetchAtomService).to receive(:new).and_return service - allow(service).to receive(:call).with(url).and_return([nil, 'body']) + allow(service).to receive(:call).with(url).and_return(nil) result = subject.call(url) expect(result).to be_nil