Correct prettier calls for YML/JSON (#21832)

* Fix fomat-check writing files

* Fix unformatted YML/JSON

* Add format-check call to prevent regressions
This commit is contained in:
Nick Schonning 2022-12-02 22:05:35 -05:00 committed by GitHub
parent 2413e5f3f0
commit f77ed3a6b2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 16 additions and 19 deletions

View file

@ -57,6 +57,8 @@ jobs:
cache: yarn cache: yarn
- name: Install dependencies - name: Install dependencies
run: yarn install --frozen-lockfile run: yarn install --frozen-lockfile
- name: Check prettier formatting
run: yarn format-check
- name: Set-up RuboCop Problem Mathcher - name: Set-up RuboCop Problem Mathcher
uses: r7kamura/rubocop-problem-matchers-action@v1 uses: r7kamura/rubocop-problem-matchers-action@v1
- name: Set-up Stylelint Problem Matcher - name: Set-up Stylelint Problem Matcher

View file

@ -6,16 +6,16 @@ name: Test chart
on: on:
pull_request: pull_request:
paths: paths:
- "chart/**" - 'chart/**'
- "!**.md" - '!**.md'
- ".github/workflows/test-chart.yml" - '.github/workflows/test-chart.yml'
push: push:
paths: paths:
- "chart/**" - 'chart/**'
- "!**.md" - '!**.md'
- ".github/workflows/test-chart.yml" - '.github/workflows/test-chart.yml'
branches-ignore: branches-ignore:
- "dependabot/**" - 'dependabot/**'
workflow_dispatch: workflow_dispatch:
permissions: permissions:
@ -33,7 +33,7 @@ jobs:
- uses: actions/checkout@v3 - uses: actions/checkout@v3
- uses: actions/setup-python@v4 - uses: actions/setup-python@v4
with: with:
python-version: "3.x" python-version: '3.x'
- name: Install dependencies (yamllint) - name: Install dependencies (yamllint)
run: pip install yamllint run: pip install yamllint

View file

@ -13,10 +13,5 @@
"strict": false, "strict": false,
"target": "ES2022" "target": "ES2022"
}, },
"exclude": [ "exclude": ["**/build/*", "**/node_modules/*", "**/public/*", "**/vendor/*"]
"**/build/*",
"**/node_modules/*",
"**/public/*",
"**/vendor/*"
]
} }

View file

@ -15,8 +15,8 @@
"test:lint:js": "eslint --ext=js . --cache", "test:lint:js": "eslint --ext=js . --cache",
"test:lint:sass": "stylelint '**/*.scss'", "test:lint:sass": "stylelint '**/*.scss'",
"test:jest": "cross-env NODE_ENV=test jest", "test:jest": "cross-env NODE_ENV=test jest",
"format": "prettier --write '**/*.{json,yml}'", "format": "prettier --write \"**/*.{json,yml}\"",
"format-check": "prettier --write '**/*.{json,yml}'" "format-check": "prettier --check \"**/*.{json,yml}\""
}, },
"repository": { "repository": {
"type": "git", "type": "git",