e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
123 lines
3.5 KiB
Ruby
123 lines
3.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe Api::V1::Statuses::FavouritesController do
|
|
render_views
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let(:app) { Fabricate(:application, name: 'Test app', website: 'http://testapp.com') }
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'write:favourites', application: app) }
|
|
|
|
context 'with an oauth token' do
|
|
before do
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
end
|
|
|
|
describe 'POST #create' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :create, params: { status_id: status.id }
|
|
end
|
|
|
|
context 'with public status' do
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'updates the favourites count' do
|
|
expect(status.favourites.count).to eq 1
|
|
end
|
|
|
|
it 'updates the favourited attribute' do
|
|
expect(user.account.favourited?(status)).to be true
|
|
end
|
|
|
|
it 'returns json with updated attributes' do
|
|
hash_body = body_as_json
|
|
|
|
expect(hash_body[:id]).to eq status.id.to_s
|
|
expect(hash_body[:favourites_count]).to eq 1
|
|
expect(hash_body[:favourited]).to be true
|
|
end
|
|
end
|
|
|
|
context 'with private status of not-followed account' do
|
|
let(:status) { Fabricate(:status, visibility: :private) }
|
|
|
|
it 'returns http not found' do
|
|
expect(response).to have_http_status(404)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'POST #destroy' do
|
|
context 'with public status' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
FavouriteService.new.call(user.account, status)
|
|
post :destroy, params: { status_id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'updates the favourites count' do
|
|
expect(status.favourites.count).to eq 0
|
|
end
|
|
|
|
it 'updates the favourited attribute' do
|
|
expect(user.account.favourited?(status)).to be false
|
|
end
|
|
|
|
it 'returns json with updated attributes' do
|
|
hash_body = body_as_json
|
|
|
|
expect(hash_body[:id]).to eq status.id.to_s
|
|
expect(hash_body[:favourites_count]).to eq 0
|
|
expect(hash_body[:favourited]).to be false
|
|
end
|
|
end
|
|
|
|
context 'with public status when blocked by its author' do
|
|
let(:status) { Fabricate(:status) }
|
|
|
|
before do
|
|
FavouriteService.new.call(user.account, status)
|
|
status.account.block!(user.account)
|
|
post :destroy, params: { status_id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'updates the favourite attribute' do
|
|
expect(user.account.favourited?(status)).to be false
|
|
end
|
|
|
|
it 'returns json with updated attributes' do
|
|
hash_body = body_as_json
|
|
|
|
expect(hash_body[:id]).to eq status.id.to_s
|
|
expect(hash_body[:favourited]).to be false
|
|
end
|
|
end
|
|
|
|
context 'with private status that was not favourited' do
|
|
let(:status) { Fabricate(:status, visibility: :private) }
|
|
|
|
before do
|
|
post :destroy, params: { status_id: status.id }
|
|
end
|
|
|
|
it 'returns http not found' do
|
|
expect(response).to have_http_status(404)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|