8ac7fca5d0
In #2110, a new attachment type "unknown" was introduced for attachments that were rejected due to a domain being blocked using reject_media. However, the "type" field was never set to "unknown" because a default value of "0" (image) is set for that column, causing the `type.blank?` expression to always equal false. This version uses type_changed? instead, causing the type to be set to "unknown" unless a type has been explicitly set. This introduces a small change in behaviour causing the type to be set to unknown before paperclip calls `before_post_process`. Presumably this behaviour is more appropriate than the current one because the attachment type has not been determined by that point. Included are new tests for `ProcessFeedService` and `UpdateRemoteProfileService` which now check that remote media is downloaded for non-blocked domains and is rejected for others. |
||
---|---|---|
.. | ||
concerns | ||
form | ||
web | ||
account.rb | ||
account_filter.rb | ||
application_record.rb | ||
block.rb | ||
domain_block.rb | ||
export.rb | ||
favourite.rb | ||
feed.rb | ||
follow.rb | ||
follow_request.rb | ||
import.rb | ||
media_attachment.rb | ||
mention.rb | ||
mute.rb | ||
notification.rb | ||
preview_card.rb | ||
remote_follow.rb | ||
report.rb | ||
report_filter.rb | ||
setting.rb | ||
status.rb | ||
stream_entry.rb | ||
subscription.rb | ||
tag.rb | ||
user.rb | ||
web.rb |