e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
119 lines
2.5 KiB
Ruby
119 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require 'pundit/rspec'
|
|
|
|
RSpec.describe AccountPolicy do
|
|
let(:subject) { described_class }
|
|
let(:admin) { Fabricate(:user, admin: true).account }
|
|
let(:john) { Fabricate(:account) }
|
|
let(:alice) { Fabricate(:account) }
|
|
|
|
permissions :index? do
|
|
context 'staff' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin)
|
|
end
|
|
end
|
|
|
|
context 'not staff' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :show?, :unsilence?, :unsensitive?, :remove_avatar?, :remove_header? do
|
|
context 'staff' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, alice)
|
|
end
|
|
end
|
|
|
|
context 'not staff' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, alice)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :unsuspend?, :unblock_email? do
|
|
before do
|
|
alice.suspend!
|
|
end
|
|
|
|
context 'staff' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, alice)
|
|
end
|
|
end
|
|
|
|
context 'not staff' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, alice)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :redownload?, :subscribe?, :unsubscribe? do
|
|
context 'admin' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin)
|
|
end
|
|
end
|
|
|
|
context 'not admin' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :suspend?, :silence? do
|
|
let(:staff) { Fabricate(:user, admin: true).account }
|
|
|
|
context 'staff' do
|
|
context 'record is staff' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(admin, staff)
|
|
end
|
|
end
|
|
|
|
context 'record is not staff' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, john)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'not staff' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, Account)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :memorialize? do
|
|
let(:other_admin) { Fabricate(:user, admin: true).account }
|
|
|
|
context 'admin' do
|
|
context 'record is admin' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(admin, other_admin)
|
|
end
|
|
end
|
|
|
|
context 'record is not admin' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, john)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'not admin' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, Account)
|
|
end
|
|
end
|
|
end
|
|
end
|