ae871c4d46
* Make Array-creation behavior of Paginable more predictable Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it returns an Array if min_id option is present. The behavior caused problems fixed with the following commits: -552e886b64-b63ede5005-64ef37b89dTo prevent from recurring similar problems, this commit introduces two changes: - The scope now always returns an Array whether min_id option is present or not. - The scope is renamed to to_a_paginated_by_id to clarify it returns an Array. * Transform Paginable.to_a_paginated_by_id from a scope to a class method https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope > The method is intended to return an ActiveRecord::Relation object, which > is composable with other scopes. Paginable.to_a_paginated_by_id returns an Array and is not appropriate as a scope.
65 lines
1.5 KiB
Ruby
65 lines
1.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Api::V1::FavouritesController < Api::BaseController
|
|
before_action -> { doorkeeper_authorize! :read, :'read:favourites' }
|
|
before_action :require_user!
|
|
after_action :insert_pagination_headers
|
|
|
|
def index
|
|
@statuses = load_statuses
|
|
render json: @statuses, each_serializer: REST::StatusSerializer, relationships: StatusRelationshipsPresenter.new(@statuses, current_user&.account_id)
|
|
end
|
|
|
|
private
|
|
|
|
def load_statuses
|
|
cached_favourites
|
|
end
|
|
|
|
def cached_favourites
|
|
cache_collection(results.map(&:status), Status)
|
|
end
|
|
|
|
def results
|
|
@_results ||= account_favourites.eager_load(:status).to_a_paginated_by_id(
|
|
limit_param(DEFAULT_STATUSES_LIMIT),
|
|
params_slice(:max_id, :since_id, :min_id)
|
|
)
|
|
end
|
|
|
|
def account_favourites
|
|
current_account.favourites
|
|
end
|
|
|
|
def insert_pagination_headers
|
|
set_pagination_headers(next_path, prev_path)
|
|
end
|
|
|
|
def next_path
|
|
if records_continue?
|
|
api_v1_favourites_url pagination_params(max_id: pagination_max_id)
|
|
end
|
|
end
|
|
|
|
def prev_path
|
|
unless results.empty?
|
|
api_v1_favourites_url pagination_params(min_id: pagination_since_id)
|
|
end
|
|
end
|
|
|
|
def pagination_max_id
|
|
results.last.id
|
|
end
|
|
|
|
def pagination_since_id
|
|
results.first.id
|
|
end
|
|
|
|
def records_continue?
|
|
results.size == limit_param(DEFAULT_STATUSES_LIMIT)
|
|
end
|
|
|
|
def pagination_params(core_params)
|
|
params.slice(:limit).permit(:limit).merge(core_params)
|
|
end
|
|
end
|