account_statuses_cleanup_policy_spec.rb 21 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504
  1. # frozen_string_literal: true
  2. require 'rails_helper'
  3. RSpec.describe AccountStatusesCleanupPolicy do
  4. let(:account) { Fabricate(:account, username: 'alice', domain: nil) }
  5. describe 'validation' do
  6. it 'disallow remote accounts' do
  7. account.update(domain: 'example.com')
  8. account_statuses_cleanup_policy = Fabricate.build(:account_statuses_cleanup_policy, account: account)
  9. account_statuses_cleanup_policy.valid?
  10. expect(account_statuses_cleanup_policy).to model_have_error_on_field(:account)
  11. end
  12. end
  13. describe 'save hooks' do
  14. context 'when widening a policy' do
  15. let!(:account_statuses_cleanup_policy) do
  16. Fabricate(:account_statuses_cleanup_policy,
  17. account: account,
  18. keep_direct: true,
  19. keep_pinned: true,
  20. keep_polls: true,
  21. keep_media: true,
  22. keep_self_fav: true,
  23. keep_self_bookmark: true,
  24. min_favs: 1,
  25. min_reblogs: 1)
  26. end
  27. before do
  28. account_statuses_cleanup_policy.record_last_inspected(42)
  29. end
  30. it 'invalidates last_inspected when widened because of keep_direct' do
  31. account_statuses_cleanup_policy.keep_direct = false
  32. account_statuses_cleanup_policy.save
  33. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  34. end
  35. it 'invalidates last_inspected when widened because of keep_pinned' do
  36. account_statuses_cleanup_policy.keep_pinned = false
  37. account_statuses_cleanup_policy.save
  38. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  39. end
  40. it 'invalidates last_inspected when widened because of keep_polls' do
  41. account_statuses_cleanup_policy.keep_polls = false
  42. account_statuses_cleanup_policy.save
  43. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  44. end
  45. it 'invalidates last_inspected when widened because of keep_media' do
  46. account_statuses_cleanup_policy.keep_media = false
  47. account_statuses_cleanup_policy.save
  48. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  49. end
  50. it 'invalidates last_inspected when widened because of keep_self_fav' do
  51. account_statuses_cleanup_policy.keep_self_fav = false
  52. account_statuses_cleanup_policy.save
  53. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  54. end
  55. it 'invalidates last_inspected when widened because of keep_self_bookmark' do
  56. account_statuses_cleanup_policy.keep_self_bookmark = false
  57. account_statuses_cleanup_policy.save
  58. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  59. end
  60. it 'invalidates last_inspected when widened because of higher min_favs' do
  61. account_statuses_cleanup_policy.min_favs = 5
  62. account_statuses_cleanup_policy.save
  63. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  64. end
  65. it 'invalidates last_inspected when widened because of disabled min_favs' do
  66. account_statuses_cleanup_policy.min_favs = nil
  67. account_statuses_cleanup_policy.save
  68. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  69. end
  70. it 'invalidates last_inspected when widened because of higher min_reblogs' do
  71. account_statuses_cleanup_policy.min_reblogs = 5
  72. account_statuses_cleanup_policy.save
  73. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  74. end
  75. it 'invalidates last_inspected when widened because of disable min_reblogs' do
  76. account_statuses_cleanup_policy.min_reblogs = nil
  77. account_statuses_cleanup_policy.save
  78. expect(account_statuses_cleanup_policy.last_inspected).to be_nil
  79. end
  80. end
  81. context 'when narrowing a policy' do
  82. let!(:account_statuses_cleanup_policy) do
  83. Fabricate(:account_statuses_cleanup_policy,
  84. account: account,
  85. keep_direct: false,
  86. keep_pinned: false,
  87. keep_polls: false,
  88. keep_media: false,
  89. keep_self_fav: false,
  90. keep_self_bookmark: false,
  91. min_favs: nil,
  92. min_reblogs: nil)
  93. end
  94. it 'does not unnecessarily invalidate last_inspected' do
  95. account_statuses_cleanup_policy.record_last_inspected(42)
  96. account_statuses_cleanup_policy.keep_direct = true
  97. account_statuses_cleanup_policy.keep_pinned = true
  98. account_statuses_cleanup_policy.keep_polls = true
  99. account_statuses_cleanup_policy.keep_media = true
  100. account_statuses_cleanup_policy.keep_self_fav = true
  101. account_statuses_cleanup_policy.keep_self_bookmark = true
  102. account_statuses_cleanup_policy.min_favs = 5
  103. account_statuses_cleanup_policy.min_reblogs = 5
  104. account_statuses_cleanup_policy.save
  105. expect(account_statuses_cleanup_policy.last_inspected).to eq 42
  106. end
  107. end
  108. end
  109. describe '#record_last_inspected' do
  110. let(:account_statuses_cleanup_policy) { Fabricate(:account_statuses_cleanup_policy, account: account) }
  111. it 'records the given id' do
  112. account_statuses_cleanup_policy.record_last_inspected(42)
  113. expect(account_statuses_cleanup_policy.last_inspected).to eq 42
  114. end
  115. end
  116. describe '#invalidate_last_inspected' do
  117. subject { account_statuses_cleanup_policy.invalidate_last_inspected(status, action) }
  118. let(:account_statuses_cleanup_policy) { Fabricate(:account_statuses_cleanup_policy, account: account) }
  119. let(:status) { Fabricate(:status, id: 10, account: account) }
  120. before do
  121. account_statuses_cleanup_policy.record_last_inspected(42)
  122. end
  123. context 'when the action is :unbookmark' do
  124. let(:action) { :unbookmark }
  125. context 'when the policy is not to keep self-bookmarked toots' do
  126. before do
  127. account_statuses_cleanup_policy.keep_self_bookmark = false
  128. end
  129. it 'does not change the recorded id' do
  130. subject
  131. expect(account_statuses_cleanup_policy.last_inspected).to eq 42
  132. end
  133. end
  134. context 'when the policy is to keep self-bookmarked toots' do
  135. before do
  136. account_statuses_cleanup_policy.keep_self_bookmark = true
  137. end
  138. it 'records the older id' do
  139. subject
  140. expect(account_statuses_cleanup_policy.last_inspected).to eq 10
  141. end
  142. end
  143. end
  144. context 'when the action is :unfav' do
  145. let(:action) { :unfav }
  146. context 'when the policy is not to keep self-favourited toots' do
  147. before do
  148. account_statuses_cleanup_policy.keep_self_fav = false
  149. end
  150. it 'does not change the recorded id' do
  151. subject
  152. expect(account_statuses_cleanup_policy.last_inspected).to eq 42
  153. end
  154. end
  155. context 'when the policy is to keep self-favourited toots' do
  156. before do
  157. account_statuses_cleanup_policy.keep_self_fav = true
  158. end
  159. it 'records the older id' do
  160. subject
  161. expect(account_statuses_cleanup_policy.last_inspected).to eq 10
  162. end
  163. end
  164. end
  165. context 'when the action is :unpin' do
  166. let(:action) { :unpin }
  167. context 'when the policy is not to keep pinned toots' do
  168. before do
  169. account_statuses_cleanup_policy.keep_pinned = false
  170. end
  171. it 'does not change the recorded id' do
  172. subject
  173. expect(account_statuses_cleanup_policy.last_inspected).to eq 42
  174. end
  175. end
  176. context 'when the policy is to keep pinned toots' do
  177. before do
  178. account_statuses_cleanup_policy.keep_pinned = true
  179. end
  180. it 'records the older id' do
  181. subject
  182. expect(account_statuses_cleanup_policy.last_inspected).to eq 10
  183. end
  184. end
  185. end
  186. context 'when the status is more recent than the recorded inspected id' do
  187. let(:action) { :unfav }
  188. let(:status) { Fabricate(:status, account: account) }
  189. it 'does not change the recorded id' do
  190. subject
  191. expect(account_statuses_cleanup_policy.last_inspected).to eq 42
  192. end
  193. end
  194. end
  195. describe '#compute_cutoff_id' do
  196. subject { account_statuses_cleanup_policy.compute_cutoff_id }
  197. let(:account_statuses_cleanup_policy) { Fabricate(:account_statuses_cleanup_policy, account: account) }
  198. before { Fabricate(:status, created_at: 3.years.ago) }
  199. context 'when the account has posted multiple toots' do
  200. let!(:old_status) { Fabricate(:status, created_at: 3.weeks.ago, account: account) }
  201. before do
  202. Fabricate(:status, created_at: 3.years.ago, account: account)
  203. Fabricate(:status, created_at: 2.days.ago, account: account)
  204. end
  205. it 'returns the most recent id that is still below policy age' do
  206. expect(subject).to eq old_status.id
  207. end
  208. end
  209. context 'when the account has not posted anything' do
  210. it 'returns nil' do
  211. expect(subject).to be_nil
  212. end
  213. end
  214. end
  215. describe '#statuses_to_delete' do
  216. subject { account_statuses_cleanup_policy.statuses_to_delete }
  217. let!(:unrelated_status) { Fabricate(:status, created_at: 3.years.ago) }
  218. let!(:very_old_status) { Fabricate(:status, created_at: 3.years.ago, account: account) }
  219. let!(:pinned_status) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  220. let!(:direct_message) { Fabricate(:status, created_at: 1.year.ago, account: account, visibility: :direct) }
  221. let!(:self_faved) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  222. let!(:self_bookmarked) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  223. let!(:status_with_poll) { Fabricate(:status, created_at: 1.year.ago, account: account, poll_attributes: { account: account, voters_count: 0, options: %w(a b), expires_in: 2.days }) }
  224. let!(:status_with_media) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  225. let!(:faved_primary) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  226. let!(:faved_secondary) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  227. let!(:reblogged_primary) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  228. let!(:reblogged_secondary) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  229. let!(:recent_status) { Fabricate(:status, created_at: 2.days.ago, account: account) }
  230. let(:account_statuses_cleanup_policy) { Fabricate(:account_statuses_cleanup_policy, account: account) }
  231. before do
  232. Fabricate(:media_attachment, account: account, status: status_with_media)
  233. Fabricate(:status_pin, account: account, status: pinned_status)
  234. Fabricate(:favourite, account: account, status: self_faved)
  235. Fabricate(:bookmark, account: account, status: self_bookmarked)
  236. faved_primary.status_stat.update(favourites_count: 4)
  237. faved_secondary.status_stat.update(favourites_count: 5)
  238. reblogged_primary.status_stat.update(reblogs_count: 4)
  239. reblogged_secondary.status_stat.update(reblogs_count: 5)
  240. end
  241. context 'when passed a max_id' do
  242. subject { account_statuses_cleanup_policy.statuses_to_delete(50, old_status.id).pluck(:id) }
  243. let!(:old_status) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  244. let!(:slightly_less_old_status) { Fabricate(:status, created_at: 6.months.ago, account: account) }
  245. it 'returns statuses included the max_id and older than the max_id but not newer than max_id' do
  246. expect(subject)
  247. .to include(old_status.id)
  248. .and include(very_old_status.id)
  249. .and not_include(slightly_less_old_status.id)
  250. end
  251. end
  252. context 'when passed a min_id' do
  253. subject { account_statuses_cleanup_policy.statuses_to_delete(50, recent_status.id, old_status.id).pluck(:id) }
  254. let!(:old_status) { Fabricate(:status, created_at: 1.year.ago, account: account) }
  255. let!(:slightly_less_old_status) { Fabricate(:status, created_at: 6.months.ago, account: account) }
  256. it 'returns statuses including min_id and newer than min_id, but not older than min_id' do
  257. expect(subject)
  258. .to include(old_status.id)
  259. .and include(slightly_less_old_status.id)
  260. .and not_include(very_old_status.id)
  261. end
  262. end
  263. context 'when passed a low limit' do
  264. it 'only returns the limited number of items' do
  265. expect(account_statuses_cleanup_policy.statuses_to_delete(1).count).to eq 1
  266. end
  267. end
  268. context 'when policy is set to keep statuses more recent than 2 years' do
  269. before do
  270. account_statuses_cleanup_policy.min_status_age = 2.years.seconds
  271. end
  272. it 'does not return unrelated old status and does return oldest status' do
  273. expect(subject.pluck(:id))
  274. .to not_include(unrelated_status.id)
  275. .and eq [very_old_status.id]
  276. end
  277. end
  278. context 'when policy is set to keep DMs and reject everything else' do
  279. before do
  280. account_statuses_cleanup_policy.keep_direct = true
  281. account_statuses_cleanup_policy.keep_pinned = false
  282. account_statuses_cleanup_policy.keep_polls = false
  283. account_statuses_cleanup_policy.keep_media = false
  284. account_statuses_cleanup_policy.keep_self_fav = false
  285. account_statuses_cleanup_policy.keep_self_bookmark = false
  286. end
  287. it 'returns every old status except does not return the old direct message for deletion' do
  288. expect(subject.pluck(:id))
  289. .to not_include(direct_message.id)
  290. .and include(very_old_status.id, pinned_status.id, self_faved.id, self_bookmarked.id, status_with_poll.id, status_with_media.id, faved_primary.id, faved_secondary.id, reblogged_primary.id, reblogged_secondary.id)
  291. end
  292. end
  293. context 'when policy is set to keep self-bookmarked toots and reject everything else' do
  294. before do
  295. account_statuses_cleanup_policy.keep_direct = false
  296. account_statuses_cleanup_policy.keep_pinned = false
  297. account_statuses_cleanup_policy.keep_polls = false
  298. account_statuses_cleanup_policy.keep_media = false
  299. account_statuses_cleanup_policy.keep_self_fav = false
  300. account_statuses_cleanup_policy.keep_self_bookmark = true
  301. end
  302. it 'returns every old status but does not return the old self-bookmarked message for deletion' do
  303. expect(subject.pluck(:id))
  304. .to not_include(self_bookmarked.id)
  305. .and include(direct_message.id, very_old_status.id, pinned_status.id, self_faved.id, status_with_poll.id, status_with_media.id, faved_primary.id, faved_secondary.id, reblogged_primary.id, reblogged_secondary.id)
  306. end
  307. end
  308. context 'when policy is set to keep self-faved toots and reject everything else' do
  309. before do
  310. account_statuses_cleanup_policy.keep_direct = false
  311. account_statuses_cleanup_policy.keep_pinned = false
  312. account_statuses_cleanup_policy.keep_polls = false
  313. account_statuses_cleanup_policy.keep_media = false
  314. account_statuses_cleanup_policy.keep_self_fav = true
  315. account_statuses_cleanup_policy.keep_self_bookmark = false
  316. end
  317. it 'returns every old status but does not return the old self-faved message for deletion' do
  318. expect(subject.pluck(:id))
  319. .to not_include(self_faved.id)
  320. .and include(direct_message.id, very_old_status.id, pinned_status.id, self_bookmarked.id, status_with_poll.id, status_with_media.id, faved_primary.id, faved_secondary.id, reblogged_primary.id, reblogged_secondary.id)
  321. end
  322. end
  323. context 'when policy is set to keep toots with media and reject everything else' do
  324. before do
  325. account_statuses_cleanup_policy.keep_direct = false
  326. account_statuses_cleanup_policy.keep_pinned = false
  327. account_statuses_cleanup_policy.keep_polls = false
  328. account_statuses_cleanup_policy.keep_media = true
  329. account_statuses_cleanup_policy.keep_self_fav = false
  330. account_statuses_cleanup_policy.keep_self_bookmark = false
  331. end
  332. it 'returns every old status but does not return the old message with media for deletion' do
  333. expect(subject.pluck(:id))
  334. .to not_include(status_with_media.id)
  335. .and include(direct_message.id, very_old_status.id, pinned_status.id, self_faved.id, self_bookmarked.id, status_with_poll.id, faved_primary.id, faved_secondary.id, reblogged_primary.id, reblogged_secondary.id)
  336. end
  337. end
  338. context 'when policy is set to keep toots with polls and reject everything else' do
  339. before do
  340. account_statuses_cleanup_policy.keep_direct = false
  341. account_statuses_cleanup_policy.keep_pinned = false
  342. account_statuses_cleanup_policy.keep_polls = true
  343. account_statuses_cleanup_policy.keep_media = false
  344. account_statuses_cleanup_policy.keep_self_fav = false
  345. account_statuses_cleanup_policy.keep_self_bookmark = false
  346. end
  347. it 'returns every old status but does not return the old poll message for deletion' do
  348. expect(subject.pluck(:id))
  349. .to not_include(status_with_poll.id)
  350. .and include(direct_message.id, very_old_status.id, pinned_status.id, self_faved.id, self_bookmarked.id, status_with_media.id, faved_primary.id, faved_secondary.id, reblogged_primary.id, reblogged_secondary.id)
  351. end
  352. end
  353. context 'when policy is set to keep pinned toots and reject everything else' do
  354. before do
  355. account_statuses_cleanup_policy.keep_direct = false
  356. account_statuses_cleanup_policy.keep_pinned = true
  357. account_statuses_cleanup_policy.keep_polls = false
  358. account_statuses_cleanup_policy.keep_media = false
  359. account_statuses_cleanup_policy.keep_self_fav = false
  360. account_statuses_cleanup_policy.keep_self_bookmark = false
  361. end
  362. it 'returns every old status but does not return the old pinned message for deletion' do
  363. expect(subject.pluck(:id))
  364. .to not_include(pinned_status.id)
  365. .and include(direct_message.id, very_old_status.id, self_faved.id, self_bookmarked.id, status_with_poll.id, status_with_media.id, faved_primary.id, faved_secondary.id, reblogged_primary.id, reblogged_secondary.id)
  366. end
  367. end
  368. context 'when policy is to not keep any special messages' do
  369. before do
  370. account_statuses_cleanup_policy.keep_direct = false
  371. account_statuses_cleanup_policy.keep_pinned = false
  372. account_statuses_cleanup_policy.keep_polls = false
  373. account_statuses_cleanup_policy.keep_media = false
  374. account_statuses_cleanup_policy.keep_self_fav = false
  375. account_statuses_cleanup_policy.keep_self_bookmark = false
  376. end
  377. it 'returns every old status but does not return the recent or unrelated statuses' do
  378. expect(subject.pluck(:id))
  379. .to not_include(recent_status.id)
  380. .and not_include(unrelated_status.id)
  381. .and include(direct_message.id, very_old_status.id, pinned_status.id, self_faved.id, self_bookmarked.id, status_with_poll.id, status_with_media.id, faved_primary.id, faved_secondary.id, reblogged_primary.id, reblogged_secondary.id)
  382. end
  383. end
  384. context 'when policy is set to keep every category of toots' do
  385. before do
  386. account_statuses_cleanup_policy.keep_direct = true
  387. account_statuses_cleanup_policy.keep_pinned = true
  388. account_statuses_cleanup_policy.keep_polls = true
  389. account_statuses_cleanup_policy.keep_media = true
  390. account_statuses_cleanup_policy.keep_self_fav = true
  391. account_statuses_cleanup_policy.keep_self_bookmark = true
  392. end
  393. it 'returns normal statuses and does not return unrelated old status' do
  394. expect(subject.pluck(:id))
  395. .to not_include(unrelated_status.id)
  396. .and contain_exactly(very_old_status.id, faved_primary.id, faved_secondary.id, reblogged_primary.id, reblogged_secondary.id)
  397. end
  398. end
  399. context 'when policy is to keep statuses with at least 5 boosts' do
  400. before do
  401. account_statuses_cleanup_policy.min_reblogs = 5
  402. end
  403. it 'returns old not-reblogged statuses but does not return the recent, 5-times reblogged, or unrelated statuses' do
  404. expect(subject.pluck(:id))
  405. .to not_include(recent_status.id)
  406. .and not_include(reblogged_secondary.id)
  407. .and not_include(unrelated_status.id)
  408. .and include(very_old_status.id, faved_primary.id, faved_secondary.id, reblogged_primary.id)
  409. end
  410. end
  411. context 'when policy is to keep statuses with at least 5 favs' do
  412. before do
  413. account_statuses_cleanup_policy.min_favs = 5
  414. end
  415. it 'returns old not-faved statuses but does not return the recent, 5-times faved, or unrelated statuses' do
  416. expect(subject.pluck(:id))
  417. .to not_include(recent_status.id)
  418. .and not_include(faved_secondary.id)
  419. .and not_include(unrelated_status.id)
  420. .and include(very_old_status.id, faved_primary.id, reblogged_primary.id, reblogged_secondary.id)
  421. end
  422. end
  423. end
  424. end