2022-11-04 20:10:26 +01:00
|
|
|
[versions]
|
2024-04-10 21:53:39 +02:00
|
|
|
agp = "8.3.2"
|
2024-02-23 10:58:17 +01:00
|
|
|
androidx-activity = "1.8.2"
|
2023-02-20 20:36:11 +01:00
|
|
|
androidx-appcompat = "1.6.1"
|
2024-03-09 13:32:42 +01:00
|
|
|
androidx-browser = "1.8.0"
|
2022-11-04 20:10:26 +01:00
|
|
|
androidx-cardview = "1.0.0"
|
|
|
|
androidx-constraintlayout = "2.1.4"
|
2024-02-23 10:51:10 +01:00
|
|
|
androidx-core = "1.12.0"
|
2024-01-05 19:53:33 +01:00
|
|
|
androidx-exifinterface = "1.3.7"
|
2024-01-05 20:22:08 +01:00
|
|
|
androidx-fragment = "1.6.2"
|
2023-02-04 20:22:29 +01:00
|
|
|
androidx-junit = "1.1.5"
|
2024-02-23 12:33:18 +01:00
|
|
|
androidx-lifecycle = "2.7.0"
|
2024-04-10 21:53:14 +02:00
|
|
|
androidx-media3 = "1.3.1"
|
2023-11-01 09:23:43 +01:00
|
|
|
androidx-paging = "3.2.1"
|
2023-11-01 11:39:08 +01:00
|
|
|
androidx-preference = "1.2.1"
|
2023-03-21 20:08:43 +01:00
|
|
|
androidx-recyclerview = "1.3.0"
|
2022-11-04 20:10:26 +01:00
|
|
|
androidx-sharetarget = "1.2.0"
|
2023-04-20 19:11:13 +02:00
|
|
|
androidx-splashscreen = "1.0.1"
|
2022-11-04 20:10:26 +01:00
|
|
|
androidx-swiperefresh-layout = "1.1.0"
|
2023-02-28 21:35:31 +01:00
|
|
|
androidx-testing = "2.2.0"
|
2022-11-04 20:10:26 +01:00
|
|
|
androidx-viewpager2 = "1.0.0"
|
2024-02-23 12:52:36 +01:00
|
|
|
androidx-work = "2.9.0"
|
2024-02-23 12:21:31 +01:00
|
|
|
androidx-room = "2.6.1"
|
2022-11-04 20:10:26 +01:00
|
|
|
bouncycastle = "1.70"
|
|
|
|
conscrypt = "2.5.2"
|
Update Kotlin (#4263)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.devtools.ksp](https://goo.gle/ksp)
([source](https://togithub.com/google/ksp)) | `1.9.22-1.0.16` ->
`1.9.22-1.0.17` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.devtools.ksp/1.9.22-1.0.17?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.devtools.ksp/1.9.22-1.0.17?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.devtools.ksp/1.9.22-1.0.16/1.9.22-1.0.17?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.devtools.ksp/1.9.22-1.0.16/1.9.22-1.0.17?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[org.jetbrains.kotlinx:kotlinx-coroutines-test](https://togithub.com/Kotlin/kotlinx.coroutines)
| `1.7.3` -> `1.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.jetbrains.kotlinx:kotlinx-coroutines-test/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.jetbrains.kotlinx:kotlinx-coroutines-test/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.jetbrains.kotlinx:kotlinx-coroutines-test/1.7.3/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.jetbrains.kotlinx:kotlinx-coroutines-test/1.7.3/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[org.jetbrains.kotlinx:kotlinx-coroutines-rx3](https://togithub.com/Kotlin/kotlinx.coroutines)
| `1.7.3` -> `1.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.jetbrains.kotlinx:kotlinx-coroutines-rx3/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.jetbrains.kotlinx:kotlinx-coroutines-rx3/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.jetbrains.kotlinx:kotlinx-coroutines-rx3/1.7.3/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.jetbrains.kotlinx:kotlinx-coroutines-rx3/1.7.3/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[org.jetbrains.kotlinx:kotlinx-coroutines-android](https://togithub.com/Kotlin/kotlinx.coroutines)
| `1.7.3` -> `1.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.jetbrains.kotlinx:kotlinx-coroutines-android/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.jetbrains.kotlinx:kotlinx-coroutines-android/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.jetbrains.kotlinx:kotlinx-coroutines-android/1.7.3/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.jetbrains.kotlinx:kotlinx-coroutines-android/1.7.3/1.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
---
### Release Notes
<details>
<summary>google/ksp (com.google.devtools.ksp)</summary>
###
[`v1.9.22-1.0.17`](https://togithub.com/google/ksp/releases/tag/1.9.22-1.0.17)
[Compare
Source](https://togithub.com/google/ksp/compare/1.9.22-1.0.16...1.9.22-1.0.17)
##### Issues fixed
- Annotations missing on KSTypeArgument of typealias
[#​1679](https://togithub.com/google/ksp/issues/1679)
- unhandled visibility: private to this
[#​1515](https://togithub.com/google/ksp/issues/1515)
- `Resolver#getJvmCheckedException` results in `<ERROR TYPE>` when
throwing type variable.
[#​1460](https://togithub.com/google/ksp/issues/1460)
- Class annotation values with `$` in name are `null` when used in
Kotlin source
[#​1671](https://togithub.com/google/ksp/issues/1671)
- KSP 1.9.21-1.0.15 leaking memory and causing OOMs
[#​1653](https://togithub.com/google/ksp/issues/1653)
- KSP processing fails with Java enum
[#​1482](https://togithub.com/google/ksp/issues/1482)
- \[KSP2] Support Package annotations
[#​1641](https://togithub.com/google/ksp/issues/1641)
</details>
<details>
<summary>Kotlin/kotlinx.coroutines
(org.jetbrains.kotlinx:kotlinx-coroutines-test)</summary>
###
[`v1.8.0`](https://togithub.com/Kotlin/kotlinx.coroutines/blob/HEAD/CHANGES.md#Version-180)
[Compare
Source](https://togithub.com/Kotlin/kotlinx.coroutines/compare/1.7.3...1.8.0)
- Implement the library for the Web Assembly (Wasm) for JavaScript
([#​3713](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3713)).
Thanks [@​igoriakovlev](https://togithub.com/igoriakovlev)!
- Major Kotlin version update: was 1.8.20, became 1.9.21.
- On Android, ensure that `Dispatchers.Main !=
Dispatchers.Main.immediate`
([#​3545](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3545),
[#​3963](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3963)).
- Fixed a bug that caused `Flow` operators that limit cancel the
upstream flow to forget that they were already finished if there is
another such operator upstream
([#​4035](https://togithub.com/Kotlin/kotlinx.coroutines/issues/4035),
[#​4038](https://togithub.com/Kotlin/kotlinx.coroutines/issues/4038))
- `kotlinx-coroutines-debug` is published with the correct Java 9 module
info
([#​3944](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3944)).
- `kotlinx-coroutines-debug` no longer requires manually setting
`DebugProbes.enableCoroutineCreationStackTraces` to `false`, it's the
default
([#​3783](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3783)).
- `kotlinx-coroutines-test`: set the default timeout of `runTest` to 60
seconds, added the ability to configure it on the JVM with the
`kotlinx.coroutines.test.default_timeout=10s`
([#​3800](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3800)).
- `kotlinx-coroutines-test`: fixed a bug that could lead to not all
uncaught exceptions being reported after some tests failed
([#​3800](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3800)).
- `delay(Duration)` rounds nanoseconds up to whole milliseconds and not
down
([#​3920](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3920)).
Thanks [@​kevincianfarini](https://togithub.com/kevincianfarini)!
- `Dispatchers.Default` and the default thread for background work are
guaranteed to use the same context classloader as the object containing
it them
([#​3832](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3832)).
- It is guaranteed that by the time `SharedFlow.collect` suspends for
the first time, it's registered as a subscriber for that `SharedFlow`
([#​3885](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3885)).
Before, it was also true, but not documented.
- Atomicfu version is updated to 0.23.1, and Kotlin/Native atomic
transformations are enabled, reducing the footprint of coroutine-heavy
code
([#​3954](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3954)).
- Added a workaround for miscompilation of `withLock` on JS
([#​3881](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3881)).
Thanks [@​CLOVIS-AI](https://togithub.com/CLOVIS-AI)!
- Small tweaks and documentation fixes.
##### Changelog relative to version 1.8.0-RC2
- `kotlinx-coroutines-debug` no longer requires manually setting
`DebugProbes.enableCoroutineCreationStackTraces` to `false`, it's the
default
([#​3783](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3783)).
- Fixed a bug that caused `Flow` operators that limit cancel the
upstream flow to forget that they were already finished if there is
another such operator upstream
([#​4035](https://togithub.com/Kotlin/kotlinx.coroutines/issues/4035),
[#​4038](https://togithub.com/Kotlin/kotlinx.coroutines/issues/4038))
- Small documentation fixes.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tuskyapp/Tusky).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-23 11:18:09 +01:00
|
|
|
coroutines = "1.8.0"
|
2024-03-29 20:12:08 +01:00
|
|
|
dagger = "2.51.1"
|
2023-03-10 20:30:55 +01:00
|
|
|
diffx = "1.1.1"
|
2024-02-23 11:28:14 +01:00
|
|
|
emoji2 = "1.4.0"
|
2023-02-04 20:22:29 +01:00
|
|
|
espresso = "3.5.1"
|
2023-01-09 21:06:47 +01:00
|
|
|
filemoji-compat = "3.2.7"
|
2023-09-11 19:29:50 +02:00
|
|
|
glide = "4.16.0"
|
2023-05-19 13:30:57 +02:00
|
|
|
# Deliberate downgrade, https://github.com/tuskyapp/Tusky/issues/3631
|
|
|
|
glide-animation-plugin = "2.23.0"
|
2024-03-09 13:33:03 +01:00
|
|
|
kotlin = "1.9.23"
|
2023-02-21 19:43:51 +01:00
|
|
|
image-cropper = "4.3.2"
|
Update dependency com.google.android.material:material to v1.11.0 (#4268)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.google.android.material:material](https://togithub.com/material-components/material-components-android)
| `1.9.0` -> `1.11.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.android.material:material/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.android.material:material/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.android.material:material/1.9.0/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.android.material:material/1.9.0/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
---
### Release Notes
<details>
<summary>material-components/material-components-android
(com.google.android.material:material)</summary>
###
[`v1.11.0`](https://togithub.com/material-components/material-components-android/releases/tag/1.11.0)
[Compare
Source](https://togithub.com/material-components/material-components-android/compare/1.10.0...1.11.0)
### Important
Elevation Overlays within default component styles have been replaced by
the new [Tonal Surface Color
system](https://material.io/blog/tone-based-surface-color-m3). Instead
of blending the Primary color with the Surface color based on an
elevation value, components now use a specific Surface color role that
can be more easily understood and customized.
Documentation for the affected components and which Surface color roles
they use has been updated in
https://github.com/material-components/material-components-android/commit/2114a11378fd801b32cd7431bb8a2c94de4f462c.
### What's new since 1.10.0
- New [Tonal Surface Color
system](https://material.io/blog/tone-based-surface-color-m3)! Check out
the [design
guidance](https://material.io/blog/tone-based-surface-color-m3) and the
[commit with documentation
updates](https://togithub.com/material-components/material-components-android/commit/2114a11378fd801b32cd7431bb8a2c94de4f462c)
for more details.
- New Carousel variants! 1.11.0 introduces three new Carousel variants:
center-aligned hero, uncontained, and fullscreen. Check out the
[Carousel
documentation](https://togithub.com/material-components/material-components-android/blob/master/docs/components/Carousel.md)
for more details.
#### Dependency Updates
None.
*Note: Earlier versions of 1.11.0 used other versions of the
`androidx.activity` 1.8.0 library dependency, but there is no change in
the dependency from 1.10.0, the last stable MDC library version.*
#### Library Updates
- `Badging`
- Adjusted badge vertical offset for certain components to fit design
requirements
([`78cc54b`](https://togithub.com/material-components/material-components-android/commit/78cc54b8c39da437732ff3d7c96de8f345e09348))
- Added note in attachBadgeDrawable method docs about menu item views
being re-used when there is a structural change in the menu. Since
badges are attached to the views, this may change the menu item that the
badge is intended for
([`5e6ea58`](https://togithub.com/material-components/material-components-android/commit/5e6ea582801ebfe2af8457261581a2ad43c8051a))
- `BottomNavigationView`
- Set badges to be null instead of removing them from the sparse array
so that removing badges before restoring badge states will not override
the current state
([`9f2e686`](https://togithub.com/material-components/material-components-android/commit/9f2e6864d2170d633709e7aa66b9e8e178352ef0))
- `BottomSheet`
- Fix sheet corners animation
([`de27132`](https://togithub.com/material-components/material-components-android/commit/de271320e4ba046c73e35e18f687ee4637f3a6ac))
- `Carousel`
- Ensure that extra small size is not larger than the large size
([`17baf71`](https://togithub.com/material-components/material-components-android/commit/17baf71972016cf4608d9c83b902bb2debee585b))
- Fixed crash when recyclerview has a size of zero.
([`26c3129`](https://togithub.com/material-components/material-components-android/commit/26c31292012868d7e9889f6ecee7559c61caa5b2))
- When navigating with keyboard, scroll focused item to nearest focal
keyline, not the first focal keyline
([`fb9c1c6`](https://togithub.com/material-components/material-components-android/commit/fb9c1c6edfbdbe4791043a128c03a7fad5fd99f0))
- Force hero strategy to be start-aligned if there are not enough items
to make it center-aligned
([`9a2347b`](https://togithub.com/material-components/material-components-android/commit/9a2347bda5312dd6dc3ab7818a6f71297dcf018b))
- Add logic for multibrowse strategy to change strategy when number of
items is less than the number of keylines
([`cbb380d`](https://togithub.com/material-components/material-components-android/commit/cbb380df61f8eb66273043b437582c8058df7088))
- Fixed focus order when using keyboard navigation for hero carousels.
([`0356f24`](https://togithub.com/material-components/material-components-android/commit/0356f24a63b5c47ee23cbf5c0fca4d817e4d6acd))
- Cleaning up multi-browse strategy and removing compact arrangement
([`ed4647d`](https://togithub.com/material-components/material-components-android/commit/ed4647d5dfa42876063521546de2dbcf71914e01))
- Disallowing center aligned hero strategy with only 2 items since it
does not make any sense. With only 2 items there can only be a start
state and end state with the hero strategy.
([`d5d604d`](https://togithub.com/material-components/material-components-android/commit/d5d604d0ccfd73b4345dbea8fd3f833410fd2958))
- Fix issue with uncontained carousel not having a proper end scroll
value due to assumption made in end scroll calculation
([`8cb444b`](https://togithub.com/material-components/material-components-android/commit/8cb444b26856fdb8b0c894eccbf90133efc2a2b6))
- Added tests for hero and multibrowse strategies when the carousel
container is very small.
([`8312162`](https://togithub.com/material-components/material-components-android/commit/8312162f533d1c9fc9e9b15ceca58e3d1d4b61b5))
- Update scroll offset to scroll to the estimated position that it was
at upon an initial load
([`4a6ae4d`](https://togithub.com/material-components/material-components-android/commit/4a6ae4d0b6969311b41b3878e3c0e7f7a0824a72))
- Fixed strategies crashing when there is not enough available space for
a large and a small item
([`c418063`](https://togithub.com/material-components/material-components-android/commit/c418063205d74233a6235d7f7fd39be7deeb4bc7))
- Tweak uncontained strategy logic to adjust medium size items to
improve motion
([`93660d4`](https://togithub.com/material-components/material-components-android/commit/93660d424139642320c85a098f0fb728126d4838))
- Fixed formatted for KeylineState and KeylineStateList
([`b80d9a5`](https://togithub.com/material-components/material-components-android/commit/b80d9a5ef4d93567554d5aac85c4070b4577d9fc))
- Fixed keyline shifting in RTL for uncontained carousels
([`7151714`](https://togithub.com/material-components/material-components-android/commit/71517147110227e8032f5b064d6b59c5e3f117de))
- Reduce the number of truncations in intermediate calculations
([`4ce7e4c`](https://togithub.com/material-components/material-components-android/commit/4ce7e4c8fa84ce05a6c34591855dd1207e44e42b))
- Update vertical scroll speed to be faster
([`c6ea2d4`](https://togithub.com/material-components/material-components-android/commit/c6ea2d404023ca1a92cb95eb3f177579df1c2d28))
- Fix some a11y bugs in Carousel
([`3d84841`](https://togithub.com/material-components/material-components-android/commit/3d84841caddd6e0127e67721844a3900225ab3a9))
- Center aligned uncontained carousel
([`b6f6eb5`](https://togithub.com/material-components/material-components-android/commit/b6f6eb555a0477322aa1ab4115f90d74d25a2266))
- Add left-aligned uncontained strategy
([`9d81cac`](https://togithub.com/material-components/material-components-android/commit/9d81cac125144576501ca19dafa835625e5cf5c7))
- Fix orientation not correct in item decoration calculations
([`966f7da`](https://togithub.com/material-components/material-components-android/commit/966f7daec9d02092aadc63324212be9ae6dc8f2a))
- Update mask size on size change if mask x percentage has been set
([`dc91b39`](https://togithub.com/material-components/material-components-android/commit/dc91b39d7c9af5a531a4f2f761297c6e44b8f08c))
- Fix issue with next carousel item not being masked properly
([`a16f180`](https://togithub.com/material-components/material-components-android/commit/a16f180ce7da65107305ba3a8c85db3e149767c1))
- Add a layout listener to recyclerview to refresh keyline state upon
size change
([`ff52862`](https://togithub.com/material-components/material-components-android/commit/ff528621b3b550979c64f41aaec47438de30f061))
- Remove default list from Carousel catalog demos as it is not an
example of a carousel
([`0171624`](https://togithub.com/material-components/material-components-android/commit/0171624c16c799ca4e2dbe01e647a706fe7b895e))
- Add carousel alignment attribute
([`547156e`](https://togithub.com/material-components/material-components-android/commit/547156e497b692eff7e85b2b8a44345a7c853689))
- Fix issue with not refreshing keylines
([`674ec44`](https://togithub.com/material-components/material-components-android/commit/674ec4442963f143334906b160ac5cb5a6fd9985))
- Fixed MaskableFrameLayout not updating mask after size change when
setting the mask using setMaskXPercentage.
([`14023d2`](https://togithub.com/material-components/material-components-android/commit/14023d2c8589a515ae0d80f75f301077aa324f08))
- Adding docs for fullscreen carousel strategy
([`7c40359`](https://togithub.com/material-components/material-components-android/commit/7c40359d2b920d37effd58fdb0f4834fb4f4bf0f))
- Add fullscreen demo to catalog
([`ad6afbf`](https://togithub.com/material-components/material-components-android/commit/ad6afbf6d85d81a85fa855830c8dadba43095905))
- Add full screen strategy
([`bc54f2e`](https://togithub.com/material-components/material-components-android/commit/bc54f2e4b37307c53521f2789a1789aff7158173))
- `Catalog`
- Use BottomSheetDialogFragment
([`2c53952`](https://togithub.com/material-components/material-components-android/commit/2c539524ec62713028e9521ca7b80c38c6aabf9c))
- Update navigation drawer state handling to be more accurate in demo
([`74ac87c`](https://togithub.com/material-components/material-components-android/commit/74ac87cb612dffc31767fc829fbc86d69945c2b6))
- Update navigation drawer state handling to be more accurate in custom
drawer demo
([`1252d4f`](https://togithub.com/material-components/material-components-android/commit/1252d4f2639b2c98136b3de5a1e16a0facc56a78))
- When bottom sheet is collapsed, back callback is enabled
([`98439df`](https://togithub.com/material-components/material-components-android/commit/98439df4fb9c79c3f4bab3107b995fc612702ec1))
- Update side sheet state handling to be more accurate in demos
([`357cf2d`](https://togithub.com/material-components/material-components-android/commit/357cf2d9ca79227a35c48903bf73270bc92e105c))
- Update bottom sheet state handling to be more accurate in demos
([`f9102c7`](https://togithub.com/material-components/material-components-android/commit/f9102c745ad8b84dc16a4914665f2bb40aa4f5a2))
- Fixed demos in RTL
([`4e1b130`](https://togithub.com/material-components/material-components-android/commit/4e1b130cdfdff619d9629d39f90c81332efb4a4e))
- Make side sheet demo icon easier to see in dark mode
([`79a1953`](https://togithub.com/material-components/material-components-android/commit/79a19537d70aef6f451910b4432ca2099afe6f7b))
- Remove explicit Catalog dependency on androidx.activity now that
library depends on it
([`3bb69f5`](https://togithub.com/material-components/material-components-android/commit/3bb69f501af9b98d2634583de98ae57ee9bf7d4e))
- buid.gradle update.
([`4847799`](https://togithub.com/material-components/material-components-android/commit/484779902e6cc01e305134a218cfae84370da4e6))
- Remove edge-to-edge to top app bar demos due to glitches in ActionBar
demo
([`c40e468`](https://togithub.com/material-components/material-components-android/commit/c40e46882088487aadd8ba7626125caa44555e5e))
- Update slider position when carousel is scrolled in uncontained
carousel demo
([`480bbc6`](https://togithub.com/material-components/material-components-android/commit/480bbc6a9b3c11c35b35c3e08ac9034f70619d6c))
- Applied edge-to-edge to top app bar demos
([`aa5b5bc`](https://togithub.com/material-components/material-components-android/commit/aa5b5bc157d935cf616ce8d172d157d008308038))
- Add uncontained carousel demo to catalog
([`ef9f918`](https://togithub.com/material-components/material-components-android/commit/ef9f91864f52f3a4335a82a073eea2cff7991c2d))
- Update slider position when carousel is scrolled in catalog demos
([`3652fde`](https://togithub.com/material-components/material-components-android/commit/3652fde271bb7ef9bf4ff6262cc8288bd3a26fe2))
- Applied edge-to-edge to bottom sheet in Carousel demo
([`6c2dd5d`](https://togithub.com/material-components/material-components-android/commit/6c2dd5d69ee6e050f714d82fbe5e5ce2e5ec4fae))
- Fix fullscreen vertical carousel to use vertical dividers
([`af7d09a`](https://togithub.com/material-components/material-components-android/commit/af7d09a43d29f4820f695119e6dad3df18e357cf))
- Add alignment option to hero carousel
([`7cfd30f`](https://togithub.com/material-components/material-components-android/commit/7cfd30f99b0ccb44540d124b9cca201d1b707e3b))
- `Chip`
- Fix a typo in attributes table in documentation
([`7289aa6`](https://togithub.com/material-components/material-components-android/commit/7289aa681d573921570b81b4784246fdcb2071d1))
- `CollapsingToolbarLayout`
- Fix issue where expanded text gets ellipsized too aggressively when
using title fade mode and the toolbar has menu items
([`094e3e2`](https://togithub.com/material-components/material-components-android/commit/094e3e21eac24258604d367e04286f6ed247257d))
- Fixed title collapse fade mode color to use a Tonal Surface role
instead of elevation overlay
([`5f2b4b2`](https://togithub.com/material-components/material-components-android/commit/5f2b4b2531b9074126e9659c23d24c6689838545))
- `Color`
- Delete unused contrast resources
([`541df07`](https://togithub.com/material-components/material-components-android/commit/541df074a7c9a08dbde19e32778e7f05624355af))
- Updated focused and pressed state from 0.12 to 0.10 to increase the
contrast ratio with tonal surface color.
([`bc824b4`](https://togithub.com/material-components/material-components-android/commit/bc824b4344c90e183eca8aca2d9019da6cb5ebee))
- Updated colors of container transform demo
([`d16f223`](https://togithub.com/material-components/material-components-android/commit/d16f22341e2a7fe42db4b234f91e76a652246a8a))
- Add ColorStateListDrawable support
([`0663019`](https://togithub.com/material-components/material-components-android/commit/0663019f45f921edec76ac3506d6708cf8306002))
- Removed layered drawable for the background after tonal surface color.
([`b5d6f1a`](https://togithub.com/material-components/material-components-android/commit/b5d6f1ae451c86696252114a2e9d4d5a4ba6c514))
- Upgraded to v0.170 for tonal surface colors.
([`8204856`](https://togithub.com/material-components/material-components-android/commit/8204856dd45da7f0e22c5d8131014e072340796e))
- Update constructor comments
([`ba465a2`](https://togithub.com/material-components/material-components-android/commit/ba465a2b17fdab3869d2930819da4054843e20d7))
- `Divider`
- Add RTL support
([`6b897c6`](https://togithub.com/material-components/material-components-android/commit/6b897c6121cfa3822133c0984807755b45634efb))
- `Documentation`
- Add note to clarify that automatic back handling in components is only
for API 33+
([`ad2b5f8`](https://togithub.com/material-components/material-components-android/commit/ad2b5f8f8bba4d7ad44c26ba26d1036e2fd81144))
- Update Predictive Back doc to recommend 1.10.0 stable version
([`b8b1a66`](https://togithub.com/material-components/material-components-android/commit/b8b1a662de6fe08a8336bdd54ae91255f1b9a3d8))
- Update doc to explain how to allow Top App Bar to grow taller in
response to system font setting
([`a01a68d`](https://togithub.com/material-components/material-components-android/commit/a01a68de2d0ad68576f0e0484dd108fcb07226c7))
- Fix carousel docs
([`247240c`](https://togithub.com/material-components/material-components-android/commit/247240c3cdd8d6bd7a352556e5981f9dbeced8b2))
- Add uncontained variant docs
([`9ee4aba`](https://togithub.com/material-components/material-components-android/commit/9ee4aba0071995345d4b71be6bb91be776337afe))
- Minor code block improvements
([`d7e75bb`](https://togithub.com/material-components/material-components-android/commit/d7e75bba59c1406166d8acbf40cd803e6bc12ca1))
- Add guidance in fullscreen strategy docs about portrait orientation
([`caec8d2`](https://togithub.com/material-components/material-components-android/commit/caec8d284918daceb5a66d09a3ccbb50e9c5b2c1))
- Update chip documentation to use `setOnCheckedStateChangeListener`
instead of `setOnCheckedChangeListener` which was deprecated in favour
of the former
([`0582b1a`](https://togithub.com/material-components/material-components-android/commit/0582b1a094b48ece8cdc5e83a3a0378748846788))
- Update example in docs to use `colorContainer` and `colorOnContainer`
instead of `colorPrimary` and `colorOnPrimary`.
([`44bfe2d`](https://togithub.com/material-components/material-components-android/commit/44bfe2ddb866338e793693fd2fda5b982e2a2e10))
- Updated Color dev doc with tonal surface colors.
([`9a4c21d`](https://togithub.com/material-components/material-components-android/commit/9a4c21d77a67f349606fd4194a7d09395ac1d467))
- Updated dev doc for tonal surface colors in affected components.
([`2114a11`](https://togithub.com/material-components/material-components-android/commit/2114a11378fd801b32cd7431bb8a2c94de4f462c))
- Crosslink github docs in javadocs
([`e3b255b`](https://togithub.com/material-components/material-components-android/commit/e3b255b3a01e06bf471f5394a7fcb3458a528b13))
- Cross-reference m.io and DAC in Github docs
([`1785bbf`](https://togithub.com/material-components/material-components-android/commit/1785bbfabeabe747924c13e49050d2e8da585fd4))
- `Material 3`
- Introduce U color tokens
([`ad63d3f`](https://togithub.com/material-components/material-components-android/commit/ad63d3ff7e2e0fa6a6c23a9c4f50a2f40fc723f1))
- Add Meizu to dynamic colors allowlist
([`faf9a32`](https://togithub.com/material-components/material-components-android/commit/faf9a3277046eaa7af9dbd3a4c999d33db50088d))
- Remove resources loader support for tonal surface update
([`1a9d54f`](https://togithub.com/material-components/material-components-android/commit/1a9d54fa419aafd670711a8e83d23aa48c9894b4))
- Added default framework text colors
([`d3dda60`](https://togithub.com/material-components/material-components-android/commit/d3dda60296c7bd6c64d7cde7abcfc7fc28cc1f0e))
- Updated contrast documentation
([`1d3b8e1`](https://togithub.com/material-components/material-components-android/commit/1d3b8e136dd90a189e2e7f168244a47b7ef2b5aa))
- Add shift to dynamic colors allowlist
([`fde37cf`](https://togithub.com/material-components/material-components-android/commit/fde37cfba55340039c8137218da1b813831779eb))
- Expose attr contrastColorThemeOverlay
([`839b14c`](https://togithub.com/material-components/material-components-android/commit/839b14cf0f844366f1727d4f6a3908898ab0e379))
- Add dynamic contrast support
([`862a7e1`](https://togithub.com/material-components/material-components-android/commit/862a7e10c9436be00b9f5b42d6946dfcb8ec8d07))
- `MaterialCardView`
- Support `android:duplicateParentState`.
([`31af945`](https://togithub.com/material-components/material-components-android/commit/31af945caa6216237441e5888c2714464075b2d7))
- `MaterialDatePicker`
- Added builder methods for customizing the positive and negative button
content descriptions
([`a00ee50`](https://togithub.com/material-components/material-components-android/commit/a00ee50907e7bcfc442df7c96fdcaa24f212ccec))
- Fix header layout overlapping
([`5f1cab6`](https://togithub.com/material-components/material-components-android/commit/5f1cab65b11b063e645cc166f12fcca9e1de842a))
- Fixing the "Column of Days:" announcement causing Talkback verbosity
([`a782e7a`](https://togithub.com/material-components/material-components-android/commit/a782e7a1d888fe4234a58869314c31ba01d5084a))
- `NavigationView`
- Set material drawable background if the background has been set as a
ColorStateList
([`eba40e9`](https://togithub.com/material-components/material-components-android/commit/eba40e93452b21bebaf9ed3c30e031f0d321f903))
- `Predictive Back`
- Update to use decelerate interpolator
([`5559cbc`](https://togithub.com/material-components/material-components-android/commit/5559cbc7c7eef1bad325b41bcf1635bac9af1e89))
- Fix issue where predictive back is not enabled in NavigationView after
rotating the screen or restarting the activity when the NavigationView
is already opened as a drawer
([`bccbd4f`](https://togithub.com/material-components/material-components-android/commit/bccbd4f778f59a263ae627be771d5d4409ce4dd2))
- Fix issue where modal accessibility is not reset after collapsing
search view predictively, which caused the screen to appear frozen when
using TalkBack
([`8d83a31`](https://togithub.com/material-components/material-components-android/commit/8d83a31b6be228f43b87254dda544d5bd2b807f5))
- Fixed IllegalStateException crashes caused by
MaterialBackAnimationHelper.
([`02dc779`](https://togithub.com/material-components/material-components-android/commit/02dc77923bb0ad313d8d5a840473db6f17b1051a))
- Fixed `UnsupportedOperationException` `AnimatorSet` crash in
`SearchView`.
([`f101532`](https://togithub.com/material-components/material-components-android/commit/f10153257f6f3fdc112be6a2a4c7eb2e02bf5ed6))
- `ProgressIndicator`
- Allow extending LinearProgressIndicator and CircularProgressIndicator
(Closes
[#​2361](https://togithub.com/material-components/material-components-android/issues/2361))
([`3b0fd58`](https://togithub.com/material-components/material-components-android/commit/3b0fd5868e5a2cd7ac780f2543e94aabd0422d0f))
- `Search`
- Set the `editable` property within `SearchBar`'s
`AccessibilityNodeInfo` representation.
([`be1395b`](https://togithub.com/material-components/material-components-android/commit/be1395bceff22a10ae0e8164cb43fd4908961717))
- Fix issue where predictive back is not enabled in SearchView after
rotating the screen or restarting the activity when the SearchView is
already expanded
([`a51561d`](https://togithub.com/material-components/material-components-android/commit/a51561d8b834a3612b97fa811b49e9680c9bbdc3))
- Enforced outline variant to use colorSurface as container color.
([`720998d`](https://togithub.com/material-components/material-components-android/commit/720998dcbddc93bdcb26643b64fafd29fcfccc90))
- Added support to set a default content description if a content
description is not set explicitly.
([`c15a323`](https://togithub.com/material-components/material-components-android/commit/c15a3231402ab827405398992c3d7eac22dd9cd9))
- `SideSheet`
- Add left sheet/sheet edge documentation.
([`d440e3c`](https://togithub.com/material-components/material-components-android/commit/d440e3c4f89baaa4edfdb89213125d7fd13c7522))
- Fix mixed language snippet
([`f91f17b`](https://togithub.com/material-components/material-components-android/commit/f91f17bb4f1d20c7e6c074cba08d51bc6417fa69))
- `Switch`
- Fix drawable scaling for API < 23
([`a10c508`](https://togithub.com/material-components/material-components-android/commit/a10c5083a9e8ffb58903d9631235fe5f71766010))
- Amendments to thumb icon size support
([`db9a641`](https://togithub.com/material-components/material-components-android/commit/db9a6412ec913e84ebe1f090d54e2d838efe40bc))
- `Tabs`
- Integrated divider token output into the background drawables.
([`6b627c2`](https://togithub.com/material-components/material-components-android/commit/6b627c20e29c811fbd68fdc1ad984b48548b4f9b))
- `TextInputLayout`
- Fix editText paddings on pre-Lollipop
([`2590c42`](https://togithub.com/material-components/material-components-android/commit/2590c42764fc2178114bcd53c339b5368ba2c5d3))
- Fix onMeasure() infinite loop bug caused by posting requestLayout()
before endLayout is fully rendered.
([`93360a5`](https://togithub.com/material-components/material-components-android/commit/93360a5a5d2549c14599507db94423906d5a9757))
- Mutate cursor drawable before tinting it.
([`9a4888f`](https://togithub.com/material-components/material-components-android/commit/9a4888f958cfb6c220a01a9615cf62f8e36500e0))
- `Theming`
- Fix swapped error colors for dynamic contrast theme in light mode
([`f2ccc11`](https://togithub.com/material-components/material-components-android/commit/f2ccc116ea2ada7bcb48ce7388a6c927497b25f3))
- `TimePicker`
- Fix layout getting cut on narrow screens
([`d10201d`](https://togithub.com/material-components/material-components-android/commit/d10201dc88f919421b3bc4d8d7aa432de685c892))
- `Tokens`
- Upgraded to v0.175.
([`bfee8a7`](https://togithub.com/material-components/material-components-android/commit/bfee8a74d7c2e77e1be4195bd2ca81edfcc3da67))
- `TopAppBar`
- Simplified logics to animate the container color between lifted state
and the default state.
([`1e9f5f0`](https://togithub.com/material-components/material-components-android/commit/1e9f5f07305bd3bcf59e874eecf0bc9e062a0501))
- Fix dynamic status bar foreground lift on scroll color when using
Tonal Surface Color on API Level 33
([`c4ae01a`](https://togithub.com/material-components/material-components-android/commit/c4ae01a5a5739d5b52eaec4492dbc6cc304a9457))
- Fix dynamic status bar foreground lift on scroll color when using
Tonal Surface Color
([`569ddac`](https://togithub.com/material-components/material-components-android/commit/569ddac527f6c37b718a2e0dcfb4148fceac4713))
- Fixed that liftOnScrollColor doesn't respect to setLifted when
liftOnScroll is set to false.
([`43242f2`](https://togithub.com/material-components/material-components-android/commit/43242f20de8df34f7d693eadadf9543592ecaf60))
- Added liftOnScroll and lifted toggles to the catalog.
([`4e995d1`](https://togithub.com/material-components/material-components-android/commit/4e995d1f8132f34928152f18493c918bb40987d6))
- Added getMaterialShapeBackground() to return a MaterialShapeDrawable
object of the background (non-lifted layer).
([`c7a0adf`](https://togithub.com/material-components/material-components-android/commit/c7a0adf8dd416c98c25c50740e286bd666826764))
- Updated the handling of liftOnScrollColor not override
android:background.
([`2b476b3`](https://togithub.com/material-components/material-components-android/commit/2b476b3a96ef0ab52206ca0cae479a501a0130ff))
- `Other`
- Cleanup date formats that specify the same field multiple times.
([`f1da3c3`](https://togithub.com/material-components/material-components-android/commit/f1da3c384f780ffa2597bbc20b3dc3cb0fa8e9bc))
- Update androidx.activity dependency to version 1.8.0
([`733fe20`](https://togithub.com/material-components/material-components-android/commit/733fe20d88a093cb52631294951eedf906a967d0))
- Update androidx.activity dependency to version 1.8.0-rc01
([`2cfb127`](https://togithub.com/material-components/material-components-android/commit/2cfb12709599c274763aafee97dc2de952b49153))
- Remove android:targetSdk where it's not needed
([`09382b8`](https://togithub.com/material-components/material-components-android/commit/09382b896c4d3fcf75116d60f26a5b40be88bd7d))
- Update androidx.activity dependency to version 1.8.0-beta01
([`f93c65c`](https://togithub.com/material-components/material-components-android/commit/f93c65c347bd62497f79ff4593f4009a18098890))
- Added a comment before overridden resources.
([`7d8681f`](https://togithub.com/material-components/material-components-android/commit/7d8681f71ded9fa6e31262c847e4fef9c7a88c71))
- Delete BackLayer component
([`4c89301`](https://togithub.com/material-components/material-components-android/commit/4c8930133040f4479524c33aab639fd4a463db3c))
- Stop running Robolectric tests on APIs < 19.
([`0a6a8a9`](https://togithub.com/material-components/material-components-android/commit/0a6a8a971dbeffa47359fa83bf8719ccaa6a21e7))
- Fixed corrupt gradle jar file.
([`ed9b541`](https://togithub.com/material-components/material-components-android/commit/ed9b54129d926fb9d6e91ac7330d8c681ce8b342))
- Upgrade Gradle to 7.6.2.
([`04c0582`](https://togithub.com/material-components/material-components-android/commit/04c05826e4629b8b4bcd80c0d24c81b356e5ecd5))
- Consistently use window coordinates to calculate Snackbar offsets. In
one place screen and window coordinates are mixed, which leads to bad
behavior in split screen apps.
([`57b2663`](https://togithub.com/material-components/material-components-android/commit/57b26639d8b0c376ba70f4d653ce07347880839d))
- 1.11.0-alpha01 Release.
([`76a681a`](https://togithub.com/material-components/material-components-android/commit/76a681abf6500724153d3ba86f40ac9d8ce24438))
#### Full list of release notes
-
[1.11.0-alpha01](https://togithub.com/material-components/material-components-android/releases/tag/1.11.0-alpha01)
-
[1.11.0-alpha02](https://togithub.com/material-components/material-components-android/releases/tag/1.11.0-alpha02)
-
[1.11.0-alpha03](https://togithub.com/material-components/material-components-android/releases/tag/1.11.0-alpha03)
-
[1.11.0-alpha04](https://togithub.com/material-components/material-components-android/releases/tag/1.11.0-alpha04)
-
[1.11.0-alpha05](https://togithub.com/material-components/material-components-android/releases/tag/1.11.0-alpha05)
-
[1.11.0-alpha06](https://togithub.com/material-components/material-components-android/releases/tag/1.11.0-alpha06)
-
[1.11.0-beta01](https://togithub.com/material-components/material-components-android/releases/tag/1.11.0-beta01)
-
[1.11.0-rc01](https://togithub.com/material-components/material-components-android/releases/tag/1.11.0-rc01)
#### Full list of changes
###
[`v1.10.0`](https://togithub.com/material-components/material-components-android/releases/tag/1.10.0)
[Compare
Source](https://togithub.com/material-components/material-components-android/compare/1.9.0...1.10.0)
### What's new since 1.9.0
- Added Predictive back support for search, bottom sheet, side sheet and
navigation drawer. Check out the [developer
documentation](https://togithub.com/material-components/material-components-android/blob/master/docs/foundations/PredictiveBack.md)
for more details.
- Add `Start-aligned` variant to Carousel component. Check out the
[developer
documentation](https://togithub.com/material-components/material-components-android/blob/master/docs/components/Carousel.md)
for more details.
- Badge component updates. Check out the [developer
documentation](https://togithub.com/material-components/material-components-android/blob/master/docs/components/BadgeDrawable.md)
for more details.
- Left & RTL side sheets. Check out the [developer
documentation](https://togithub.com/material-components/material-components-android/blob/master/docs/components/SideSheet.md)
for more details.
#### Important
##### New minimum requirements for your app's project:
- Update `compileSdkVersion` to `34`
#### Dependency Updates
| Dependency | Previous version | New version |
| - | - | - |
| Gradle | 7.2.0 | 7.4.2 |
| androidx.activity | -- | 1.8.0 |
| androidx.appcompat | 1.5.0 | 1.6.1 |
| androidx.resourceinspection:resourceinspection-annotation | -- | 1.0.1
|
| androidx.resourceinspection:resourceinspection-processor | -- | 1.0.1
|
#### Library Updates
- `A11y`
- Do not count headers for accessibility
([`917da52`](https://togithub.com/material-components/material-components-android/commit/917da52393a37695b8c611e130552babf7aea8bc))
- `Badging`
- Deprecate bottom badge gravities and update docs and usages in catalog
([`27abfdb`](https://togithub.com/material-components/material-components-android/commit/27abfdba4fd7622a1ca5aa95d20a0ba3d442b791))
- Add new attribute for vertical offset when font is large
([`2362f4b`](https://togithub.com/material-components/material-components-android/commit/2362f4b64be9d6337e7a214f8338925ddcc32ab0))
- Fix table formatting and remove unnecessary badge invalidation
([`44a97f4`](https://togithub.com/material-components/material-components-android/commit/44a97f4a83a68275311ad3ac544b3223c907564a))
- Fix crash caused by non-ascii strings
([`532b65d`](https://togithub.com/material-components/material-components-android/commit/532b65d008be12c6889aac1bc2de411af5356891))
- Badge cleanup/fixes:
([`4d50aa4`](https://togithub.com/material-components/material-components-android/commit/4d50aa41e714b4b0e0ec4a40672431d4d4f7d6d9))
- Add attribute to automatically adjust badge so that it is within the
anchor view's grandparent view's bounds
([`b706506`](https://togithub.com/material-components/material-components-android/commit/b706506c3d7e12df64375e116d587c2e9b96059b))
- Add getters/setters for vertical and horizontal badge padding
([`a0d0b53`](https://togithub.com/material-components/material-components-android/commit/a0d0b53472751ffafeacd829d5433afde7546db9))
- Allow text strings in badges
([`c1ef52b`](https://togithub.com/material-components/material-components-android/commit/c1ef52b8eaaad4bffe83ca0a7917406835ee5c7a))
- Center badge content more correctly
([`fc0de1b`](https://togithub.com/material-components/material-components-android/commit/fc0de1ba245186d9b74550f0ece2930aaf0df116))
- Add padding in between top and bottom edges of badge and text
([`8499b83`](https://togithub.com/material-components/material-components-android/commit/8499b83ba1fc6e211c8a7228947b03c1e3c30531))
- Integrating tokens
([`68c844c`](https://togithub.com/material-components/material-components-android/commit/68c844c91d9e54fca475bd503f01474f29cff559))
- Add shape appearance for badges
([`2ddcfe4`](https://togithub.com/material-components/material-components-android/commit/2ddcfe46b7603c89b6715ac4406aa3eb6c275f60))
- Update badge images
([`c1eba1b`](https://togithub.com/material-components/material-components-android/commit/c1eba1b26809fdc529fc599fc48dea165a202e22))
- `BottomAppBar`
- Fix bug with transparent top app bar when in bottom app bar layout
([`c22eb0d`](https://togithub.com/material-components/material-components-android/commit/c22eb0d31bbd1e87b244100b8ae7d5d7995394a6))
- Fix issue with pre-21 FAB elevation/shadow sometimes appearing
([`2ea3df9`](https://togithub.com/material-components/material-components-android/commit/2ea3df991f14488ef21593f5c72792dd470923d2))
- `BottomNavigationView`
- Integrate tokens and add shape appearance support
([`7bd9724`](https://togithub.com/material-components/material-components-android/commit/7bd97240786ad84eae6bdaac6b4fde767910022b))
- `BottomSheet`
- Fix sheet corners animation
([`a5ff190`](https://togithub.com/material-components/material-components-android/commit/a5ff190f529d2ce1e15906ca95ca5bc91b64a913))
- Update bottom sheet documentation
([`af1fa70`](https://togithub.com/material-components/material-components-android/commit/af1fa709792e1225df3fc582321c6a8287a221bf))
- Integrate tokens
([`86cd9d7`](https://togithub.com/material-components/material-components-android/commit/86cd9d70bf770fe45b5cf1e6755b0e12938430db))
- Add method to allow programmatically changing
shouldRemoveExpandedCorners behavior
([`c8a0d47`](https://togithub.com/material-components/material-components-android/commit/c8a0d478257069157d6c4c321735019f7daf4d25))
- Update expanded corner removal to check if sheet view is actually at
top of screen
([`1c01e82`](https://togithub.com/material-components/material-components-android/commit/1c01e8229700de423dcfbf63b0122cd96056bce7))
- Fix for detached from bottom sheet behavior.
([`9c4b73d`](https://togithub.com/material-components/material-components-android/commit/9c4b73da3a040003bae3167e9ae91f4d0cc0a9f7))
- Ignore ACTION_MOVE events in BottomSheetBehavior that weren't preceded
by an ACTION_DOWN event.
([`d8c01c1`](https://togithub.com/material-components/material-components-android/commit/d8c01c185994574dd67af4d78c1fd8fe425425ae))
- `Carousel`
- Add orientation helper to clean up CarouselLayoutManager orientation
differences
([`7822ef8`](https://togithub.com/material-components/material-components-android/commit/7822ef827b3d48c4f73a4bcdb35fb2b2a23b697d))
- Update docs to include hero variant
([`ec509cc`](https://togithub.com/material-components/material-components-android/commit/ec509cc7341c5d660642c0b8e00826678dc63c34))
- Add vertical scrolling capability
([`6b48d3b`](https://togithub.com/material-components/material-components-android/commit/6b48d3bb80576d649f7218e1bf29d0ecfa14d8f4))
- Deprecate set/get mask x percentages in Maskable as they are no longer
used anywhere, and is a misleading method due to these methods not
actually having any effect on the Carousel as CarouselLayoutManager
overrides the values.
([`29d8742`](https://togithub.com/material-components/material-components-android/commit/29d8742917ee7d8e977446665703859878eeff23))
- Ensure that masks are pushed out beyond the parent bounds if they are
*on* the parent bounds
([`9486de5`](https://togithub.com/material-components/material-components-android/commit/9486de5f2fba5c15cb85ac7ac27f30a724162f12))
- Carousel updates and fixes
([`16c1575`](https://togithub.com/material-components/material-components-android/commit/16c15757585eb6b7146d46d7603624a9546cc6a7))
- Fix contained mask logic to only update masks when it is still in
view, and remove restrictions on mask size with childWidth/2F. The only
restriction is that the right of the mask must be greater than the left
of the mask.
([`7d6a977`](https://togithub.com/material-components/material-components-android/commit/7d6a977d50b798e991d31d5223a4f3efcdfd6a24))
- Fixed multi browse strategy clipping extra small items before being
fully collapsed
([`85b6d50`](https://togithub.com/material-components/material-components-android/commit/85b6d5018d4aaab074490c6794b5a3a77eef072d))
- Add Carousel Hero strategy demo
([`b57dae5`](https://togithub.com/material-components/material-components-android/commit/b57dae57aa0ef31577cbd60bb08f030ae5b1618f))
- Add Hero carousel strategy
([`340cd44`](https://togithub.com/material-components/material-components-android/commit/340cd44b073bcf5b9f4d8e0f15754171549838a6))
- Add option for snapping with multi-browse carousel demo
([`26c3779`](https://togithub.com/material-components/material-components-android/commit/26c377962fde6221dff79e1f723f8541aa7c9661))
- Add CarouselSnapHelper
([`8938da8`](https://togithub.com/material-components/material-components-android/commit/8938da8c2828e36fe68b86d295b3f879e84a1d24))
- Refactor to reuse logic between different Carousel strategy classes
([`1c27404`](https://togithub.com/material-components/material-components-android/commit/1c27404fc5d562fed5dedf2d2165ec95b623120c))
- Fix item masking for API 21
([`7bc26e5`](https://togithub.com/material-components/material-components-android/commit/7bc26e5070b6cb90d8598cffe35f74b6f7c1ea06))
- Updated MultiBrowseCarouselStrategy to find best arrangments using a
cost function
([`0184b5b`](https://togithub.com/material-components/material-components-android/commit/0184b5baa959dd3fa31c75f0e81d60f3e92d69be))
- Fixed mutli-browse catalog demo crashing due to invalid position
slider values.
([`5bc7a50`](https://togithub.com/material-components/material-components-android/commit/5bc7a50b35f29e5d60b08a7fa4edd6987933901e))
- Add support for transitions by forcing canvas clipping when detaching
from the window.
([`93ceb7e`](https://togithub.com/material-components/material-components-android/commit/93ceb7edeecce7db4288b1e4b36b7ea98b20a3b0))
- Updated MaskableFrameLayout to use Outline path clipping on 33+ only.
([`43c5077`](https://togithub.com/material-components/material-components-android/commit/43c507775f9a536d4706c832fd15cbfea6d785c0))
- Updated setForceCompatClipping visibility for testing.
([`3856af1`](https://togithub.com/material-components/material-components-android/commit/3856af1b65e4e1a78493647627d47ce02efad621))
- Updated MaskableFrameLayout to clip more performantly.
([`733c9e0`](https://togithub.com/material-components/material-components-android/commit/733c9e08c28e8c68f8ad208a7be8ffaf784a9509))
- Changed Maskable.add/removeOnMaskChangedListener to
Maskable.setOnMaskChangedListener.
([`359580b`](https://togithub.com/material-components/material-components-android/commit/359580b6c1160301967ebdededb1011c1133b42c))
- Fixed child index bug causing items to be ordered incorrectly.
([`9d0732b`](https://togithub.com/material-components/material-components-android/commit/9d0732be9e16c328ac960f5a8d64417b4d6a1c68))
- `Catalog`
- Update side sheet state handling to be more accurate in demos
([`4442635`](https://togithub.com/material-components/material-components-android/commit/4442635aec49e9465a109e1d6ed669768828fc95))
- Update bottom sheet state handling to be more accurate in demos
([`386d47b`](https://togithub.com/material-components/material-components-android/commit/386d47b51b31d8068f1fc6617414ca1a92c3353b))
- Update to compileSdkVersion 34 and update catalog to use
androidx.activity:activity:1.8.0-alpha05
([`2336c23`](https://togithub.com/material-components/material-components-android/commit/2336c23fab664ce7dc94f97b23e7b38942d63b4a))
- Fixed catalog errors for some demos.
([`4c3e1d5`](https://togithub.com/material-components/material-components-android/commit/4c3e1d513be6cd8399515b2541eea74ac1c9a040))
- Fixes context menu are not themed on S
([`33e4f84`](https://togithub.com/material-components/material-components-android/commit/33e4f841b213fb306091971dd1d1025c8da897a7))
- `Checkbox`
- Fixed checkmark icon not updating color on error correctly in pre 21.
([`62aa802`](https://togithub.com/material-components/material-components-android/commit/62aa802f6c5f45ee357537079b07442dabc31236))
- `Chip`
- Fix hand pointer icon not showing up on whole Chip when using mouse
input
([`2702b1a`](https://togithub.com/material-components/material-components-android/commit/2702b1a8d5040f6ab4d69b66f38952c1f78a6225))
- Add theme overlays supported on API < 23
([`fd0c815`](https://togithub.com/material-components/material-components-android/commit/fd0c81531c74a48255f82350f6c1330521566e55))
- `Color`
- Temporarily remove v34 Android U color references which could be
causing resource NotFoundExceptions
([`2a1a67f`](https://togithub.com/material-components/material-components-android/commit/2a1a67f076c5dad0d45b9b65a65181dcea10cdf4))
- Fixed lint error.
([`824d75e`](https://togithub.com/material-components/material-components-android/commit/824d75e7731fba70b66a8833e0e3f69101787dd9))
- Integrate container color token
([`206928b`](https://togithub.com/material-components/material-components-android/commit/206928b8f91e802213ed82c2aa52211c008b60dc))
- Made SearchBar and SearchView's container colors configurable in XML
style.
([`cf006c5`](https://togithub.com/material-components/material-components-android/commit/cf006c5e10e8cfa0f33f8d4ffa654c5136d14bdc))
- Added U color resources for contrast mode support.
([`93f386c`](https://togithub.com/material-components/material-components-android/commit/93f386c9f61eec448ff6ddb5af3a22c06ffa30b1))
- `Dialog`
- Update DialogWhenLarge theme to have correct parent theme
([`dae89b7`](https://togithub.com/material-components/material-components-android/commit/dae89b7ce2ddf6e76a71ce0385071cc0645ccb0a))
- Made dialog background color configurable in XML styles.
([`77cdc1e`](https://togithub.com/material-components/material-components-android/commit/77cdc1e3ace0ddc22e8cb2b4cc40c176835f6149))
- Made dialog background color configurable in XML styles.
([`303fabd`](https://togithub.com/material-components/material-components-android/commit/303fabd331e014ba98676d3bd0c4a7d544decb99))
- `Documentation`
- Fix SideSheetDialog class definition and source links
([`e4d0fd3`](https://togithub.com/material-components/material-components-android/commit/e4d0fd3d6c4e65d56bd5699b3f9537a87d98a8cc))
- Revise version guidance for Search usage.
([`0bcb570`](https://togithub.com/material-components/material-components-android/commit/0bcb57074d00a20a2159d0ef5b209a7ca9a06fd5))
- Formatted tables in the eng doc.
([`ef57f69`](https://togithub.com/material-components/material-components-android/commit/ef57f699cb2fc509ef9b4762f901ec914834b165))
- Fix doc formatting for github
([`e75654d`](https://togithub.com/material-components/material-components-android/commit/e75654d4c205dc0a311be23725a71228e7ea4762))
- `ExposedDropdownMenu`
- Added attribute to set dropdown menu's container.
([`1562d0b`](https://togithub.com/material-components/material-components-android/commit/1562d0b64f7fe1b25390110eedc9650be2c626b8))
- `FloatingActionButton`
- Correctly handle min touch target size
([`d6f36e8`](https://togithub.com/material-components/material-components-android/commit/d6f36e89e2f815a4d72884618b62e946aaf7b6d9))
- `Material 3`
- Remove resources loader support for tonal surface update
([`dfd9bfb`](https://togithub.com/material-components/material-components-android/commit/dfd9bfb12f7c2e003c9bb9d2b4d7a8548ed5818e))
- Fix harmonization demo bug
([`836c51e`](https://togithub.com/material-components/material-components-android/commit/836c51e44a720a736aeb47a2b16a7094f7f0f712))
- Updated content-based dynamic colors
([`e9b485d`](https://togithub.com/material-components/material-components-android/commit/e9b485d6194a45cef54dfdbd2c3c3baf534e338b))
- Update Color doc
([`d7f9a06`](https://togithub.com/material-components/material-components-android/commit/d7f9a067e34967937bfab4ce7a9e004ff8fcf658))
- Updated content-based dynamic colors
([`a511501`](https://togithub.com/material-components/material-components-android/commit/a5115012868e87493da5c8eeb43d140179788a04))
- Adds Search class definition link to Search documentation.
([`e157608`](https://togithub.com/material-components/material-components-android/commit/e157608050c9c748d121801b1f7ce4a24c764a18))
- Added ColorContrast API
([`a6cf098`](https://togithub.com/material-components/material-components-android/commit/a6cf0985c4bd650d09f0eb84f85d22404b750722))
- Updated content-based dynamic with contrast levels
([`b335436`](https://togithub.com/material-components/material-components-android/commit/b335436cf2f70bf0f9222f1960ad0e442d46ebd7))
- Updated SearchDemoUtils to mark the class and methods as public so
that it can be resued.
([`3b43d41`](https://togithub.com/material-components/material-components-android/commit/3b43d41f16633016c5c581ded82a32cd89ed286e))
- Code style update
([`1fd695c`](https://togithub.com/material-components/material-components-android/commit/1fd695c72af14529e10b9baeb84699d03be3eb2d))
- Fix Search view prefix style.
([`e56e9b1`](https://togithub.com/material-components/material-components-android/commit/e56e9b1dde6b6cb8af7039033b1357b0947efb70))
- Updated search styles to set the default style attributes in the
related theme overlay.
([`9ffaa8d`](https://togithub.com/material-components/material-components-android/commit/9ffaa8d1bf45c1753d722e94c80e5573a3aac906))
- Improve performance by preventing item change notifications during
inflation.
([`203d5ec`](https://togithub.com/material-components/material-components-android/commit/203d5ec3a36f133163270271fd8f3f10de404f99))
- Fixed a crash in search components when view attributes inspection dev
setting is turned on.
([`1159923`](https://togithub.com/material-components/material-components-android/commit/11599231a9a2753ba4489518e3ccc443251eec52))
- Color Component demo update
([`2aa1cf3`](https://togithub.com/material-components/material-components-android/commit/2aa1cf31985405bc74a9a659c26900a709923c06))
- Color Component demo update
([`c786582`](https://togithub.com/material-components/material-components-android/commit/c786582d6a78e44090d6769cda657dee10c19765))
- `MaterialButton`
- Set up Android Studio resource inspection annotation and annotation
processor, and add [@​Attribute](https://togithub.com/Attribute)
annotation to MaterialButton#getIconPadding
([`2b5c75f`](https://togithub.com/material-components/material-components-android/commit/2b5c75f966a26d06b6d700bdda3880d021c5ffc7))
- `MaterialDatePicker`
- Allow client app to access user selected inputMode
([`4d80434`](https://togithub.com/material-components/material-components-android/commit/4d8043453e631c36b38ea19c3241b14b7f41b558))
- Fix crash when clicking OK/Cancel on text input mode due to hiding
keyboard
([`7ccf670`](https://togithub.com/material-components/material-components-android/commit/7ccf6708b0299317c3757c4d86a47827839c9ef7))
- Add getTextColor to DayViewDecorator
([`29b59c2`](https://togithub.com/material-components/material-components-android/commit/29b59c21f585d6cc96ad1b7e43ed7831995b6cc6))
- a11y/i18n alignment
([`f4d0f56`](https://togithub.com/material-components/material-components-android/commit/f4d0f5653a99cd723bd2b05ed05dfec816c8e1c3))
- ContentDescription for "DayName" is not properly getting read by
talkback for the German language
([`35bd1fc`](https://togithub.com/material-components/material-components-android/commit/35bd1fc98ffd449d11400ae040c3b43a24dea43b))
- Fix time zone when custom text input format is set
([`619d5a6`](https://togithub.com/material-components/material-components-android/commit/619d5a6cad0f3bd3f0a1a7d9a16013f9c3c19c97))
- Update screen width at which days size is 48dp in portrait mode.
([`ec511a5`](https://togithub.com/material-components/material-components-android/commit/ec511a54cf63eb1199f4c6927be9694c4c1ba304))
- Made dialog container color configurable in xml style.
([`7b2c19b`](https://togithub.com/material-components/material-components-android/commit/7b2c19b2731d5d264dfa91306f6236e46f4d4467))
- Fix hint for Korean
([`bcc97bf`](https://togithub.com/material-components/material-components-android/commit/bcc97bfaf54b53757c51af3f3d1e4a64d77183fd))
- Integrated tokens.
([`30ea33e`](https://togithub.com/material-components/material-components-android/commit/30ea33e948c14e9fa957763d79164ac4a1b3ad7f))
- Fix keyboard not showing at first in text input mode
([`4032a74`](https://togithub.com/material-components/material-components-android/commit/4032a741127b4715c3bbcd4cab08494b39ae5bdb))
- `NavigationRail`
- Added bigger padding in between items on the navigation rail when font
scale is large so there is more room for the badges when they are forced
inside the view bounds
([`8b016a0`](https://togithub.com/material-components/material-components-android/commit/8b016a0e8b8a885d4a3d1110f73b3deb8c6021a3))
- Integrate tokens and add shapeAppearance attribute
([`3b2b827`](https://togithub.com/material-components/material-components-android/commit/3b2b8275973113fd4be0ec336cdf64c147ef0ecd))
- Added attribute to control the application of start window inset
padding.
([`3f99392`](https://togithub.com/material-components/material-components-android/commit/3f993923b2520f1490381b375fe94758ce0e844a))
- Fixed active item focused state color not being visible.
([`1d2a59b`](https://togithub.com/material-components/material-components-android/commit/1d2a59ba37a9ed6e3abeac0500d6a480ccebb0ab))
- `NavigationView`
- Updated NavigationView to use ViewOutlineProvider to handle corner
clipping when possible and remove drawerLayoutCornerClippingEnabled
attribute.
([`c031144`](https://togithub.com/material-components/material-components-android/commit/c031144d2652f759c59d281e7a78beac2b42313b))
- Removed canvas clipping by default and added an option to
enabled/disable manually
([`e3b493f`](https://togithub.com/material-components/material-components-android/commit/e3b493f5eb77139624a43f573ae41988c911f92e))
- `Predictive Back`
- Fix issue where modal accessibility is not reset after collapsing
search view predictively, which caused the screen to appear frozen when
using TalkBack
([`e8af8f9`](https://togithub.com/material-components/material-components-android/commit/e8af8f94607daa58f8f3f61bf5ca8e99bed7bd07))
- Fixed IllegalStateException crashes caused by
MaterialBackAnimationHelper.
([`845007e`](https://togithub.com/material-components/material-components-android/commit/845007e5e976be67944f7a37a31f27840ef99725))
- Fixed `UnsupportedOperationException` `AnimatorSet` crash in
`SearchView`.
([`6720e24`](https://togithub.com/material-components/material-components-android/commit/6720e242b0f7c74c39468b4eb44826ade8c9ecb2))
- Fix custom predictive back implementations and update
androidx.activity dependency to 1.8.0-alpha06.
([`722b936`](https://togithub.com/material-components/material-components-android/commit/722b93682c7a3afeb4e2ced7341ff2cb6afd8f20))
- Fixed MaterialBackAnimationHelper.onCancelBackProgress being called
twice.
([`ad60bbf`](https://togithub.com/material-components/material-components-android/commit/ad60bbf5d932b6fcceccf9a0140917164d179d0c))
- Fixed possible NaN crashes in MaterialBottomContainerBackHelper,
MaterialMainContainerBackHelper and MaterialSideContainerBackHelper.
([`122c296`](https://togithub.com/material-components/material-components-android/commit/122c2966fd4abc867bc74270fcd1366bcdb239e7))
- Update components to use BackEventCompat
([`a67a885`](https://togithub.com/material-components/material-components-android/commit/a67a8856683542c6bf2e6f7cb4440ddae7fcd6e8))
- Make MaterialMainContainerBackHelper collapsedView optional
([`fb56ab4`](https://togithub.com/material-components/material-components-android/commit/fb56ab4130b74a1757ad587dd7c8373544118058))
- Fix issue on Android U where clicking SearchView back button causes
SearchBar to disappear and back arrow animation to not run
([`e69a324`](https://togithub.com/material-components/material-components-android/commit/e69a324a2fc1c7259d6a599d6d729ff0ea9e7395))
- Minor dev doc edits
([`82a91c8`](https://togithub.com/material-components/material-components-android/commit/82a91c8455bf1ccb8a1067e549e81a7acafd08da))
- Update dev docs
([`47c307d`](https://togithub.com/material-components/material-components-android/commit/47c307d889a89988b01ec573dd39ed74021c0143))
- Fix expand/collapse animation for non-predictive back cases where
rootView bounds are not equal to searchView bounds
([`577d23e`](https://togithub.com/material-components/material-components-android/commit/577d23ecebcd937d0c77df537863a21561bd3994))
- Added updateBackProgress() predictive back support for coplanar side
sheets.
([`5ba704a`](https://togithub.com/material-components/material-components-android/commit/5ba704a2732ee7a13b2f430257a45b1661fde6bd))
- Added handleBackInvoked() predictive back support for coplanar side
sheets.
([`b984e64`](https://togithub.com/material-components/material-components-android/commit/b984e64445fb21956a4affd189fe17f60d411fb2))
- Fix subtle detached side sheet glitch where after predictive back the
sheet does not fully slide off screen
([`52f1737`](https://togithub.com/material-components/material-components-android/commit/52f1737dd8f4fe3dad9e12512475c360002126d3))
- Fix custom nav drawer Catalog demo pre-T crash due to
OnBackAnimationCallback class not found
([`d8c5c2c`](https://togithub.com/material-components/material-components-android/commit/d8c5c2c87d4eef9b919542eb5f80aae5e3e97476))
- Added predictive back support for modal side sheets.
([`f335a50`](https://togithub.com/material-components/material-components-android/commit/f335a509077e954a9ed5206947b7649425f2f04a))
- Added predictive back support for standard side sheets.
([`562285e`](https://togithub.com/material-components/material-components-android/commit/562285e051771a8f32624f6efe67da3ed1b932cc))
- Update side container back helper to support containers with arbitrary
child views
([`9405121`](https://togithub.com/material-components/material-components-android/commit/9405121f62eee1cb6e188e161031c358b8d9d962))
- Only use device corner radius if SearchView reaches edge of screen
([`a93c91a`](https://togithub.com/material-components/material-components-android/commit/a93c91a2e23d52b761fdb0c495be6d0716c08354))
- Make back helpers support generified View type
([`69b5386`](https://togithub.com/material-components/material-components-android/commit/69b5386e4bb51f9e2cff0aca9f4484c8b3fda6c4))
- Add ability to opt-out of back handling
([`176ce5e`](https://togithub.com/material-components/material-components-android/commit/176ce5e5f0987f5dd385c467747155c5c3e6031c))
- Update SearchView to support predictive back when set up with
SearchBar
([`a4b6f46`](https://togithub.com/material-components/material-components-android/commit/a4b6f46f0cbeaf4b4eac421db492e8ba74f2f94a))
- Fix bug where standard hideable bottom sheets don't stay hidden after
predictive back
([`2c23d2a`](https://togithub.com/material-components/material-components-android/commit/2c23d2a158f3a2e5ce786bfd14b6d2a1ab10730b))
- Add top-level developer documentation
([`8105cb7`](https://togithub.com/material-components/material-components-android/commit/8105cb7ed659690c121077dac45d26017341a099))
- Update Bottom Sheet to support predictive back
([`d6fad95`](https://togithub.com/material-components/ma
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tuskyapp/Tusky).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-23 14:57:43 +01:00
|
|
|
material = "1.11.0"
|
2022-11-04 20:10:26 +01:00
|
|
|
material-drawer = "8.4.5"
|
|
|
|
material-typeface = "4.0.0.2-kotlin"
|
2023-03-13 10:20:08 +01:00
|
|
|
mockito-inline = "5.2.0"
|
2024-04-10 21:53:30 +02:00
|
|
|
mockito-kotlin = "5.3.1"
|
Replace Gson library with Moshi (#4309)
**! ! Warning**: Do not merge before testing every API call and database
read involving JSON !
**Gson** is obsolete and has been superseded by **Moshi**. But more
importantly, parsing Kotlin objects using Gson is _dangerous_ because
Gson uses Java serialization and is **not Kotlin-aware**. This has two
main consequences:
- Fields of non-null types may end up null at runtime. Parsing will
succeed, but the code may crash later with a `NullPointerException` when
trying to access a field member;
- Default values of constructor parameters are always ignored. When
absent, reference types will be null, booleans will be false and
integers will be zero.
On the other hand, Kotlin-aware parsers like **Moshi** or **Kotlin
Serialization** will validate at parsing time that all received fields
comply with the Kotlin contract and avoid errors at runtime, making apps
more stable and schema mismatches easier to detect (as long as logs are
accessible):
- Receiving a null value for a non-null type will generate a parsing
error;
- Optional types are declared explicitly by adding a default value. **A
missing value with no default value declaration will generate a parsing
error.**
Migrating the entity declarations from Gson to Moshi will make the code
more robust but is not an easy task because of the semantic differences.
With Gson, both nullable and optional fields are represented with a null
value. After converting to Moshi, some nullable entities can become
non-null with a default value (if they are optional and not nullable),
others can stay nullable with no default value (if they are mandatory
and nullable), and others can become **nullable with a default value of
null** (if they are optional _or_ nullable _or_ both). That third option
is the safest bet when it's not clear if a field is optional or not,
except for lists which can usually be declared as non-null with a
default value of an empty list (I have yet to see a nullable array type
in the Mastodon API).
Fields that are currently declared as non-null present another
challenge. In theory, they should remain as-is and everything will work
fine. In practice, **because Gson is not aware of nullable types at
all**, it's possible that some non-null fields currently hold a null
value in some cases but the app does not report any error because the
field is not accessed by Kotlin code in that scenario. After migrating
to Moshi however, parsing such a field will now fail early if a null
value or no value is received.
These fields will have to be identified by heavily testing the app and
looking for parsing errors (`JsonDataException`) and/or by going through
the Mastodon documentation. A default value needs to be added for
missing optional fields, and their type could optionally be changed to
nullable, depending on the case.
Gson is also currently used to serialize and deserialize objects to and
from the local database, which is also challenging because backwards
compatibility needs to be preserved. Fortunately, by default Gson omits
writing null fields, so a field of type `List<T>?` could be replaced
with a field of type `List<T>` with a default value of `emptyList()` and
reading back the old data should still work. However, nullable lists
that are written directly (not as a field of another object) will still
be serialized to JSON as `"null"` so the deserializing code must still
be handling null properly.
Finally, changing the database schema is out of scope for this pull
request, so database entities that also happen to be serialized with
Gson will keep their original types even if they could be made non-null
as an improvement.
In the end this is all for the best, because the app will be more
reliable and errors will be easier to detect by showing up earlier with
a clear error message. Not to mention the performance benefits of using
Moshi compared to Gson.
- Replace Gson reflection with Moshi Kotlin codegen to generate all
parsers at compile time.
- Replace custom `Rfc3339DateJsonAdapter` with the one provided by
moshi-adapters.
- Replace custom `JsonDeserializer` classes for Enum types with
`EnumJsonAdapter.create(T).withUnknownFallback()` from moshi-adapters to
support fallback values.
- Replace `GuardedBooleanAdapter` with the more generic `GuardedAdapter`
which works with any type. Any nullable field may now be annotated with
`@Guarded`.
- Remove Proguard rules related to Json entities. Each Json entity needs
to be annotated with `@JsonClass` with no exception, and adding this
annotation will ensure that R8/Proguard will handle the entities
properly.
- Replace some nullable Boolean fields with non-null Boolean fields with
a default value where possible.
- Replace some nullable list fields with non-null list fields with a
default value of `emptyList()` where possible.
- Update `TimelineDao` to perform all Json conversions internally using
`Converters` so no Gson or Moshi instance has to be passed to its
methods.
- ~~Create a custom `DraftAttachmentJsonAdapter` to serialize and
deserialize `DraftAttachment` which is a special entity that supports
more than one json name per field. A custom adapter is necessary because
there is not direct equivalent of `@SerializedName(alternate = [...])`
in Moshi.~~ Remove alternate names for some `DraftAttachment` fields
which were used as a workaround to deserialize local data in 2-years old
builds of Tusky.
- Update tests to make them work with Moshi.
- Simplify a few `equals()` implementations.
- Change a few functions to `val`s
- Turn `NetworkModule` into an `object` (since it contains no abstract
methods).
Please test the app thoroughly before merging. There may be some fields
currently declared as mandatory that are actually optional.
2024-04-02 21:01:04 +02:00
|
|
|
moshi = "1.15.1"
|
2024-02-25 20:40:17 +01:00
|
|
|
networkresult-calladapter = "1.1.0"
|
2024-02-23 20:02:17 +01:00
|
|
|
okhttp = "4.12.0"
|
2024-03-29 10:16:03 +01:00
|
|
|
retrofit = "2.11.0"
|
2024-04-03 21:08:19 +02:00
|
|
|
robolectric = "4.12.1"
|
2023-09-10 10:05:11 +02:00
|
|
|
sparkbutton = "4.2.0"
|
2024-02-23 10:29:37 +01:00
|
|
|
touchimageview = "3.6"
|
Update dependency com.google.truth:truth to v1.4.2 (#4298)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.truth:truth](https://togithub.com/google/truth) | `1.4.1`
-> `1.4.2` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.truth:truth/1.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.truth:truth/1.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.truth:truth/1.4.1/1.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.truth:truth/1.4.1/1.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
---
### Release Notes
<details>
<summary>google/truth (com.google.truth:truth)</summary>
### [`v1.4.2`](https://togithub.com/google/truth/releases/tag/v1.4.2):
1.4.2
This release is the final step of copying all our methods from `Truth8`
to `Truth`. If you have not already migrated your usages from `Truth8`
to `Truth`, you may see build errors:
OptionalSubjectTest.java:39: error: reference to assertThat is ambiguous
assertThat(Optional.of("foo")).isPresent();
^
both method
assertThat(@​org.checkerframework.checker.nullness.qual.Nullable
Optional<?>) in Truth8 and method
assertThat(@​org.checkerframework.checker.nullness.qual.Nullable
Optional<?>) in Truth match
In most cases, you can migrate your whole project mechanically: `git
grep -l Truth8 | xargs perl -pi -e 's/\bTruth8\b/Truth/g;'`. (You can
make that change before upgrading to Truth 1.4.2 or as part of the same
commit.)
If you instead need to migrate your project incrementally (for example,
because it is very large), you may want to upgrade your version of Truth
incrementally, too, following our instructions for
[1.3.0](https://togithub.com/google/truth/releases/tag/v1.3.0) and
[1.4.0](https://togithub.com/google/truth/releases/tag/v1.4.0).
#### For help
Please feel welcome to [open an
issue](https://togithub.com/google/truth/issues/new) to report problems
or request help.
#### Changelog
- Removed temporary type parameters from `Truth.assertThat(Stream)` and
`Truth.assertThat(Optional)`. This can create build errors, which you
can fix by replacing all your references to `Truth8` with references to
`Truth`.
([`45782bd`](https://togithub.com/google/truth/commit/45782bd0e))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tuskyapp/Tusky).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-01 08:07:49 +01:00
|
|
|
truth = "1.4.2"
|
2024-03-09 13:32:30 +01:00
|
|
|
turbine = "1.1.0"
|
2024-02-23 10:53:31 +01:00
|
|
|
unified-push = "2.4.0"
|
2023-03-10 20:30:55 +01:00
|
|
|
xmlwriter = "1.0.4"
|
2022-11-04 20:10:26 +01:00
|
|
|
|
2023-02-04 19:58:53 +01:00
|
|
|
[plugins]
|
|
|
|
android-application = { id = "com.android.application", version.ref = "agp" }
|
2024-04-05 12:01:38 +02:00
|
|
|
google-ksp = "com.google.devtools.ksp:1.9.23-1.0.20"
|
2023-02-04 19:58:53 +01:00
|
|
|
kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
|
2024-02-10 10:42:31 +01:00
|
|
|
kotlin-kapt = { id = "org.jetbrains.kotlin.kapt", version.ref = "kotlin" }
|
2023-02-04 19:58:53 +01:00
|
|
|
kotlin-parcelize = { id = "org.jetbrains.kotlin.plugin.parcelize", version.ref = "kotlin" }
|
2024-02-23 20:02:27 +01:00
|
|
|
ktlint = "org.jlleitschuh.gradle.ktlint:12.1.0"
|
2023-02-04 19:58:53 +01:00
|
|
|
|
2022-11-04 20:10:26 +01:00
|
|
|
[libraries]
|
|
|
|
android-material = { module = "com.google.android.material:material", version.ref = "material" }
|
|
|
|
androidx-activity = { module = "androidx.activity:activity-ktx", version.ref = "androidx-activity" }
|
|
|
|
androidx-appcompat = { module = "androidx.appcompat:appcompat", version.ref = "androidx-appcompat" }
|
|
|
|
androidx-browser = { module = "androidx.browser:browser", version.ref = "androidx-browser" }
|
|
|
|
androidx-cardview = { module = "androidx.cardview:cardview", version.ref = "androidx-cardview" }
|
|
|
|
androidx-constraintlayout = { module = "androidx.constraintlayout:constraintlayout", version.ref = "androidx-constraintlayout" }
|
|
|
|
androidx-core-ktx = { module = "androidx.core:core-ktx", version.ref = "androidx-core" }
|
|
|
|
androidx-core-splashscreen = { module = "androidx.core:core-splashscreen", version.ref = "androidx-splashscreen" }
|
|
|
|
androidx-core-testing = { module = "androidx.arch.core:core-testing", version.ref = "androidx-testing" }
|
|
|
|
androidx-emoji2-core = { module = "androidx.emoji2:emoji2", version.ref = "emoji2" }
|
|
|
|
androidx-emoji2-views-core = { module = "androidx.emoji2:emoji2-views", version.ref = "emoji2" }
|
|
|
|
androidx-emoji2-view-helper = { module = "androidx.emoji2:emoji2-views-helper", version.ref = "emoji2" }
|
|
|
|
androidx-exifinterface = { module = "androidx.exifinterface:exifinterface", version.ref = "androidx-exifinterface" }
|
|
|
|
androidx-fragment-ktx = { module = "androidx.fragment:fragment-ktx", version.ref = "androidx-fragment" }
|
2023-03-13 13:16:49 +01:00
|
|
|
androidx-lifecycle-viewmodel-ktx = { module = "androidx.lifecycle:lifecycle-viewmodel-ktx", version.ref = "androidx-lifecycle" }
|
2023-08-10 19:31:55 +02:00
|
|
|
androidx-media3-exoplayer = { module = "androidx.media3:media3-exoplayer", version.ref = "androidx-media3" }
|
|
|
|
androidx-media3-datasource-okhttp = { module = "androidx.media3:media3-datasource-okhttp", version.ref = "androidx-media3" }
|
|
|
|
androidx-media3-ui = { module = "androidx.media3:media3-ui", version.ref = "androidx-media3" }
|
2022-11-04 20:10:26 +01:00
|
|
|
androidx-paging-runtime-ktx = { module = "androidx.paging:paging-runtime-ktx", version.ref = "androidx-paging" }
|
|
|
|
androidx-preference-ktx = { module = "androidx.preference:preference-ktx", version.ref = "androidx-preference" }
|
2023-02-04 20:22:29 +01:00
|
|
|
androidx-room-compiler = { module = "androidx.room:room-compiler", version.ref = "androidx-room" }
|
|
|
|
androidx-room-paging = { module = "androidx.room:room-paging", version.ref = "androidx-room" }
|
|
|
|
androidx-room-ktx = { module = "androidx.room:room-ktx", version.ref = "androidx-room" }
|
|
|
|
androidx-room-testing = { module = "androidx.room:room-testing", version.ref = "androidx-room" }
|
2022-11-04 20:10:26 +01:00
|
|
|
androidx-recyclerview = { module = "androidx.recyclerview:recyclerview", version.ref = "androidx-recyclerview" }
|
|
|
|
androidx-sharetarget = { module = "androidx.sharetarget:sharetarget", version.ref = "androidx-sharetarget" }
|
|
|
|
androidx-swiperefreshlayout = { module = "androidx.swiperefreshlayout:swiperefreshlayout", version.ref = "androidx-swiperefresh-layout" }
|
|
|
|
androidx-test-junit = { module = "androidx.test.ext:junit", version.ref = "androidx-junit" }
|
|
|
|
androidx-viewpager2 = { module = "androidx.viewpager2:viewpager2", version.ref = "androidx-viewpager2" }
|
2023-06-11 13:17:30 +02:00
|
|
|
androidx-work-runtime-ktx = { module = "androidx.work:work-runtime-ktx", version.ref = "androidx-work" }
|
2022-11-07 20:04:07 +01:00
|
|
|
androidx-work-testing = { module = "androidx.work:work-testing", version.ref = "androidx-work" }
|
2022-11-04 20:10:26 +01:00
|
|
|
bouncycastle = { module = "org.bouncycastle:bcprov-jdk15on", version.ref = "bouncycastle" }
|
|
|
|
conscrypt-android = { module = "org.conscrypt:conscrypt-android", version.ref = "conscrypt" }
|
|
|
|
dagger-android-core = { module = "com.google.dagger:dagger-android", version.ref = "dagger" }
|
|
|
|
dagger-android-processor = { module = "com.google.dagger:dagger-android-processor", version.ref = "dagger" }
|
|
|
|
dagger-android-support = { module = "com.google.dagger:dagger-android-support", version.ref = "dagger" }
|
|
|
|
dagger-compiler = { module = "com.google.dagger:dagger-compiler", version.ref = "dagger" }
|
|
|
|
dagger-core = { module = "com.google.dagger:dagger", version.ref = "dagger" }
|
2023-03-10 20:30:55 +01:00
|
|
|
diffx = { module = "org.pageseeder.diffx:pso-diffx", version.ref = "diffx" }
|
2022-11-04 20:10:26 +01:00
|
|
|
espresso-core = { module = "androidx.test.espresso:espresso-core", version.ref = "espresso" }
|
|
|
|
filemojicompat-core = { module = "de.c1710:filemojicompat", version.ref = "filemoji-compat" }
|
|
|
|
filemojicompat-defaults = { module = "de.c1710:filemojicompat-defaults", version.ref = "filemoji-compat" }
|
|
|
|
filemojicompat-ui = { module = "de.c1710:filemojicompat-ui", version.ref = "filemoji-compat" }
|
|
|
|
glide-animation-plugin = { module = "com.github.penfeizhou.android.animation:glide-plugin", version.ref = "glide-animation-plugin" }
|
2023-07-11 15:34:14 +02:00
|
|
|
glide-compiler = { module = "com.github.bumptech.glide:ksp", version.ref = "glide" }
|
2022-11-04 20:10:26 +01:00
|
|
|
glide-core = { module = "com.github.bumptech.glide:glide", version.ref = "glide" }
|
|
|
|
glide-okhttp3-integration = { module = "com.github.bumptech.glide:okhttp3-integration", version.ref = "glide" }
|
|
|
|
kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version.ref = "coroutines" }
|
|
|
|
kotlinx-coroutines-test = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "coroutines" }
|
|
|
|
image-cropper = { module = "com.github.CanHub:Android-Image-Cropper", version.ref = "image-cropper" }
|
|
|
|
material-drawer-core = { module = "com.mikepenz:materialdrawer", version.ref = "material-drawer" }
|
|
|
|
material-drawer-iconics = { module = "com.mikepenz:materialdrawer-iconics", version.ref = "material-drawer" }
|
|
|
|
material-typeface = { module = "com.mikepenz:google-material-typeface", version.ref = "material-typeface" }
|
|
|
|
mockito-kotlin = { module = "org.mockito.kotlin:mockito-kotlin", version.ref = "mockito-kotlin" }
|
|
|
|
mockito-inline = { module = "org.mockito:mockito-inline", version.ref = "mockito-inline" }
|
|
|
|
mockwebserver = { module = "com.squareup.okhttp3:mockwebserver", version.ref = "okhttp" }
|
Replace Gson library with Moshi (#4309)
**! ! Warning**: Do not merge before testing every API call and database
read involving JSON !
**Gson** is obsolete and has been superseded by **Moshi**. But more
importantly, parsing Kotlin objects using Gson is _dangerous_ because
Gson uses Java serialization and is **not Kotlin-aware**. This has two
main consequences:
- Fields of non-null types may end up null at runtime. Parsing will
succeed, but the code may crash later with a `NullPointerException` when
trying to access a field member;
- Default values of constructor parameters are always ignored. When
absent, reference types will be null, booleans will be false and
integers will be zero.
On the other hand, Kotlin-aware parsers like **Moshi** or **Kotlin
Serialization** will validate at parsing time that all received fields
comply with the Kotlin contract and avoid errors at runtime, making apps
more stable and schema mismatches easier to detect (as long as logs are
accessible):
- Receiving a null value for a non-null type will generate a parsing
error;
- Optional types are declared explicitly by adding a default value. **A
missing value with no default value declaration will generate a parsing
error.**
Migrating the entity declarations from Gson to Moshi will make the code
more robust but is not an easy task because of the semantic differences.
With Gson, both nullable and optional fields are represented with a null
value. After converting to Moshi, some nullable entities can become
non-null with a default value (if they are optional and not nullable),
others can stay nullable with no default value (if they are mandatory
and nullable), and others can become **nullable with a default value of
null** (if they are optional _or_ nullable _or_ both). That third option
is the safest bet when it's not clear if a field is optional or not,
except for lists which can usually be declared as non-null with a
default value of an empty list (I have yet to see a nullable array type
in the Mastodon API).
Fields that are currently declared as non-null present another
challenge. In theory, they should remain as-is and everything will work
fine. In practice, **because Gson is not aware of nullable types at
all**, it's possible that some non-null fields currently hold a null
value in some cases but the app does not report any error because the
field is not accessed by Kotlin code in that scenario. After migrating
to Moshi however, parsing such a field will now fail early if a null
value or no value is received.
These fields will have to be identified by heavily testing the app and
looking for parsing errors (`JsonDataException`) and/or by going through
the Mastodon documentation. A default value needs to be added for
missing optional fields, and their type could optionally be changed to
nullable, depending on the case.
Gson is also currently used to serialize and deserialize objects to and
from the local database, which is also challenging because backwards
compatibility needs to be preserved. Fortunately, by default Gson omits
writing null fields, so a field of type `List<T>?` could be replaced
with a field of type `List<T>` with a default value of `emptyList()` and
reading back the old data should still work. However, nullable lists
that are written directly (not as a field of another object) will still
be serialized to JSON as `"null"` so the deserializing code must still
be handling null properly.
Finally, changing the database schema is out of scope for this pull
request, so database entities that also happen to be serialized with
Gson will keep their original types even if they could be made non-null
as an improvement.
In the end this is all for the best, because the app will be more
reliable and errors will be easier to detect by showing up earlier with
a clear error message. Not to mention the performance benefits of using
Moshi compared to Gson.
- Replace Gson reflection with Moshi Kotlin codegen to generate all
parsers at compile time.
- Replace custom `Rfc3339DateJsonAdapter` with the one provided by
moshi-adapters.
- Replace custom `JsonDeserializer` classes for Enum types with
`EnumJsonAdapter.create(T).withUnknownFallback()` from moshi-adapters to
support fallback values.
- Replace `GuardedBooleanAdapter` with the more generic `GuardedAdapter`
which works with any type. Any nullable field may now be annotated with
`@Guarded`.
- Remove Proguard rules related to Json entities. Each Json entity needs
to be annotated with `@JsonClass` with no exception, and adding this
annotation will ensure that R8/Proguard will handle the entities
properly.
- Replace some nullable Boolean fields with non-null Boolean fields with
a default value where possible.
- Replace some nullable list fields with non-null list fields with a
default value of `emptyList()` where possible.
- Update `TimelineDao` to perform all Json conversions internally using
`Converters` so no Gson or Moshi instance has to be passed to its
methods.
- ~~Create a custom `DraftAttachmentJsonAdapter` to serialize and
deserialize `DraftAttachment` which is a special entity that supports
more than one json name per field. A custom adapter is necessary because
there is not direct equivalent of `@SerializedName(alternate = [...])`
in Moshi.~~ Remove alternate names for some `DraftAttachment` fields
which were used as a workaround to deserialize local data in 2-years old
builds of Tusky.
- Update tests to make them work with Moshi.
- Simplify a few `equals()` implementations.
- Change a few functions to `val`s
- Turn `NetworkModule` into an `object` (since it contains no abstract
methods).
Please test the app thoroughly before merging. There may be some fields
currently declared as mandatory that are actually optional.
2024-04-02 21:01:04 +02:00
|
|
|
moshi-core = { module = "com.squareup.moshi:moshi", version.ref = "moshi" }
|
|
|
|
moshi-adapters = { module = "com.squareup.moshi:moshi-adapters", version.ref = "moshi" }
|
|
|
|
moshi-kotlin-codegen = { module = "com.squareup.moshi:moshi-kotlin-codegen", version.ref = "moshi" }
|
2022-11-04 20:10:26 +01:00
|
|
|
networkresult-calladapter = { module = "at.connyduck:networkresult-calladapter", version.ref = "networkresult-calladapter" }
|
|
|
|
okhttp-core = { module = "com.squareup.okhttp3:okhttp", version.ref = "okhttp" }
|
|
|
|
okhttp-logging-interceptor = { module = "com.squareup.okhttp3:logging-interceptor", version.ref = "okhttp" }
|
Replace Gson library with Moshi (#4309)
**! ! Warning**: Do not merge before testing every API call and database
read involving JSON !
**Gson** is obsolete and has been superseded by **Moshi**. But more
importantly, parsing Kotlin objects using Gson is _dangerous_ because
Gson uses Java serialization and is **not Kotlin-aware**. This has two
main consequences:
- Fields of non-null types may end up null at runtime. Parsing will
succeed, but the code may crash later with a `NullPointerException` when
trying to access a field member;
- Default values of constructor parameters are always ignored. When
absent, reference types will be null, booleans will be false and
integers will be zero.
On the other hand, Kotlin-aware parsers like **Moshi** or **Kotlin
Serialization** will validate at parsing time that all received fields
comply with the Kotlin contract and avoid errors at runtime, making apps
more stable and schema mismatches easier to detect (as long as logs are
accessible):
- Receiving a null value for a non-null type will generate a parsing
error;
- Optional types are declared explicitly by adding a default value. **A
missing value with no default value declaration will generate a parsing
error.**
Migrating the entity declarations from Gson to Moshi will make the code
more robust but is not an easy task because of the semantic differences.
With Gson, both nullable and optional fields are represented with a null
value. After converting to Moshi, some nullable entities can become
non-null with a default value (if they are optional and not nullable),
others can stay nullable with no default value (if they are mandatory
and nullable), and others can become **nullable with a default value of
null** (if they are optional _or_ nullable _or_ both). That third option
is the safest bet when it's not clear if a field is optional or not,
except for lists which can usually be declared as non-null with a
default value of an empty list (I have yet to see a nullable array type
in the Mastodon API).
Fields that are currently declared as non-null present another
challenge. In theory, they should remain as-is and everything will work
fine. In practice, **because Gson is not aware of nullable types at
all**, it's possible that some non-null fields currently hold a null
value in some cases but the app does not report any error because the
field is not accessed by Kotlin code in that scenario. After migrating
to Moshi however, parsing such a field will now fail early if a null
value or no value is received.
These fields will have to be identified by heavily testing the app and
looking for parsing errors (`JsonDataException`) and/or by going through
the Mastodon documentation. A default value needs to be added for
missing optional fields, and their type could optionally be changed to
nullable, depending on the case.
Gson is also currently used to serialize and deserialize objects to and
from the local database, which is also challenging because backwards
compatibility needs to be preserved. Fortunately, by default Gson omits
writing null fields, so a field of type `List<T>?` could be replaced
with a field of type `List<T>` with a default value of `emptyList()` and
reading back the old data should still work. However, nullable lists
that are written directly (not as a field of another object) will still
be serialized to JSON as `"null"` so the deserializing code must still
be handling null properly.
Finally, changing the database schema is out of scope for this pull
request, so database entities that also happen to be serialized with
Gson will keep their original types even if they could be made non-null
as an improvement.
In the end this is all for the best, because the app will be more
reliable and errors will be easier to detect by showing up earlier with
a clear error message. Not to mention the performance benefits of using
Moshi compared to Gson.
- Replace Gson reflection with Moshi Kotlin codegen to generate all
parsers at compile time.
- Replace custom `Rfc3339DateJsonAdapter` with the one provided by
moshi-adapters.
- Replace custom `JsonDeserializer` classes for Enum types with
`EnumJsonAdapter.create(T).withUnknownFallback()` from moshi-adapters to
support fallback values.
- Replace `GuardedBooleanAdapter` with the more generic `GuardedAdapter`
which works with any type. Any nullable field may now be annotated with
`@Guarded`.
- Remove Proguard rules related to Json entities. Each Json entity needs
to be annotated with `@JsonClass` with no exception, and adding this
annotation will ensure that R8/Proguard will handle the entities
properly.
- Replace some nullable Boolean fields with non-null Boolean fields with
a default value where possible.
- Replace some nullable list fields with non-null list fields with a
default value of `emptyList()` where possible.
- Update `TimelineDao` to perform all Json conversions internally using
`Converters` so no Gson or Moshi instance has to be passed to its
methods.
- ~~Create a custom `DraftAttachmentJsonAdapter` to serialize and
deserialize `DraftAttachment` which is a special entity that supports
more than one json name per field. A custom adapter is necessary because
there is not direct equivalent of `@SerializedName(alternate = [...])`
in Moshi.~~ Remove alternate names for some `DraftAttachment` fields
which were used as a workaround to deserialize local data in 2-years old
builds of Tusky.
- Update tests to make them work with Moshi.
- Simplify a few `equals()` implementations.
- Change a few functions to `val`s
- Turn `NetworkModule` into an `object` (since it contains no abstract
methods).
Please test the app thoroughly before merging. There may be some fields
currently declared as mandatory that are actually optional.
2024-04-02 21:01:04 +02:00
|
|
|
retrofit-converter-moshi = { module = "com.squareup.retrofit2:converter-moshi", version.ref = "retrofit" }
|
2022-11-04 20:10:26 +01:00
|
|
|
retrofit-core = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" }
|
|
|
|
robolectric = { module = "org.robolectric:robolectric", version.ref = "robolectric" }
|
2023-09-10 10:05:11 +02:00
|
|
|
sparkbutton = { module = "at.connyduck.sparkbutton:sparkbutton", version.ref = "sparkbutton" }
|
Fix image zoom / pan / scroll / swipe (#3894)
Migrate to touchimageview from photoview, and adjust the touch logic to correctly handle single finger drag, two finger pinch/stretch, flings, taps, and swipes.
As before, the features are:
- Single tap, show/hide controls and media description
- Double tap, zoom in/out
- Single finger drag up/down, scale/translate image, dismiss if scrolled too far
- Single finger drag left/right
- When not zoomed, swipe to next image if multiple images present
- When zoomed, scroll to edge of image, then to next image if multiple images present
- Two finger pinch/zoom, zoom in/out on the image
Behaviour differences to previous code
1. Bug fix: The image can't get "stuck" when zoomed, and impossible to scroll
2. Bug fix: Pinching is not mis-interpreted as a fling, closing the image
3. Bug fix: The zoom state of images is not lost or misinterpreted when the user swipes through multiple images
4. Bug fix: Double-tap zooms all the way, instead of stopping
5. Tapping outside the image does not dismiss it, controls and description show/hide
Fixes https://github.com/tuskyapp/Tusky/issues/3562, https://github.com/tuskyapp/Tusky/issues/2297
2023-07-31 12:44:01 +02:00
|
|
|
touchimageview = { module = "com.github.MikeOrtiz:TouchImageView", version.ref = "touchimageview" }
|
Convert NotificationsFragment and related code to Kotlin, use the Paging library (#3159)
* Unmodified output from "Convert Java to Kotlin" on NotificationsFragment.java
* Bare minimum changes to get this to compile and run
- Use `lateinit` for `eventhub`, `adapter`, `preferences`, and `scrolllistener`
- Removed override for accountManager, it can be used from the superclass
- Add `?.` where non-nullity could not (yet) be guaranteed
- Remove `?` from type lists where non-nullity is guaranteed
- Explicitly convert lists to mutable where necessary
- Delete unused function `findReplyPosition`
* Remove all unnecessary non-null (!!) assertions
The previous change meant some values are no longer nullable. Remove the
non-null assertions.
* Lint ListStatusAccessibilityDelegate call
- Remove redundant constructor
- Move block outside of `()`
* Use `let` when handling compose button visibility on scroll
* Replace a `requireNonNull` with `!!`
* Remove redundant return values
* Remove or rename unused lambda parameters
* Remove unnecessary type parameters
* Remove unnecessary null checks
* Replace cascading-if statement with `when`
* Simplify calculation of `topId`
* Use more appropriate list properties and methods
- Access the last value with `.last()`
- Access the last index with `.lastIndex`
- Replace logical-chain with `asRightOrNull` and `?.`
- `.isNotEmpty()`, not `!...isEmpty()`
* Inline unnecessary variable
* Use PrefKeys constants instead of bare strings
* Use `requireContext()` instead of `context!!`
* Replace deprecated `onActivityCreated()` with `onViewCreated()`
* Remove unnecessary variable setting
* Replace `size == 0` check with `isEmpty()`
* Format with ktlint, no functionality changes
* Convert NotifcationsAdapter to Kotlin
Does not compile, this is the unchanged output of the "Convert to Kotlin"
function
* Minimum changes to get NotificationsAdapter to compile
* Remove unnecessary visibility modifiers
* Use `isNotEmpty()`
* Remove unused lambda parameters
* Convert cascading-if to `when`
* Simplifiy assignment op
* Use explicit argument names with `copy()`
* Use `.firstOrNull()` instead of `if`
* Mark as lateinit to avoid unnecessary null checks
* Format with ktlint, whitespace changes only
* Bare minimum necessary to demonstrate paging in notifications
Create `NotificationsPagingSource`. This uses a new `notifications2()` API
call, which will exist until all the code has been adapted. Instead of
using placeholders,
Create `NotificationsPagingAdapter` (will replace `NotificationsAdapater`)
to consume this data.
Expose the paging source view a new `NotificationsViewModel` `flow`, and
submit new pages to the adapter as they are available in
`NotificationsFragment`.
Comment out any other code in `NotificationsFragment` that deals with
loading data from the network. This will be updated as necessary, either
here, or in the view model.
Lots of functionality is missing, including:
- Different views for different notification types
- Starting at the remembered notification position
- Interacting with notifications
- Adjusting the UI state to match the loading state
These will be added incrementally.
* Migrate StatusNotificationViewHolder impl. to NotificationsPagingAdapter
With this change `NotificationsPagingAdapter` shows notifications about a
status correctly.
- Introduce a `ViewHolder` abstract class that all Notification view holders
derive from. Modify the fallback view holder to use this.
- Implement `StatusNotificationViewHolder`. Much of the code is from the
existing implementation in the `NotificationAdapater`.
- The original code split the code that binds values to views between the
adapter's `bindViewHolder` method and the view holder's methods.
In this code, all of the binding code is in the view holder, in a `bind`
method. This is called by the adapter's `bindViewHolder` method. This keeps
all the binding logic in the view holder, where it belongs.
- The new `StatusNotificationViewHolder` uses view binding to access its views
instead of `findViewById`.
- Logically, information about whether to show sensitive media, or open
content warnings should be part of the `StatusDisplayOptions`. So add those
as fields, and populate them appropriately.
This affects code outside notification handling, which will be adjusted
later.
* Note some TODOs to complete before the PR is finished
* Extract StatusNotificationViewHolder to a new file
* Add TODO for NotificationViewData.Concrete
* Convert the adapter to take NotificationViewData.Concrete
* Add a view holder for regular status notifications
* Migrate Follow and FollowRequest notifications
* Migrate report notifications
* Convert onViewThread to use the adapter data
* Convert onViewMedia to use the adapter data
* Convert onMore to use the adapter data
* Convert onReply to use the adapter data
* Convert NotificationViewData to Kotlin
* Re-implement the reblog functionality
- Move reblogging in to the view model
- Update the UI via the adapter's `snapshot()` and `notifyItemChanged()`
methods
* Re-implement the favourite functionality
Same approach as reblog
* Re-implement the bookmark functionality
Same approach as reblog
* Add TODO re StatusActionListener interface
* Add TODO re event handling
* Re-implementing the voting functionality
* Re-implement viewing hidden content
- Hidden media
- Content behind a content warning
* Add a TODO re pinning
* Re-implement "Show more" / "Show less"
* Delete unused updateStatus() function
* Comment out the scroll listener for the moment
* Re-implement applying filters to notifications
Introduce `NotificationsRepository`, to provide access to the notifications
stream.
When changing the filters the flow is as follows:
- User clicks "Apply" in the fragment.
- Fragment calls `viewModel.accept()` with a `UiAction.ApplyFilter` (new
class).
- View model maintains a private flow of incoming UI actions. The new action
is emitted to that flow.
- In view model, `notificationFilter` waits for `.ApplyFilter` actions, and
ensures the filter is saved, then emits it.
- In view model, `pagingDataFlow` waits for new items from
`notificationsFilter` and fetches the notifications from the repository in
response. The repository provides `Notification`, so the model maps them to
`NotificationViewData.Concrete` for display by the adapter.
- In view model the UI state also waits for new items from
`notificationsFilter` and emits a new `UiState` every time the filter is
changed.
When opening the fragment for the first time:
- All of the above machinery, but `notificationFilter` also fetches the filter
from the active account and emits that first. This triggers the first fetch
and the first update of `uiState`.
Also:
- Add TODOs for functionality that is not implemented yet
- Delete a lot of dead code from NotificationsFragment
* Include important preference values in `uiState`
Listen to the flow of eventHub events, filtered to preference changes that
are relevant to the notification view.
When preferences change (or when the view model starts), fetch the current
values, and include them in `uiState`.
Remove preference handling from `NotificationsFragment`, and just use
the values from `uiState`.
Adjust how the `useAbsoluteTime` preference is handled. The previous code
loaded new content (via a diffutil) in to the adapter, which would trigger
a re-binding of the timestamp.
As the adapter content is immutable, the new code simply triggers a
re-binding of the views that are currently visible on screen.
* Update UI in response to different load states
Notifications can be loaded at the top and bottom of the timeline. Add a
new layout to show the progress of these loads, and any errors that can
occur.
Catch network errors in `NotificationsPagingSource` and convert to
`LoadState.Error`.
Add a header/footer to the notifications list to show the load state.
Collect the load state from the adapter, use this to drive the visibility
of different views.
* Save and restore the last read notification ID
Use this when fetching notifications, to centre the list around the
notification that was last read.
* Call notifyItemRangeChanged with the correct parameters
* Don't try and save list position if there are no items in the list
* Show/hide the "Nothing to see" view appropriately
* Update comments
* Handle the case where the notification key no longer exists
* Re-implement support for showMediaPreview and other settings
* Re-implement "hide FAB when scrolling" preference
* Delete dead code
* Delete Notifications Adapater and Placeholder types
* Remove NotificationViewData.Concrete subclass
Now there's no Placeholder, everything is a NotificationViewData.
* Improve how notification pages are loaded if the first notification is missing or filtered
* Re-implement clear notifications, show errors
* s/default/from/
* Add missing headers
* Don't process bookmarking via EventHub
- Initiating a bookmark is triggered by the fragment sending a
StatusUiAction.Bookmark
- View model receives this, makes API call, waits for response, emits either
a success or failure state
- Fragment collects success/failure states, updates the UI accordingly
* Don't process favourites via EventHub
* Don't process reblog via EventHub
* Don't process poll votes with EventHub
This removes EventHub from the fragment
* Respond to follow requests via the view model
* Docs and cleanup
* Typo and editing pass
* Minor edits for clarity
* Remove newline in diagram
* Reorder sequence diagram
* s/authorize/accept/
* s/pagingDataFlow/pagingData/
* Add brief KDoc
* Try and fetch a full first page of notifications
* Call the API method `notifications` again
* Log UI errors at the point of handling
* Remove unused variable
* Replace String.format() with interpolation
* Convert NotificationViewData to data class
* Rename copy() to make(), to avoid confusion with default copy() method
* Lint
* Update app/src/main/res/layout/simple_list_item_1.xml
* Update app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsPagingAdapter.kt
* Update app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsViewModel.kt
* Update app/src/main/java/com/keylesspalace/tusky/fragment/NotificationsFragment.kt
* Update app/src/main/java/com/keylesspalace/tusky/viewdata/NotificationViewData.kt
* Initial NotificationsViewModel tests
* Add missing import
* More tests, some cleanup
* Comments, re-order some code
* Set StateRestorationPolicy.PREVENT_WHEN_EMPTY
* Mark clearNotifications() as "suspend"
* Catch exceptions from clearNotifications and emit
* Update TODOs with explanations
* Ensure initial fetch uses a null ID
* Stop/start collecting pagingData based on the lifecycle
* Don't hide the list while refreshing
* Refresh notifications on mutes and blocks
* Update tests now clearNotifications is a suspend fun
* Add "Refresh" menu to NotificationsFragment
* Use account.name over account.displayName
* Update app/src/main/java/com/keylesspalace/tusky/fragment/NotificationsFragment.kt
Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
* Mark layoutmanager as lateinit
* Mark layoutmanager as lateinit
* Refactor generating UI text
* Add Copyright header
* Correctly apply notification filters
* Show follow request header in notifications
* Wait for follow request actions to complete, so the reqeuest is sent
* Remove duplicate copyright header
* Revert copyright change in unmodified file
* Null check response body
* Move NotificationsFragment to component.notifications
* Use viewlifecycleowner.lifecyclescope
* Show notification filter as a dialog rather than a popup window
The popup window:
- Is inconsistent UI
- Requires a custom layout
- Didn't play nicely with viewbinding
* Refresh adapter on block/mute
* Scroll up slightly when new content is loaded
* Restore progressbar
* Lint
* Update app/src/main/res/layout/simple_list_item_1.xml
---------
Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
2023-03-10 20:12:33 +01:00
|
|
|
truth = { module = "com.google.truth:truth", version.ref = "truth" }
|
|
|
|
turbine = { module = "app.cash.turbine:turbine", version.ref = "turbine" }
|
2022-11-04 20:10:26 +01:00
|
|
|
unified-push = { module = "com.github.UnifiedPush:android-connector", version.ref = "unified-push" }
|
2023-03-10 20:30:55 +01:00
|
|
|
xmlwriter = { module = "org.pageseeder.xmlwriter:pso-xmlwriter", version.ref = "xmlwriter" }
|
2022-11-04 20:10:26 +01:00
|
|
|
|
|
|
|
[bundles]
|
|
|
|
androidx = ["androidx-core-ktx", "androidx-appcompat", "androidx-fragment-ktx", "androidx-browser", "androidx-swiperefreshlayout",
|
|
|
|
"androidx-recyclerview", "androidx-exifinterface", "androidx-cardview", "androidx-preference-ktx", "androidx-sharetarget",
|
|
|
|
"androidx-emoji2-core", "androidx-emoji2-views-core", "androidx-emoji2-view-helper", "androidx-lifecycle-viewmodel-ktx",
|
2023-06-11 13:17:30 +02:00
|
|
|
"androidx-constraintlayout", "androidx-paging-runtime-ktx", "androidx-viewpager2", "androidx-work-runtime-ktx",
|
Move ExoPlayer initialization to a Dagger module and optimize its dependencies (#4296)
Currently, ExoPlayer is initialized explicitly in `ViewMediaFragment`
with all its dependencies, including many that are not useful for
viewing Mastodon media attachments.
This pull request moves most ExoPlayer initialization and configuration
to a new Dagger module, and instead a `Provider<ExoPlayer>` factory is
injected in the Fragment so it can create new instances when needed.
The following ExoPlayer components will be configured:
- **Renderers**: all of them (audio, video, metadata, subtitles) except
for the `CameraMotionRenderer`.
- **Extractors**: FLAC, Wav, Mp4, Ogg, Matroska/WebM and MP3 containers,
to provide the same support as Firefox or Chrome browsers. Other
container formats that are either image formats (already covered by
Glide), not web-friendly or reserved for live streaming are skipped.
- **MediaSource**: only progressive download (through OkHttp) is
provided. Live streaming support using protocols like RTSP, MPEG/Dash or
HLS is skipped, because Mastodon servers don't use these protocols to
download attachments.
The Mastodon documentation mentions the [supported media formats for
attachments](https://docs.joinmastodon.org/user/posting/#media) and this
covers them and even more. The docs also mentions that the video and
audio files are transcoded to MP4 and MP3 upon upload but that was not
the case in the past (for example WebM was used) and it could change
again in the future.
Specifying these components manually allows reducing the APK size by
about 200 KB thanks to R8 shrinking.
There are also a few extra code changes:
- Remove the code specific to API < 24 since the min SDK of the app is
now 24.
- Add support for pausing a video when unplugging headphones.
- Specify the audio attributes according to content type to help the
Android audio mixer.
2024-03-09 11:04:04 +01:00
|
|
|
"androidx-core-splashscreen", "androidx-activity", "androidx-media3-exoplayer", "androidx-media3-datasource-okhttp",
|
|
|
|
"androidx-media3-ui"]
|
2022-11-04 20:10:26 +01:00
|
|
|
dagger = ["dagger-core", "dagger-android-core", "dagger-android-support"]
|
|
|
|
dagger-processors = ["dagger-compiler", "dagger-android-processor"]
|
|
|
|
filemojicompat = ["filemojicompat-core", "filemojicompat-ui", "filemojicompat-defaults"]
|
|
|
|
glide = ["glide-core", "glide-okhttp3-integration", "glide-animation-plugin"]
|
|
|
|
material-drawer = ["material-drawer-core", "material-drawer-iconics"]
|
|
|
|
mockito = ["mockito-kotlin", "mockito-inline"]
|
Replace Gson library with Moshi (#4309)
**! ! Warning**: Do not merge before testing every API call and database
read involving JSON !
**Gson** is obsolete and has been superseded by **Moshi**. But more
importantly, parsing Kotlin objects using Gson is _dangerous_ because
Gson uses Java serialization and is **not Kotlin-aware**. This has two
main consequences:
- Fields of non-null types may end up null at runtime. Parsing will
succeed, but the code may crash later with a `NullPointerException` when
trying to access a field member;
- Default values of constructor parameters are always ignored. When
absent, reference types will be null, booleans will be false and
integers will be zero.
On the other hand, Kotlin-aware parsers like **Moshi** or **Kotlin
Serialization** will validate at parsing time that all received fields
comply with the Kotlin contract and avoid errors at runtime, making apps
more stable and schema mismatches easier to detect (as long as logs are
accessible):
- Receiving a null value for a non-null type will generate a parsing
error;
- Optional types are declared explicitly by adding a default value. **A
missing value with no default value declaration will generate a parsing
error.**
Migrating the entity declarations from Gson to Moshi will make the code
more robust but is not an easy task because of the semantic differences.
With Gson, both nullable and optional fields are represented with a null
value. After converting to Moshi, some nullable entities can become
non-null with a default value (if they are optional and not nullable),
others can stay nullable with no default value (if they are mandatory
and nullable), and others can become **nullable with a default value of
null** (if they are optional _or_ nullable _or_ both). That third option
is the safest bet when it's not clear if a field is optional or not,
except for lists which can usually be declared as non-null with a
default value of an empty list (I have yet to see a nullable array type
in the Mastodon API).
Fields that are currently declared as non-null present another
challenge. In theory, they should remain as-is and everything will work
fine. In practice, **because Gson is not aware of nullable types at
all**, it's possible that some non-null fields currently hold a null
value in some cases but the app does not report any error because the
field is not accessed by Kotlin code in that scenario. After migrating
to Moshi however, parsing such a field will now fail early if a null
value or no value is received.
These fields will have to be identified by heavily testing the app and
looking for parsing errors (`JsonDataException`) and/or by going through
the Mastodon documentation. A default value needs to be added for
missing optional fields, and their type could optionally be changed to
nullable, depending on the case.
Gson is also currently used to serialize and deserialize objects to and
from the local database, which is also challenging because backwards
compatibility needs to be preserved. Fortunately, by default Gson omits
writing null fields, so a field of type `List<T>?` could be replaced
with a field of type `List<T>` with a default value of `emptyList()` and
reading back the old data should still work. However, nullable lists
that are written directly (not as a field of another object) will still
be serialized to JSON as `"null"` so the deserializing code must still
be handling null properly.
Finally, changing the database schema is out of scope for this pull
request, so database entities that also happen to be serialized with
Gson will keep their original types even if they could be made non-null
as an improvement.
In the end this is all for the best, because the app will be more
reliable and errors will be easier to detect by showing up earlier with
a clear error message. Not to mention the performance benefits of using
Moshi compared to Gson.
- Replace Gson reflection with Moshi Kotlin codegen to generate all
parsers at compile time.
- Replace custom `Rfc3339DateJsonAdapter` with the one provided by
moshi-adapters.
- Replace custom `JsonDeserializer` classes for Enum types with
`EnumJsonAdapter.create(T).withUnknownFallback()` from moshi-adapters to
support fallback values.
- Replace `GuardedBooleanAdapter` with the more generic `GuardedAdapter`
which works with any type. Any nullable field may now be annotated with
`@Guarded`.
- Remove Proguard rules related to Json entities. Each Json entity needs
to be annotated with `@JsonClass` with no exception, and adding this
annotation will ensure that R8/Proguard will handle the entities
properly.
- Replace some nullable Boolean fields with non-null Boolean fields with
a default value where possible.
- Replace some nullable list fields with non-null list fields with a
default value of `emptyList()` where possible.
- Update `TimelineDao` to perform all Json conversions internally using
`Converters` so no Gson or Moshi instance has to be passed to its
methods.
- ~~Create a custom `DraftAttachmentJsonAdapter` to serialize and
deserialize `DraftAttachment` which is a special entity that supports
more than one json name per field. A custom adapter is necessary because
there is not direct equivalent of `@SerializedName(alternate = [...])`
in Moshi.~~ Remove alternate names for some `DraftAttachment` fields
which were used as a workaround to deserialize local data in 2-years old
builds of Tusky.
- Update tests to make them work with Moshi.
- Simplify a few `equals()` implementations.
- Change a few functions to `val`s
- Turn `NetworkModule` into an `object` (since it contains no abstract
methods).
Please test the app thoroughly before merging. There may be some fields
currently declared as mandatory that are actually optional.
2024-04-02 21:01:04 +02:00
|
|
|
moshi = ["moshi-core", "moshi-adapters"]
|
2022-11-04 20:10:26 +01:00
|
|
|
okhttp = ["okhttp-core", "okhttp-logging-interceptor"]
|
Replace Gson library with Moshi (#4309)
**! ! Warning**: Do not merge before testing every API call and database
read involving JSON !
**Gson** is obsolete and has been superseded by **Moshi**. But more
importantly, parsing Kotlin objects using Gson is _dangerous_ because
Gson uses Java serialization and is **not Kotlin-aware**. This has two
main consequences:
- Fields of non-null types may end up null at runtime. Parsing will
succeed, but the code may crash later with a `NullPointerException` when
trying to access a field member;
- Default values of constructor parameters are always ignored. When
absent, reference types will be null, booleans will be false and
integers will be zero.
On the other hand, Kotlin-aware parsers like **Moshi** or **Kotlin
Serialization** will validate at parsing time that all received fields
comply with the Kotlin contract and avoid errors at runtime, making apps
more stable and schema mismatches easier to detect (as long as logs are
accessible):
- Receiving a null value for a non-null type will generate a parsing
error;
- Optional types are declared explicitly by adding a default value. **A
missing value with no default value declaration will generate a parsing
error.**
Migrating the entity declarations from Gson to Moshi will make the code
more robust but is not an easy task because of the semantic differences.
With Gson, both nullable and optional fields are represented with a null
value. After converting to Moshi, some nullable entities can become
non-null with a default value (if they are optional and not nullable),
others can stay nullable with no default value (if they are mandatory
and nullable), and others can become **nullable with a default value of
null** (if they are optional _or_ nullable _or_ both). That third option
is the safest bet when it's not clear if a field is optional or not,
except for lists which can usually be declared as non-null with a
default value of an empty list (I have yet to see a nullable array type
in the Mastodon API).
Fields that are currently declared as non-null present another
challenge. In theory, they should remain as-is and everything will work
fine. In practice, **because Gson is not aware of nullable types at
all**, it's possible that some non-null fields currently hold a null
value in some cases but the app does not report any error because the
field is not accessed by Kotlin code in that scenario. After migrating
to Moshi however, parsing such a field will now fail early if a null
value or no value is received.
These fields will have to be identified by heavily testing the app and
looking for parsing errors (`JsonDataException`) and/or by going through
the Mastodon documentation. A default value needs to be added for
missing optional fields, and their type could optionally be changed to
nullable, depending on the case.
Gson is also currently used to serialize and deserialize objects to and
from the local database, which is also challenging because backwards
compatibility needs to be preserved. Fortunately, by default Gson omits
writing null fields, so a field of type `List<T>?` could be replaced
with a field of type `List<T>` with a default value of `emptyList()` and
reading back the old data should still work. However, nullable lists
that are written directly (not as a field of another object) will still
be serialized to JSON as `"null"` so the deserializing code must still
be handling null properly.
Finally, changing the database schema is out of scope for this pull
request, so database entities that also happen to be serialized with
Gson will keep their original types even if they could be made non-null
as an improvement.
In the end this is all for the best, because the app will be more
reliable and errors will be easier to detect by showing up earlier with
a clear error message. Not to mention the performance benefits of using
Moshi compared to Gson.
- Replace Gson reflection with Moshi Kotlin codegen to generate all
parsers at compile time.
- Replace custom `Rfc3339DateJsonAdapter` with the one provided by
moshi-adapters.
- Replace custom `JsonDeserializer` classes for Enum types with
`EnumJsonAdapter.create(T).withUnknownFallback()` from moshi-adapters to
support fallback values.
- Replace `GuardedBooleanAdapter` with the more generic `GuardedAdapter`
which works with any type. Any nullable field may now be annotated with
`@Guarded`.
- Remove Proguard rules related to Json entities. Each Json entity needs
to be annotated with `@JsonClass` with no exception, and adding this
annotation will ensure that R8/Proguard will handle the entities
properly.
- Replace some nullable Boolean fields with non-null Boolean fields with
a default value where possible.
- Replace some nullable list fields with non-null list fields with a
default value of `emptyList()` where possible.
- Update `TimelineDao` to perform all Json conversions internally using
`Converters` so no Gson or Moshi instance has to be passed to its
methods.
- ~~Create a custom `DraftAttachmentJsonAdapter` to serialize and
deserialize `DraftAttachment` which is a special entity that supports
more than one json name per field. A custom adapter is necessary because
there is not direct equivalent of `@SerializedName(alternate = [...])`
in Moshi.~~ Remove alternate names for some `DraftAttachment` fields
which were used as a workaround to deserialize local data in 2-years old
builds of Tusky.
- Update tests to make them work with Moshi.
- Simplify a few `equals()` implementations.
- Change a few functions to `val`s
- Turn `NetworkModule` into an `object` (since it contains no abstract
methods).
Please test the app thoroughly before merging. There may be some fields
currently declared as mandatory that are actually optional.
2024-04-02 21:01:04 +02:00
|
|
|
retrofit = ["retrofit-core", "retrofit-converter-moshi"]
|
2022-11-04 20:10:26 +01:00
|
|
|
room = ["androidx-room-ktx", "androidx-room-paging"]
|
2023-03-10 20:30:55 +01:00
|
|
|
xmldiff = ["diffx", "xmlwriter"]
|