bida/busky
9
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

fix warnings in test runs (#4340)

Browse source 
Found while working on #4026 but not directly related.

Two cases of unmocked methods and one of unclosed resource.
This commit is contained in:
Konrad Pozniak 2024-03-28 09:13:05 +01:00 committed by GitHub
parent 211983c7ee
commit b85ada930b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/test/java/com/keylesspalace/tusky/MainActivityTest.kt
View file

@ -18,6 +18,7 @@ import com.keylesspalace.tusky.entity.Notification
import com.keylesspalace.tusky.entity.TimelineAccount
import java.util.Date
import kotlinx.coroutines.test.TestScope
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNotNull
import org.junit.Before
@ -60,6 +61,11 @@ class MainActivityTest {
WorkManagerTestInitHelper.initializeTestWorkManager(context)
}
@After
fun teardown() {
WorkManagerTestInitHelper.closeWorkDatabase()
}
@Test
fun `clicking notification of type FOLLOW shows notification tab`() {
val intent = showNotification(Notification.Type.FOLLOW)

5
app/src/test/java/com/keylesspalace/tusky/components/compose/ComposeActivityTest.kt
View file

@ -35,6 +35,7 @@ import com.keylesspalace.tusky.di.ViewModelFactory
import com.keylesspalace.tusky.entity.Instance
import com.keylesspalace.tusky.entity.InstanceConfiguration
import com.keylesspalace.tusky.entity.InstanceV1
import com.keylesspalace.tusky.entity.SearchResult
import com.keylesspalace.tusky.entity.StatusConfiguration
import com.keylesspalace.tusky.network.MastodonApi
import java.util.Locale
@ -49,6 +50,7 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.kotlin.any
import org.mockito.kotlin.anyOrNull
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.eq
import org.mockito.kotlin.mock
@ -123,6 +125,9 @@ class ComposeActivityTest {
NetworkResult.success(instance)
}
}
onBlocking { search(anyOrNull(), anyOrNull(), anyOrNull(), anyOrNull(), anyOrNull(), anyOrNull()) } doReturn NetworkResult.success(
SearchResult(emptyList(), emptyList(), emptyList())
)
}
val instanceDaoMock: InstanceDao = mock {

4
app/src/test/java/com/keylesspalace/tusky/components/viewthread/ViewThreadViewModelTest.kt
View file

@ -77,7 +77,9 @@ class ViewThreadViewModelTest {
fun setup() {
shadowOf(getMainLooper()).idle()
api = mock()
api = mock {
onBlocking { getFilters() } doReturn NetworkResult.success(emptyList())
}
eventHub = EventHub()
val filterModel = FilterModel()
val timelineCases = TimelineCases(api, eventHub)