blallo/rss-bridge
1
0
Fork 1
Code Issues Pull requests Releases Wiki Activity

[AtomFormat] Use $item->author for author name

Browse source 
$item->name was inteded as the author name and $item->author as the author
uri.

Bridges use $item->name and $item->author interchangably for author name,
so $item->name can be removed.

$item->author is now used for the author name!
This commit is contained in:
logmanoriginal 2016-08-08 23:41:52 +02:00
parent f3eefab475
commit 8c21769078
2 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CREATE_BRIDGE.md
View file

@ -113,7 +113,6 @@ The `Item` class is used to store parameter that are collected in the [`collectD
```PHP ```PHP
$item->uri // URI to reach the subject ("http://...") $item->uri // URI to reach the subject ("http://...")
$item->title // Title of the item $item->title // Title of the item
$item->name // Name of the item
$item->timestamp // Timestamp of the item in numeric format (use strtotime) $item->timestamp // Timestamp of the item in numeric format (use strtotime)
$item->author // Name of the author $item->author // Name of the author
$item->content // Content in HTML format $item->content // Content in HTML format
@ -138,7 +137,6 @@ Parameter | ATOM | HTML | (M)RSS
----------|------|------|------- ----------|------|------|-------
`uri`|X|X|X `uri`|X|X|X
`title`|X|X|X `title`|X|X|X
`name`|X||
`timestamp`|X|X|X `timestamp`|X|X|X
`author`|X|X|X `author`|X|X|X
`content`|X|X|X `content`|X|X|X

4
formats/AtomFormat.php
View file

@ -28,7 +28,6 @@ class AtomFormat extends FormatAbstract{
$entries = ''; $entries = '';
foreach($this->getDatas() as $data){ foreach($this->getDatas() as $data){
$entryName = is_null($data->name) ? $title : xml_encode($data->name);
$entryAuthor = is_null($data->author) ? $uri : xml_encode($data->author); $entryAuthor = is_null($data->author) ? $uri : xml_encode($data->author);
$entryTitle = is_null($data->title) ? '' : xml_encode($data->title); $entryTitle = is_null($data->title) ? '' : xml_encode($data->title);
$entryUri = is_null($data->uri) ? '' : xml_encode($data->uri); $entryUri = is_null($data->uri) ? '' : xml_encode($data->uri);
@ -40,8 +39,7 @@ class AtomFormat extends FormatAbstract{
<entry> <entry>
<author> <author>
<name>{$entryName}</name> <name>{$entryAuthor}</name>
<uri>{$entryAuthor}</uri>
</author> </author>
<title type="html"><![CDATA[{$entryTitle}]]></title> <title type="html"><![CDATA[{$entryTitle}]]></title>
<link rel="alternate" type="text/html" href="{$entryUri}" /> <link rel="alternate" type="text/html" href="{$entryUri}" />