Fix indentation and improve code style

- Use tab instead of spaces
- Remove obsolete bridge description at start of the file
- Add spaces at the assignment operator ('=' -> ' = ')
- Remove unnecessary empty lines
This commit is contained in:
logmanoriginal 2016-08-02 21:40:22 +02:00
parent f783969721
commit a1c680f8e8

View file

@ -1,99 +1,91 @@
<?php <?php
/**
* ElsevierBridge
*
* @name Elsevier Bridge
* @description Returns the recent articles published in Elsevier journals
*/
class ElsevierBridge extends BridgeAbstract{ class ElsevierBridge extends BridgeAbstract{
public function loadMetadatas() { public function loadMetadatas() {
$this->maintainer = 'Pierre Mazière'; $this->maintainer = 'Pierre Mazière';
$this->name = 'Elsevier journals recent articles'; $this->name = 'Elsevier journals recent articles';
$this->uri = 'http://www.journals.elsevier.com'; $this->uri = 'http://www.journals.elsevier.com';
$this->description = 'Returns the recent articles published in Elsevier journals'; $this->description = 'Returns the recent articles published in Elsevier journals';
$this->update = '2016-08-02'; $this->update = '2016-08-02';
$this->parameters[] = $this->parameters[] =
'[ '[
{ {
"name" : "Journal name", "name" : "Journal name",
"identifier" : "j", "identifier" : "j",
"required" : "true", "required" : "true",
"exampleValue" : "academic-pediatrics", "exampleValue" : "academic-pediatrics",
"title" : "Insert html-part of your journal" "title" : "Insert html-part of your journal"
} }
]'; ]';
} }
// Extracts the list of names from an article as string // Extracts the list of names from an article as string
function ExtractArticleName ($article){ function ExtractArticleName ($article){
$names = $article->find('small', 0); $names = $article->find('small', 0);
if($names) if($names)
return trim($names->plaintext); return trim($names->plaintext);
return ''; return '';
} }
// Extracts the timestamp from an article // Extracts the timestamp from an article
function ExtractArticleTimestamp ($article){ function ExtractArticleTimestamp ($article){
$time = $article->find('.article-info', 0); $time = $article->find('.article-info', 0);
if($time){ if($time){
$timestring = trim($time->plaintext); $timestring = trim($time->plaintext);
/* /*
The format depends on the age of an article: The format depends on the age of an article:
- Available online 29 July 2016 - Available online 29 July 2016
- July 2016 - July 2016
- MayJune 2016 - MayJune 2016
*/ */
if(preg_match('/\S*(\d+\s\S+\s\d{4})/ims', $timestring, $matches)){ if(preg_match('/\S*(\d+\s\S+\s\d{4})/ims', $timestring, $matches)){
return strtotime($matches[0]); return strtotime($matches[0]);
} elseif (preg_match('/([A-Za-z]+\s\d{4})/ims', $timestring, $matches)){ } elseif (preg_match('/([A-Za-z]+\s\d{4})/ims', $timestring, $matches)){
return strtotime($matches[0]); return strtotime($matches[0]);
} elseif (preg_match('/[A-Za-z]+\-([A-Za-z]+\s\d{4})/ims', $timestring, $matches)){ } elseif (preg_match('/[A-Za-z]+\-([A-Za-z]+\s\d{4})/ims', $timestring, $matches)){
return strtotime($matches[0]); return strtotime($matches[0]);
} else { } else {
return 0; return 0;
} }
} }
return 0; return 0;
} }
// Extracts the content from an article // Extracts the content from an article
function ExtractArticleContent ($article){ function ExtractArticleContent ($article){
$content = $article->find('.article-content', 0); $content = $article->find('.article-content', 0);
if($content){ if($content){
return trim($content->plaintext); return trim($content->plaintext);
} }
return ''; return '';
} }
public function collectData(array $param){ public function collectData(array $param){
$uri = 'http://www.journals.elsevier.com/'.$param['j'].'/recent-articles/'; $uri = 'http://www.journals.elsevier.com/' . $param['j'] . '/recent-articles/';
$html = file_get_html($uri) $html = file_get_html($uri) or $this->returnError('No results for Elsevier journal '.$param['j'], 404);
or $this->returnError('No results for Elsevier journal '.$param['j'], 404);
foreach($html->find('.pod-listing') as $article){ foreach($html->find('.pod-listing') as $article){
$item = new \Item();
$item->uri = $article->find('.pod-listing-header>a',0)->getAttribute('href').'?np=y';
$item->title = $article->find('.pod-listing-header>a',0)->plaintext;
$item->name = $this->ExtractArticleName($article);
$item->timestamp = $this->ExtractArticleTimestamp($article);
$item->content = $this->ExtractArticleContent($article);
$this->items[] = $item;
}
}
$item = new \Item(); public function getName(){
$item->uri=$article->find('.pod-listing-header>a',0)->getAttribute('href').'?np=y'; return 'Elsevier journals recent articles';
$item->title=$article->find('.pod-listing-header>a',0)->plaintext; }
$item->name=$this->ExtractArticleName($article);
$item->timestamp=$this->ExtractArticleTimestamp($article);
$item->content=$this->ExtractArticleContent($article);
$this->items[]=$item; public function getURI(){
} return 'http://www.journals.elsevier.com';
} }
public function getName(){ public function getCacheDuration(){
return 'Elsevier journals recent articles'; return 43200; // 12h
} }
public function getURI(){
return 'http://www.journals.elsevier.com';
}
public function getCacheDuration(){
return 43200; // 12h
}
} }
?>