blallo/tt-rss
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

create_published_article: better check for duplicate URLs, wrap everything in a transaction

Browse source
This commit is contained in:
Andrew Dolgov 2012-09-15 19:52:53 +04:00
parent 71b6a2360e
commit d2088ee6d5
1 changed files with 21 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
include/functions.php
View file

@ -5609,26 +5609,36 @@
} }
function create_published_article($link, $title, $url, $content, $owner_uid) { function create_published_article($link, $title, $url, $content, $owner_uid) {
$guid = 'tt-rss-share:' . uniqid(); $guid = sha1($url);
$content_hash = sha1($content); $content_hash = sha1($content);
$rc = false;
if (!$title) $title = $url; if (!$title) $title = $url;
if (!$title && !$url) return false; if (!$title && !$url) return false;
if (filter_var($url, FILTER_VALIDATE_URL) === FALSE) return false; if (filter_var($url, FILTER_VALIDATE_URL) === FALSE) return false;
$result = db_query($link, "SELECT id FROM ttrss_entries WHERE db_query($link, "BEGIN");
link = '$url' LIMIT 1");
// only check for our user data here, others might have shared this with different content etc
$result = db_query($link, "SELECT id FROM ttrss_entries, ttrss_user_entries WHERE
link = '$url' AND ref_id = id AND owner_uid = '$owner_uid' LIMIT 1");
if (db_num_rows($result) != 0) { if (db_num_rows($result) != 0) {
$ref_id = db_fetch_result($result, 0, "id"); $ref_id = db_fetch_result($result, 0, "id");
$result = db_query($link, "SELECT int_id FROM ttrss_user_entries WHERE $result = db_query($link, "SELECT int_id FROM ttrss_user_entries WHERE
ref_id = '$ref_id' AND owner_uid = '$owner_uid'"); ref_id = '$ref_id' AND owner_uid = '$owner_uid' LIMIT 1");
if (db_num_rows($result) != 0) { if (db_num_rows($result) != 0) {
$int_id = db_fetch_result($result, 0, "int_id");
db_query($link, "UPDATE ttrss_entries SET
content = '$content', content_hash = '$content_hash' WHERE id = '$ref_id'");
db_query($link, "UPDATE ttrss_user_entries SET published = true WHERE db_query($link, "UPDATE ttrss_user_entries SET published = true WHERE
ref_id = '$ref_id' AND owner_uid = '$owner_uid'"); int_id = '$int_id' AND owner_uid = '$owner_uid'");
} else { } else {
db_query($link, "INSERT INTO ttrss_user_entries db_query($link, "INSERT INTO ttrss_user_entries
@ -5637,7 +5647,7 @@
('$ref_id', '', NULL, NULL, $owner_uid, true, '', '', NOW(), '', false)"); ('$ref_id', '', NULL, NULL, $owner_uid, true, '', '', NOW(), '', false)");
} }
return true; $rc = true;
} else { } else {
$result = db_query($link, "INSERT INTO ttrss_entries $result = db_query($link, "INSERT INTO ttrss_entries
@ -5655,10 +5665,13 @@
VALUES VALUES
('$ref_id', '', NULL, NULL, $owner_uid, true, '', '', NOW(), '', false)"); ('$ref_id', '', NULL, NULL, $owner_uid, true, '', '', NOW(), '', false)");
return true; $rc = true;
} }
return false;
} }
db_query($link, "COMMIT");
return $rc;
} }
?> ?>