Commit graph

178 commits

Author SHA1 Message Date
Andrew Dolgov
9ef1985f1b viewfeed.js: cleanup the code a bit 2015-07-13 01:28:02 +03:00
Andrew Dolgov
ac4c1383ae bring cdmFeedTitle style in line with the rest of the UI
send headline rows as separate JSON objects
2015-07-13 01:19:52 +03:00
Andrew Dolgov
48fefe2f6b fixes for first_id stuff 2015-07-12 18:08:02 +03:00
Andrew Dolgov
39d488a256 viewfeed: set hsp status when scrolling to the very end 2015-07-12 13:37:24 +03:00
Andrew Dolgov
15ae8cd084 js: remove current_top_id global 2015-07-12 13:30:00 +03:00
Andrew Dolgov
3444020100 report top id changed in headlines buffer 2015-07-12 12:01:34 +03:00
Andrew Dolgov
f5a0fb8b64 queryFeedHeadlines: move to array-based arguments, optionally check if first element changed when paginating 2015-07-12 01:29:36 +03:00
Andrew Dolgov
5a45821ec9 prevent event propagation when clicking on CDM article footer 2015-06-18 16:00:03 +03:00
Andrew Dolgov
a72cd54ce1 bayes: properly reset score when going good -> ugly
article: add helper to refresh article score pic, properly set scorepic title
2015-06-17 22:04:32 +03:00
Anders Kaseorg
5c145bde7a Make the floating title transition smoother
Previously the floating title would not appear until the real title
scrolled entirely out of view, which was visually distracting.  Now it
appears at the point when its bottom lines up with the real title’s
bottom.  This isn’t perfect yet due to small differences between the
two titles’ layouts, but it’s much closer.

We now need to use visibility: visible|hidden instead of display:
block|none to show and hide the floating title, in order to be able to
retrieve its height while it’s hidden.  It’s important to use that
height because occasionally line wrapping differences make the
floating title shorter than the real title, and we don’t want the real
title to poke out from underneath.

Also fix scrollToRowId to offset by the 4 pixel top margin (like
cdmScrollToArticleId already does), so that it goes back to a point
when the floating title was hidden; and set the right margin on the
floating title so that it’s the same width as the real title and
doesn’t overlap the scroll bar.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2015-01-30 21:58:44 -05:00
Andrew Dolgov
760183e37d minor spacer/whiteBox appearance tweaks 2014-07-26 22:08:33 +04:00
Andrew Dolgov
1d6191ee0a always create headline-spacer on lazy load 2014-07-26 22:00:33 +04:00
Andrew Dolgov
74217c72a1 adjust scroll amount to trigger auto-opening next unread feed 2014-07-25 15:40:38 +04:00
Andrew Dolgov
22f675e5c4 add a link to headlines-spacer to open next unread feed 2014-07-25 13:54:10 +04:00
Andrew Dolgov
0f85f483e5 another implementation of pull 386 (show next when finished reading) (2) 2014-07-25 12:29:30 +04:00
Andrew Dolgov
b7c20a3759 another implementation of pull 386 (show next when finished reading) 2014-07-25 12:14:06 +04:00
Andrew Dolgov
6472dd11a2 Revert "scroll to end to show next feed or category"
This reverts commit 86f32020f6.
2014-07-25 09:20:00 +04:00
wolle
86f32020f6 scroll to end to show next feed or category
only if cmd_auto_catchup and on_catchup_show_next_feed set
2014-06-28 15:04:08 +02:00
Andrew Dolgov
bace5e9e6f prevent cdmClicked ctrl-click handler working on article body 2014-05-08 06:41:21 +00:00
Andrew Dolgov
df63125dd7 handle_rpc_json: do not crash if net-alert is somehow unavailable 2014-03-14 14:05:32 +04:00
Andrew Dolgov
1bffd1068f unify main and headlines toolbar 2014-01-27 22:03:42 +04:00
Andrew Dolgov
b8fd08d6db do not unpack all visible headlines in collapsed mode because those are unpacked on expand 2013-10-21 16:55:36 +04:00
Andrew Dolgov
24940c3dc9 catchup group: deselect everything before processing 2013-10-20 18:45:24 +04:00
Andrew Dolgov
87065739cd add context menu for cdmFeedTitle; change mark as read prompt for grouped headlines more clear 2013-10-17 13:38:48 +04:00
Andrew Dolgov
2e35b3bd6b prevent automatic selection of headlines row first child when scrolling in 3panel mode because it screws with keyboard navigation (closes #752) 2013-09-09 14:38:28 +04:00
Andrew Dolgov
95be6e0c89 fix second row being selected on viewfeed (closes #748) 2013-07-17 12:16:54 +04:00
Andrew Dolgov
00fe7886b6 update floating title unread status when auto catching up 2013-07-16 10:05:48 +04:00
Andrew Dolgov
41d37fb2c3 add experimental hack to show row unread status in floating title 2013-07-16 09:59:14 +04:00
Andrew Dolgov
0971cc619d remove dijit checkbox element from floatingTitle 2013-07-15 09:15:07 +04:00
Andrew Dolgov
65f0eb01aa support headlines context menu in floating title 2013-07-11 16:49:25 +04:00
Andrew Dolgov
7415fcf212 enable floating title for expandable combined mode, minor expandable mode fixes 2013-07-11 12:28:24 +04:00
Andrew Dolgov
301a09dc55 fix floating title sometimes obscuring next article title 2013-07-11 08:35:12 +04:00
Andrew Dolgov
d095f42fa4 floating title: remove cdm auto catchup id hack for the time being 2013-07-10 22:16:10 +04:00
Andrew Dolgov
8ee5e9e5e6 rework floatingtitle 2013-07-10 22:11:24 +04:00
Andrew Dolgov
03304fda54 if multiple articles are selected, do not reset active article / selection on scroll if auto catchup is enabled 2013-07-09 12:34:57 +04:00
Andrew Dolgov
4f62f8f6dc add js hook for floating title 2013-06-28 08:30:35 +04:00
Veit Lehmann
d1754390cc only do article update operations once when scrolling
I discovered that DOM operations and function calls were done several times inside the 100px mirror when scrolling through articles. Especially painful on seamless scrolling systems like Mac OS, where dozens of updates would slow down this part dramatically. This change fixes it.
2013-06-25 06:08:44 +03:00
Andrew Dolgov
d1343b844d make floating title less cpu intensive 2013-06-25 01:35:07 +04:00
Jeffrey Tolar
3b2605a02e Add some checks to see if the content element exists
This *might* help dismissal not break when not using combined mode.
2013-06-21 23:49:35 -05:00
Jeffrey Tolar
055a37e083 Fix incorrect function name in exception handling 2013-06-21 23:31:59 -05:00
Jeffrey Tolar
abba5dd4d4 Remove content when an article is dismissed 2013-06-21 23:30:55 -05:00
Veit Lehmann
5313ae17e4 only update floatingTitle innerHTML if active article changes
This will boost scrolling performance pretty much and avoid flickering of floatingTitle
2013-06-09 02:02:14 +03:00
Andrew Dolgov
5f9699a53f hide floatingTitle when first batch of headlines is received 2013-06-07 10:04:43 +04:00
Andrew Dolgov
19b906b94b block automarking headlines on scroll in unexpanded cdm because it doesn't work so well 2013-06-06 10:09:02 +04:00
Andrew Dolgov
08820be70b add experimental floating title when scrolling long articles in combined mode 2013-06-05 22:20:22 +04:00
Andrew Dolgov
1ffd534f43 fix wrong article context menu item toggle marked (should be toggle starred) 2013-05-29 16:14:32 +04:00
Andrew Dolgov
2a7362596f moveToPost: check for current article element existing before getting its position info (closes #695) 2013-05-27 22:11:20 +04:00
Andrew Dolgov
6e098e5e8c enlarge auto mark offset height 2013-05-16 10:52:33 +04:00
Andrew Dolgov
99d89d10b0 when auto selecting, only select articles actually near the buffer top 2013-05-16 10:50:38 +04:00
Andrew Dolgov
4bc6489a80 previous patch, fix typo 2013-05-16 10:00:29 +04:00