#17 "http" should be able to resume

Open
opened 2 years ago by boyska · 1 comments
boyska commented 2 years ago

Is it a bug or a feature request?

A feature request

Describe what happens

Let's say there is an audio based on the http kind. The file it is downloading is very big, so downloading takes a long time. Since this is problematic for larigira, a sysadmin might want to execute the action with large advance (manually, using cron), running this

/usr/local/bin/larigira-dbmanage getaction 1234 | env TMPDIR=/tmp/larigira.1000/ /usr/local/bin/larigira-audiogen -

larigira should be able to behave appropriately, and use this cached file. This doesn't work, because the http audiogenerator uses mkstemp, which creates a random file name, so this could never possibly work.

what should happen, instead?

running it twice should be idempotent.

describe all the steps we can do to reproduce the bug

run the aforementioned command two times. the second time you run it, network transfer should be very small. The same filename should be used.

## Is it a bug or a feature request? A feature request ## Describe what happens Let's say there is an audio based on the `http` kind. The file it is downloading is very big, so downloading takes a long time. Since this is problematic for larigira, a sysadmin might want to execute the action with large advance (manually, using `cron`), running this ``` /usr/local/bin/larigira-dbmanage getaction 1234 | env TMPDIR=/tmp/larigira.1000/ /usr/local/bin/larigira-audiogen - ``` `larigira` should be able to behave appropriately, and use this cached file. This doesn't work, because the `http` audiogenerator uses `mkstemp`, which creates a _random_ file name, so this could never possibly work. ### what should happen, instead? running it twice should be idempotent. ### describe all the steps we can do to reproduce the bug run the aforementioned command two times. the second time you run it, network transfer should be very small. The same filename should be used.
boyska referenced this issue from a commit 2 years ago
boyska commented 2 years ago
Owner

branch http-improve seems to be working, but need real-life tests before getting merged.

branch `http-improve` seems to be working, but need real-life tests before getting merged.
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.