瀏覽代碼

Fix Cache write verification

PHP operator '===' is the only strict way to mix up the value '0' and
the value 'FALSE'.

The function saveData of the FileCache tests if the write of the cache
files was done with success and raise an Exception if not. The test was
done without the '===' operator, and if the data is 0 bytes long the
error message says there is a permission error, which is false.

A data 0 bytes long is another issue, either in the json_encode function
either in the Bridge, but not a permission issue.
Gilles Maurer 7 年之前
父節點
當前提交
4dfbc16a5b
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      caches/FileCache.php

+ 1 - 1
caches/FileCache.php

@@ -14,7 +14,7 @@ class FileCache implements CacheInterface {
 	public function saveData($datas){
 		$writeStream = file_put_contents($this->getCacheFile(), json_encode($datas, JSON_PRETTY_PRINT));
 
-		if(!$writeStream) {
+		if($writeStream === FALSE) {
 			throw new \Exception("Cannot write the cache... Do you have the right permissions ?");
 		}