campiaperti/infra
1
0
Fork 1
Code Issues Pull requests 1 Releases Wiki Activity

fix edge case in singleton node creation

Browse source
This commit is contained in:
Hakim El Hattab 2014-05-07 22:02:05 +02:00
parent f31f0ffa70
commit c4e202cd0f
1 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
js/reveal.js
View file

@ -518,18 +518,26 @@
*/
function createSingletonNode( container, tagname, classname, innerHTML ) {
var node = container.querySelector( '.' + classname );
// Find all nodes matching the description
var nodes = container.querySelectorAll( '.' + classname );
// If no node was found or the node is inside another container
if( !node || node.parentNode !== container ) {
node = document.createElement( tagname );
node.classList.add( classname );
if( typeof innerHTML === 'string' ) {
node.innerHTML = innerHTML;
// Check all matches to find one which is a direct child of
// the specified container
for( var i = 0; i < nodes.length; i++ ) {
var testNode = nodes[i];
if( testNode.parentNode === container ) {
return testNode;
}
container.appendChild( node );
}
// If no node was found, create it now
var node = document.createElement( tagname );
node.classList.add( classname );
if( typeof innerHTML === 'string' ) {
node.innerHTML = innerHTML;
}
container.appendChild( node );
return node;
}