Events last notification timestamp gets updated if notification fails #97

Open
opened 2026-03-02 09:14:40 +00:00 by versus · 0 comments
Owner

Fix unconditional calls to notifier.repository.UpdateEvents() in DailyEventsNotifier.sendNotification() by checking errors from previous channels.SendEventMessages(). Do not update last notification on fail, but definition of failure is needed:

  • All channels failed -> failing channels will miss notifications
  • At least one channel failed -> non failing channels will receive duplicates untill all succeed
  • Something in between (ratio) -> same issues

Alternatively track last update for every channel -> might introduce a time offset among channels

Fix unconditional calls to _notifier.repository.UpdateEvents()_ in _DailyEventsNotifier.sendNotification()_ by checking errors from previous _channels.SendEventMessages()_. Do not update last notification on fail, but definition of failure is needed: - All channels failed -> failing channels will miss notifications - At least one channel failed -> non failing channels will receive duplicates untill all succeed - Something in between (ratio) -> same issues Alternatively track last update for every channel -> might introduce a time offset among channels
versus added this to the v0.2.0 milestone 2026-03-02 09:14:40 +00:00
versus added this to the Tasks project 2026-03-02 09:14:41 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jammella/gancio.notification#97
No description provided.