Events last notification timestamp gets updated if notification fails #97
Labels
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jammella/gancio.notification#97
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fix unconditional calls to notifier.repository.UpdateEvents() in DailyEventsNotifier.sendNotification() by checking errors from previous channels.SendEventMessages(). Do not update last notification on fail, but definition of failure is needed:
Alternatively track last update for every channel -> might introduce a time offset among channels