opuppet/module-concat
4
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix pending tests

Browse source 
With rspec 3, pending() started inverting the logic so that if a
pending tests succeeds then it fails (so you can block on a future
change). These tests have no body so will always succeed.

Anyway, pending -> skip reverts the logic to the usual.
This commit is contained in:
Hunter Haugen 2015-01-09 16:44:58 -08:00
parent 7ed3f566c6
commit cff25a8b60
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
spec/unit/classes/concat_setup_spec.rb
View file

@ -43,7 +43,7 @@ describe 'concat::setup', :type => :class do
context 'deprecated as a public class' do
it 'should create a warning' do
pending('rspec-puppet support for testing warning()')
skip('rspec-puppet support for testing warning()')
end
end

10
spec/unit/defines/concat_fragment_spec.rb
View file

@ -96,7 +96,7 @@ describe 'concat::fragment', :type => :define do
let(:params) {{ :ensure => 'invalid', :target => '/etc/motd' }}
it 'should create a warning' do
pending('rspec-puppet support for testing warning()')
skip('rspec-puppet support for testing warning()')
end
end
end # ensure =>
@ -244,7 +244,7 @@ describe 'concat::fragment', :type => :define do
}
it 'should create a warning' do
pending('rspec-puppet support for testing warning()')
skip('rspec-puppet support for testing warning()')
end
end
end # mode =>
@ -257,7 +257,7 @@ describe 'concat::fragment', :type => :define do
}
it 'should create a warning' do
pending('rspec-puppet support for testing warning()')
skip('rspec-puppet support for testing warning()')
end
end
end # owner =>
@ -270,7 +270,7 @@ describe 'concat::fragment', :type => :define do
}
it 'should create a warning' do
pending('rspec-puppet support for testing warning()')
skip('rspec-puppet support for testing warning()')
end
end
end # group =>
@ -283,7 +283,7 @@ describe 'concat::fragment', :type => :define do
}
it 'should create a warning' do
pending('rspec-puppet support for testing warning()')
skip('rspec-puppet support for testing warning()')
end
end
end # backup =>

4
spec/unit/defines/concat_spec.rb
View file

@ -279,7 +279,7 @@ describe 'concat', :type => :define do
it_behaves_like 'concat', '/etc/foo.bar', { :warn => warn }
it 'should create a warning' do
pending('rspec-puppet support for testing warning()')
skip('rspec-puppet support for testing warning()')
end
end
end
@ -386,7 +386,7 @@ describe 'concat', :type => :define do
it_behaves_like 'concat', '/etc/foo.bar', { :gnu => 'foo'}
it 'should create a warning' do
pending('rspec-puppet support for testing warning()')
skip('rspec-puppet support for testing warning()')
end
end
end