Commit graph

395 commits

Author SHA1 Message Date
Ashley Penney
39b807c840 Merge pull request #124 from jhoblitt/revert_warn_message
revert concat $warn/$warn_message param split + add deprecation warnings
2013-12-24 06:20:44 -08:00
Joshua Hoblitt
8a500af5ee revert concat $warn/$warn_message param split + add deprecation warnings
Partially reverting the $warn/$warn_message param split from eaf8407 as this
change was unnecessarily API breaking.  Instead, we are adding string/bool type
validating to the $warn parameter and deprecation warnings for the usage of
stringified boolean values (eg, 'true', 'on', etc.). In a future major release,
the logic can be simplified to treating all string values as a warning message.
2013-12-23 13:23:49 -08:00
Alexander Kuznetsov
00a8f4e736 [Most of] variables quoted to allow multi-word warning messages, spaces in file/directory names, etc. 2013-12-17 11:03:38 -05:00
Ashley Penney
63b5aba9fd Merge pull request #117 from jhoblitt/fragment_source
fix regression preventing usage of fragment ensure => /target syntax
2013-12-08 07:47:27 -08:00
Joshua Hoblitt
41d5d4ccd1 fix regression preventing usage of fragment ensure => /target syntax
Also fix a historical bug that prevents a fragment from being converted
from a symlink to using a source or content parameter.
2013-12-05 22:39:23 -07:00
Joshua Hoblitt
f1a57a6c7e add system tests for file fragments sourced from a single file
In addition to checking for fragment sourcing from a 'list' of files.
2013-12-05 10:12:29 -07:00
Joshua Hoblitt
f4c368ec2e Merge pull request #115 from hundredacres/master
Cleaning up linting issues
2013-12-04 20:45:11 -08:00
Matthew Schmitt
9bf4b7f350 Cleaning up linting error with ensure param 2013-12-04 20:40:05 -08:00
Ashley Penney
07a4f61af5 Rewrite the docs to fit the current best practices for Puppetlabs
modules.
2013-12-03 13:22:41 -05:00
Joshua Hoblitt
75cdbf4fc6 Merge pull request #110 from 3flex/patch-1
Improve formatting of README code example
2013-12-02 22:17:13 -08:00
Matthew Haughton
952b88b45b Improve formatting of code example
* Puppet syntax highlighting
* Double-spaced indentation
* Aligned instances of =>
* Quoted strings
* Single-quoted some unnecessarily double-quoted strings
* Removed comma from the last variable
2013-12-02 21:32:32 -05:00
Ashley Penney
68da185f4e Merge pull request #111 from haf/patch-1
See #67
2013-11-26 05:33:29 -08:00
Henrik Feldt
24e0cda13e See #67 2013-11-26 12:14:03 +01:00
Ashley Penney
afdda8622a Merge pull request #109 from jhoblitt/system_replacement_tests
add system tests for replacing symlinks and directories
2013-11-18 14:39:14 -08:00
Joshua Hoblitt
ae1e74cf36 add system tests for replacing symlinks and directories 2013-11-18 14:58:46 -07:00
Ashley Penney
b69c7f0c9b Merge pull request #107 from terrimonster/addtests
adding basic manifest tests
2013-11-18 10:49:12 -08:00
Terri Haber
7c702a5713 adding basic manifest tests 2013-11-15 15:51:37 -08:00
Ashley Penney
4ff6aa5716 Merge pull request #106 from jhoblitt/system_test_cleanups
minor system test cleanups
2013-11-14 09:59:11 -08:00
Ashley Penney
f9edb94b20 Merge pull request #105 from jhoblitt/system_test_isolation
clean up between system spec files
2013-11-14 09:58:53 -08:00
Joshua Hoblitt
4ee4be00ac minor system test cleanups 2013-11-13 20:28:27 -07:00
Joshua Hoblitt
c852dc22d7 clean up between system spec files 2013-11-13 17:56:47 -07:00
Joshua Hoblitt
911bb65b78 Merge pull request #104 from dreamlibrarian/fix/fragment-source-test
Test concat::fragment for source => [] compatibility.
2013-11-13 16:32:31 -08:00
Tristan Smith
499f338ce5 put the shell() calls into before{} blocks so that they're executed meaningfully. Testing to make sure a file doesn't exist shouldn't be as much of a hack as that is. I'm obviously missing something in the framework, but this works. 2013-11-13 14:23:30 -08:00
Tristan Smith
6c687551d8 Initial pass at test to ensure fragments accept and properly handle the underlying file source attribute. 2013-11-13 11:31:56 -08:00
Ashley Penney
5b9ed7093a Merge pull request #103 from jhoblitt/fragment_source
allow source param to concat::fragment to be a string or an Array
2013-11-13 05:26:01 -08:00
Joshua Hoblitt
ba9501c1a0 allow source param to concat::fragment to be a string or an Array
This is resolve a regression preventing an array of string(s) being passed to the fragment file resource's source parameter.
2013-11-12 23:20:48 -07:00
Ashley Penney
527c266997 Merge pull request #101 from jhoblitt/travis_matrix
update travis matrix
2013-11-12 09:29:45 -08:00
jhoblitt
9025ab41fd update travis matrix
- peg the oldest tested version at puppet 2.7.3 + facter 1.6.0,
  primarily to try to catch the class param dangling comma issue that
  effects older versions of puppet
- let the newest version of puppet 3.x free float
2013-11-12 05:19:08 -07:00
Joshua Hoblitt
f2bdcb0495 Merge pull request #100 from xepa/puppet_2_6_x_compat
Puppet 2.6.x compatibility fix
2013-11-12 04:09:22 -08:00
Michiel Brandenburg
2ef05a73fe Puppet 2.6.x compatibility 2013-11-12 11:36:34 +01:00
Joshua Hoblitt
8695e7ff63 Merge pull request #96 from jhoblitt/fact_tests
add tests for concat_basedir fact
2013-11-03 10:58:26 -08:00
Joshua Hoblitt
2236733267 Merge pull request #98 from jhoblitt/deprecation_warnings
add rspec-puppet pending test for warning on inclusion of concat::setup
2013-11-03 10:56:33 -08:00
Joshua Hoblitt
8f53c479cb add rspec-puppet pending test for warning on inclusion of concat::setup 2013-11-03 11:26:09 -07:00
Joshua Hoblitt
9371ae9517 Merge pull request #97 from jhoblitt/fact_whitespace
convert from 4 space to 2 space indent
2013-11-03 10:04:30 -08:00
Joshua Hoblitt
41695bd627 convert from 4 space to 2 space indent 2013-11-03 11:02:00 -07:00
Joshua Hoblitt
a08709caf7 add tests for concat_basedir fact 2013-11-03 10:20:32 -07:00
Ashley Penney
0580e3f2a0 Merge pull request #95 from jhoblitt/fragment_params
deprecate concat::fragment mode, owner, & group params
2013-11-02 15:45:03 -07:00
Joshua Hoblitt
1a926b933c deprecate concat::fragment mode, owner, & group params
There's no need to allow the ownership/permissions of a fragment to be set as
the concat define sets ownership/permissions on the final aggregated file.
2013-11-02 13:39:12 -07:00
Ashley Penney
7437a68016 Merge pull request #91 from jhoblitt/exec_as_root_when_root
always exec the concatfragments script as root when running as root
2013-11-02 13:14:51 -07:00
Ashley Penney
9c6378a78c Merge pull request #93 from jhoblitt/tidyups
Tidyups
2013-11-02 13:14:00 -07:00
Ashley Penney
7db163cd64 Merge pull request #94 from jhoblitt/symbolic_names
allow concat::fragment target param to be an arbitrary string
2013-11-02 13:13:08 -07:00
Joshua Hoblitt
79352f4da6 allow concat::fragment target param to be an arbitrary string
Revert validation of the target param as an absolute path and allow it to be an
arbitrary string.  This is so the

    concat { <foo>: path => ...  }
    concat::fragment { ...: target => <foo> }

association may be symbolic as long as concat path param is specified.  This
should resolve the symbolic name regression introduced in:
https://github.com/puppetlabs/puppetlabs-concat/commit/eaf84079
2013-11-02 09:33:41 -07:00
Joshua Hoblitt
b6e9b1c693 fix or suppress all lint warnings 2013-11-01 18:52:59 -07:00
Joshua Hoblitt
e3b8452055 rename README.markdown -> README.md
For better consistency with other PuppetLabs' modules
2013-11-01 18:32:26 -07:00
Joshua Hoblitt
c73b019226 remove dead files 2013-11-01 18:32:02 -07:00
Joshua Hoblitt
256e0bdf9f remove usage of resource defaults for file owner/permissions
In addition, the permissions of the fragment directory and files is now fixed and not world readable.
2013-11-01 18:23:24 -07:00
Joshua Hoblitt
200e4ee205 always exec the concatfragments script as root when running as root
This is to allow the concatfragments script to be installed into a path that may not be accessible by a non-root user.
2013-11-01 18:23:24 -07:00
Ashley Penney
99250ed5f8 Merge pull request #90 from jhoblitt/deprecation_warnings
add deprecation warnings on removed parameters + warn on inclusion of co...
2013-11-01 10:25:45 -07:00
Joshua Hoblitt
7c4f929e42 add deprecation warnings on removed parameters + warn on inclusion of concat::setup 2013-10-30 22:06:02 -07:00
Joshua Hoblitt
4de578da6e Merge pull request #79 from luisfdez/feature/windows-support
Add Windows support
2013-10-29 06:41:56 -07:00