Joshua Hoblitt
b6e9b1c693
fix or suppress all lint warnings
2013-11-01 18:52:59 -07:00
Joshua Hoblitt
e3b8452055
rename README.markdown -> README.md
...
For better consistency with other PuppetLabs' modules
2013-11-01 18:32:26 -07:00
Joshua Hoblitt
c73b019226
remove dead files
2013-11-01 18:32:02 -07:00
Joshua Hoblitt
256e0bdf9f
remove usage of resource defaults for file owner/permissions
...
In addition, the permissions of the fragment directory and files is now fixed and not world readable.
2013-11-01 18:23:24 -07:00
Joshua Hoblitt
200e4ee205
always exec the concatfragments script as root when running as root
...
This is to allow the concatfragments script to be installed into a path that may not be accessible by a non-root user.
2013-11-01 18:23:24 -07:00
Ashley Penney
99250ed5f8
Merge pull request #90 from jhoblitt/deprecation_warnings
...
add deprecation warnings on removed parameters + warn on inclusion of co...
2013-11-01 10:25:45 -07:00
Joshua Hoblitt
7c4f929e42
add deprecation warnings on removed parameters + warn on inclusion of concat::setup
2013-10-30 22:06:02 -07:00
Joshua Hoblitt
4de578da6e
Merge pull request #79 from luisfdez/feature/windows-support
...
Add Windows support
2013-10-29 06:41:56 -07:00
Luis Fernandez Alvarez
99384037d6
Removed duplicated opts.separator call in concatfragments.rb
2013-10-28 09:03:30 +01:00
Luis Fernandez Alvarez
b09be245d4
Add Windows support
...
- It adds a ruby version of the bash script.
- Refactor setup.pp to include new variables.
- Generalizes command execution according to variables in setup.pp.
2013-10-25 14:47:03 +02:00
Joshua Hoblitt
b3438848c3
Merge pull request #78 from Paulche/stable_sort
...
Replace LANG => LC_COLLATE in concatfragments.sh
2013-10-24 14:42:07 -07:00
Paul Chechetin
ac9bb8d853
Replace LANG => LC_ALL
2013-10-25 01:16:05 +04:00
Ashley Penney
771173b890
Merge pull request #86 from jhoblitt/remove_ancient_cleanup
...
remove purging of /usr/local/bin/concatfragments.sh
2013-10-24 09:51:18 -07:00
Joshua Hoblitt
2ec19b80f9
remove purging of /usr/local/bin/concatfragments.sh
...
The hard coded path of `/usr/local/bin/concatfragments.sh` hasn't been
used for "a long time" so there's no reason to carry the cleanup around
any longer.
2013-10-24 09:34:31 -07:00
Ashley Penney
23f1d3b994
Merge pull request #85 from jhoblitt/remove_default_ownership
...
remove default owner/user and group values
2013-10-24 09:29:00 -07:00
Joshua Hoblitt
aa0180d69a
remove default owner/user and group values
...
The use of $::id to set the default user/owner and group has caused
multiple bugs in the past, is incorrectly used to infer the egid,
introduces a dependency on the `id` fact, and provides no functionally
that can't be accomplished by passing `undef` or not setting the
respective params on the file & exec types.
A possible alternative would be to introduce a dep on the $::gid fact
but that would mean the entire module would depend on a version of
facter than hasn't shipped yet (unworkable) or to add a gid/egid fact
into this module (ugly).
2013-10-24 08:48:37 -07:00
Ashley Penney
1ee9c5b98d
Merge pull request #84 from jhoblitt/backup_less
...
only backup target concat file + remove backup param from concat::fragme...
2013-10-23 16:19:32 -07:00
Joshua Hoblitt
4d884d3242
only backup target concat file + remove backup param from concat::fragment
...
Disable filebucket backup of all file resources except for the the
target file that's being concatenated.
2013-10-23 15:42:44 -07:00
Ashley Penney
94cbeca231
Merge pull request #83 from jhoblitt/param_validation
...
Param validation
2013-10-23 12:29:47 -07:00
Joshua Hoblitt
b6ee7e40e5
compatibility fixes for ruby 1.8.7 / puppet 2.7
2013-10-23 12:18:09 -07:00
Joshua Hoblitt
89dc9a9f71
mv spec/defines -> spec/unit/defines
...
To be more consistent with other PL modules
2013-10-23 10:57:03 -07:00
Joshua Hoblitt
4d7a915766
use $owner instead of $id to avoid confusion with $::id
2013-10-23 10:55:05 -07:00
Joshua Hoblitt
86522e1eb2
make class concat::setup a private class
2013-10-23 10:55:05 -07:00
Joshua Hoblitt
cca9401844
remove puppet 0.24 support
...
Introduction of stdlib functions makes support of puppet < 2.7
impractical.
2013-10-23 10:55:05 -07:00
Joshua Hoblitt
6e554e1a26
add stdlib to rspec-system tests
2013-10-23 10:55:05 -07:00
Joshua Hoblitt
d7498a4e25
add tests for class concat::setup
2013-10-23 10:55:05 -07:00
Joshua Hoblitt
7b992f79e3
validate define concat::fragment params
2013-10-23 10:55:01 -07:00
Joshua Hoblitt
eaf8407941
validate define concat params + split warn param
...
In addition, the warn param has been split into a warn (a bool) and
warn_message (a string).
2013-10-23 10:48:34 -07:00
Joshua Hoblitt
e4a53b6755
remove unused $gnu param from define concat
2013-10-22 09:27:53 -07:00
Ashley Penney
0ad32e46b3
Merge pull request #82 from jhoblitt/style_cleanups
...
improve whitespace consistency + remove semicolon resource compression
2013-10-22 09:17:31 -07:00
Joshua Hoblitt
987eaec7ab
improve whitespace consistency + remove semicolon resource compression
...
Per http://docs.puppetlabs.com/guides/style_guide.html#resources
resource compression with the "semicolon syntax" is now considered bad
practice.
2013-10-22 08:54:48 -07:00
Ashley Penney
44f4240286
Merge pull request #81 from songkick/fix-ownership
...
Fix group ownership on files.
2013-10-22 08:02:22 -07:00
Graham Bleach
fbb8f40594
Fix group ownership on files.
...
And add a test to stop it being broken again.
2013-10-22 12:36:19 +01:00
Ashley Penney
6f4aecf059
Merge pull request #80 from JustinHook/master
...
Added .gitattributes to maintain line endings for .sh files
2013-10-21 14:38:02 -07:00
Ashley Penney
dfcd0ca75a
Merge pull request #77 from jhoblitt/remove_manual_include_concat__setup
...
remove undocumented requirement to include concat::setup in manifest
2013-10-21 07:20:56 -07:00
JustinHook
acf67807e3
Added .gitattributes to maintain line endings for .sh files
2013-10-19 22:30:44 +01:00
Joshua Hoblitt
cdb6d6b007
remove undocumented requirement to include concat::setup in manifest
...
Unless the class `concat::setup` has been manually included into the
manifest before using the `concat` / `concat::fragment` defined types,
the puppet master will generate this warning while compiling the catalog.
Tue Oct 15 14:05:06 -0700 2013 Scope(Concat[/etc/exports]) (warning):
Could not look up qualified variable 'concat::setup::root_group'; class
concat::setup has not been evaluated
The need to `include concat::setup` directly into the manifest has never
been part of the documented API.
2013-10-17 15:07:57 -07:00
Ashley Penney
1e63ec4d83
Merge pull request #76 from Paulche/patch-1
...
Add Travis badge
2013-10-16 09:12:18 -07:00
Paul Chechetin
556702601f
Add Travis badge
...
Inspired by #75
2013-10-15 22:42:56 +04:00
Ashley Penney
721ce88738
Merge pull request #74 from petems/spec_refactor
...
Updated .gitignore for spec generated files
2013-10-02 06:42:02 -07:00
petems
c89863cf7c
Updated .gitignore for spec generated files
2013-10-02 13:53:00 +01:00
Ashley Penney
02b6d0b3b9
Merge pull request #73 from blewa/pluginsync_fix
...
Help message for pluginsync now references the correct section of the config
2013-09-30 09:17:23 -07:00
Aaron Blew
bb16039347
Help message for pluginsync now references the correct section of the config
2013-09-27 00:24:58 -07:00
Ashley Penney
bcf1f5407a
Merge pull request #39 from FredericLespez/master
...
Add an $ensure parameter to concat
2013-09-24 15:35:25 -07:00
Ashley Penney
6e5f029eef
Merge pull request #71 from apenney/fragments
...
Fragments
2013-09-24 15:07:16 -07:00
Ashley Penney
64c278490c
Ensure that ::setup runs before ::fragment in all cases.
2013-09-24 17:12:27 -04:00
Frédéric Lespez
d05da952ca
Add an ensure parameter to concat define
...
This parameter controls whether ressources associated to concat should be present or absent.
2013-08-19 16:19:57 +02:00
Hunter Haugen
04356974f7
Merge pull request #65 from apenney/100-release
...
Release 1.0.0.
2013-08-14 15:57:52 -07:00
Ashley Penney
8584aa9637
Release 1.0.0.
2013-08-14 18:50:04 -04:00
Hunter Haugen
562919fe09
Merge pull request #64 from apenney/100-release
...
Free volcane@ by giving him a sock.
2013-08-09 17:51:08 -07:00