only check some params if the "default" erb template is used. Also allow for "static" templates and files to be set in pace of "default" erb

Signed-off-by: Nick Chappell <nick@intronic.org>

Merged from: https://github.com/Icinga/puppet-icinga2/pull/35

refs#7628: https://dev.icinga.org/issues/7628
This commit is contained in:
Steven Bambling 2014-10-23 13:19:46 -04:00 committed by Nick Chappell
parent 46298909ed
commit e7710c6d2d

View file

@ -11,34 +11,38 @@
define icinga2::object::checkcommand ( define icinga2::object::checkcommand (
$object_checkcommandname = $name, $object_checkcommandname = $name,
$template_to_import = 'plugin-check-command', $template_to_import = 'plugin-check-command',
/* $methods = undef, */ /* Need to get more details about this attribute */ /* $methods = undef, */ /* Need to get more details about this attribute */
$command = undef, $command = undef,
$cmd_path = 'PluginDir', $cmd_path = 'PluginDir',
$arguments = {}, $arguments = {},
$env = undef, $env = undef,
$vars = {}, $vars = {},
$timeout = undef, $timeout = undef,
$target_dir = '/etc/icinga2/objects/checkcommands', $target_dir = '/etc/icinga2/objects/checkcommands',
$checkcommand_template_module = 'icinga2', $checkcommand_template_module = 'icinga2',
$checkcommand_template = 'object_checkcommand.conf.erb', $checkcommand_template = 'object_checkcommand.conf.erb',
$target_file_name = "${name}.conf", $checkcommand_source_file = undef,
$target_file_owner = 'root', $checkcommand_file_distribution_method = 'content',
$target_file_group = 'root', $target_file_name = "${name}.conf",
$target_file_mode = '0644' $target_file_owner = 'root',
$target_file_group = 'root',
$target_file_mode = '0644',
) { ) {
#Do some validation of the class' parameters: #Do some validation of the class' parameters:
validate_string($object_checkcommandname) validate_string($object_checkcommandname)
validate_string($template_to_import) if $checkcommand_template == 'object_checkcommand.conf.erb' {
validate_array($command) validate_string($template_to_import)
validate_string($cmd_path) validate_array($command)
if $env { validate_string($cmd_path)
validate_hash($env) if $env {
} validate_hash($env)
validate_hash($vars) }
if $timeout { validate_hash($vars)
validate_re($timeout, '^\d+$') if $timeout {
validate_re($timeout, '^\d+$')
}
} }
validate_string($target_dir) validate_string($target_dir)
validate_string($target_file_name) validate_string($target_file_name)
@ -47,13 +51,29 @@ define icinga2::object::checkcommand (
validate_re($target_file_mode, '^\d{4}$') validate_re($target_file_mode, '^\d{4}$')
file {"${target_dir}/${target_file_name}": if $checkcommand_file_distribution_method == 'content' {
ensure => file, file {"${target_dir}/${target_file_name}":
owner => $target_file_owner, ensure => file,
group => $target_file_group, owner => $target_file_owner,
mode => $target_file_mode, group => $target_file_group,
content => template("${checkcommand_template_module}/${checkcommand_template}"), mode => $target_file_mode,
notify => Service['icinga2'], content => template("${checkcommand_template_module}/${checkcommand_template}"),
notify => Service['icinga2'],
}
}
elsif $checkcommand_file_distribution_method == 'source' {
file {"${target_dir}/${target_file_name}":
ensure => file,
owner => $target_file_owner,
group => $target_file_group,
mode => $target_file_mode,
source => $checkcommand_source_file,
notify => Service['icinga2'],
}
}
else {
notify {'Missing/Incorrect File Distribution Method':
message => 'The parameter checkcommand_file_distribution_method is missing or incorrect. Please set content or source',
}
} }
} }