Merge pull request #137 from cmurphy/master

Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
This commit is contained in:
Morgan Haskel 2014-12-09 08:21:55 -08:00
commit 6b399c2bc6
4 changed files with 12 additions and 23 deletions

View file

@ -1,6 +1,6 @@
--- ---
language: ruby language: ruby
bundler_args: --without development bundler_args: --without system_tests
script: "bundle exec rake validate && bundle exec rake lint && bundle exec rake spec SPEC_OPTS='--format documentation'" script: "bundle exec rake validate && bundle exec rake lint && bundle exec rake spec SPEC_OPTS='--format documentation'"
matrix: matrix:
fast_finish: true fast_finish: true

View file

@ -41,8 +41,6 @@ Checklist (and a short version for the impatient)
* Pre-requisites: * Pre-requisites:
- Sign the [Contributor License Agreement](https://cla.puppetlabs.com/)
- Make sure you have a [GitHub account](https://github.com/join) - Make sure you have a [GitHub account](https://github.com/join)
- [Create a ticket](https://tickets.puppetlabs.com/secure/CreateIssue!default.jspa), or [watch the ticket](https://tickets.puppetlabs.com/browse/) you are patching for. - [Create a ticket](https://tickets.puppetlabs.com/secure/CreateIssue!default.jspa), or [watch the ticket](https://tickets.puppetlabs.com/browse/) you are patching for.
@ -94,17 +92,7 @@ The long version
whitespace or other "whitespace errors". You can do this by whitespace or other "whitespace errors". You can do this by
running "git diff --check" on your changes before you commit. running "git diff --check" on your changes before you commit.
2. Sign the Contributor License Agreement 2. Sending your patches
Before we can accept your changes, we do need a signed Puppet
Labs Contributor License Agreement (CLA).
You can access the CLA via the [Contributor License Agreement link](https://cla.puppetlabs.com/)
If you have any questions about the CLA, please feel free to
contact Puppet Labs via email at cla-submissions@puppetlabs.com.
3. Sending your patches
To submit your changes via a GitHub pull request, we _highly_ To submit your changes via a GitHub pull request, we _highly_
recommend that you have them on a topic branch, instead of recommend that you have them on a topic branch, instead of
@ -124,7 +112,7 @@ The long version
in order to open a pull request. in order to open a pull request.
4. Update the related GitHub issue. 3. Update the related GitHub issue.
If there is a GitHub issue associated with the change you If there is a GitHub issue associated with the change you
submitted, then you should update the ticket to include the submitted, then you should update the ticket to include the
@ -226,8 +214,6 @@ Additional Resources
* [Patchwork](https://patchwork.puppetlabs.com) * [Patchwork](https://patchwork.puppetlabs.com)
* [Contributor License Agreement](https://cla.puppetlabs.com/)
* [General GitHub documentation](http://help.github.com/) * [General GitHub documentation](http://help.github.com/)
* [GitHub pull request documentation](http://help.github.com/send-pull-requests/) * [GitHub pull request documentation](http://help.github.com/send-pull-requests/)

13
Gemfile
View file

@ -1,15 +1,18 @@
source ENV['GEM_SOURCE'] || "https://rubygems.org" source ENV['GEM_SOURCE'] || "https://rubygems.org"
group :development, :test do group :development, :unit_tests do
gem 'rake', :require => false gem 'rake', :require => false
gem 'rspec-puppet', :require => false gem 'rspec-puppet', :require => false
gem 'puppetlabs_spec_helper', :require => false gem 'puppetlabs_spec_helper', :require => false
gem 'serverspec', :require => false
gem 'puppet-lint', :require => false gem 'puppet-lint', :require => false
gem 'beaker', :require => false
gem 'beaker-rspec', :require => false
gem 'pry', :require => false
gem 'simplecov', :require => false gem 'simplecov', :require => false
gem 'puppet_facts', :require => false
gem 'json', :require => false
end
group :system_tests do
gem 'beaker-rspec', :require => false
gem 'serverspec', :require => false
end end
if facterversion = ENV['FACTER_GEM_VERSION'] if facterversion = ENV['FACTER_GEM_VERSION']

View file

@ -2,9 +2,9 @@ require 'puppetlabs_spec_helper/rake_tasks'
require 'puppet-lint/tasks/puppet-lint' require 'puppet-lint/tasks/puppet-lint'
PuppetLint.configuration.fail_on_warnings PuppetLint.configuration.fail_on_warnings
PuppetLint.configuration.send('relative')
PuppetLint.configuration.send('disable_80chars') PuppetLint.configuration.send('disable_80chars')
PuppetLint.configuration.send('disable_class_inherits_from_params_class') PuppetLint.configuration.send('disable_class_inherits_from_params_class')
PuppetLint.configuration.send('disable_class_parameter_defaults')
PuppetLint.configuration.send('disable_documentation') PuppetLint.configuration.send('disable_documentation')
PuppetLint.configuration.send('disable_single_quote_string_with_variables') PuppetLint.configuration.send('disable_single_quote_string_with_variables')
PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"] PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"]