From fff45971c87155d4c0e97c01cd83d5d7a8ef77b3 Mon Sep 17 00:00:00 2001 From: Helen Campbell Date: Mon, 18 Jul 2016 16:12:24 +0100 Subject: [PATCH] Additional tests - multiple ini settings creation --- .fixtures.yml | 1 + .gitignore | 3 ++- README.markdown | 2 ++ spec/classes/create_multiple_ini_settings_spec.rb | 5 +++++ .../manifests/init.pp | 15 +++++++++++++++ 5 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 spec/classes/create_multiple_ini_settings_spec.rb create mode 100644 spec/fixtures/create_multiple_ini_settings/manifests/init.pp diff --git a/.fixtures.yml b/.fixtures.yml index db98538..61abbcb 100644 --- a/.fixtures.yml +++ b/.fixtures.yml @@ -1,3 +1,4 @@ fixtures: symlinks: inifile: "#{source_dir}" + create_multiple_ini_settings: "#{source_dir}/spec/fixtures/create_multiple_ini_settings" diff --git a/.gitignore b/.gitignore index dd126f2..0cd25de 100644 --- a/.gitignore +++ b/.gitignore @@ -2,7 +2,8 @@ pkg/ Gemfile.lock vendor/ -spec/fixtures/ +spec/fixtures/manifests/ +spec/fixtures/modules/ .vagrant/ .bundle/ coverage/ diff --git a/README.markdown b/README.markdown index 80fba7b..627e422 100644 --- a/README.markdown +++ b/README.markdown @@ -449,6 +449,8 @@ Default value: '{}'. This module has been tested on [all PE-supported platforms](https://forge.puppetlabs.com/supported#compat-matrix), and no issues have been identified. Additionally, it is tested (but not supported) on Windows 7, Mac OS X 10.9, and Solaris 12. +Due to (PUP-4709) the create_ini_settings function will cause errors when attempting to create multiple ini_settings in one go when using Puppet 4.0.x or 4.1.x. If needed, the temporary fix for this can be found here: https://github.com/puppetlabs/puppetlabs-inifile/pull/196. + ##Development Puppet Labs modules on the Puppet Forge are open projects, and community contributions are essential for keeping them great. We can't access the huge number of platforms and myriad of hardware, software, and deployment configurations that Puppet is intended to serve. diff --git a/spec/classes/create_multiple_ini_settings_spec.rb b/spec/classes/create_multiple_ini_settings_spec.rb new file mode 100644 index 0000000..374557e --- /dev/null +++ b/spec/classes/create_multiple_ini_settings_spec.rb @@ -0,0 +1,5 @@ +require 'spec_helper' + +describe 'create_multiple_ini_settings' do + it { is_expected.to compile } +end diff --git a/spec/fixtures/create_multiple_ini_settings/manifests/init.pp b/spec/fixtures/create_multiple_ini_settings/manifests/init.pp new file mode 100644 index 0000000..b4595a9 --- /dev/null +++ b/spec/fixtures/create_multiple_ini_settings/manifests/init.pp @@ -0,0 +1,15 @@ +class create_multiple_ini_settings { + +$defaults = { 'path' => '/tmp/foo.ini' } +$example = { + 'section1' => { + 'setting1' => 'value1', + 'settings2' => { + 'ensure' => 'absent' + } + } +} +create_ini_settings($example, $defaults) + +} +