1106d70e88
This commit adds the ability to ensure that lines are absent.
510 lines
13 KiB
Ruby
510 lines
13 KiB
Ruby
require 'spec_helper'
|
|
require 'puppet'
|
|
|
|
provider_class = Puppet::Type.type(:ini_setting).provider(:ruby)
|
|
describe provider_class do
|
|
include PuppetlabsSpec::Files
|
|
|
|
let(:tmpfile) { tmpfilename("ini_setting_test") }
|
|
let(:emptyfile) { tmpfilename("ini_setting_test_empty") }
|
|
|
|
let(:common_params) { {
|
|
:title => 'ini_setting_ensure_present_test',
|
|
:path => tmpfile,
|
|
:section => 'section2',
|
|
} }
|
|
|
|
def validate_file(expected_content,tmpfile = tmpfile)
|
|
File.read(tmpfile).should == expected_content
|
|
end
|
|
|
|
|
|
before :each do
|
|
File.open(tmpfile, 'w') do |fh|
|
|
fh.write(orig_content)
|
|
end
|
|
File.open(emptyfile, 'w') do |fh|
|
|
fh.write("")
|
|
end
|
|
end
|
|
|
|
context "when ensuring that a setting is present" do
|
|
let(:orig_content) {
|
|
<<-EOS
|
|
# This is a comment
|
|
[section1]
|
|
; This is also a comment
|
|
foo=foovalue
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz=bazvalue
|
|
url = http://192.168.1.1:8080
|
|
[section:sub]
|
|
subby=bar
|
|
#another comment
|
|
; yet another comment
|
|
EOS
|
|
}
|
|
|
|
it "should add a missing setting to the correct section" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:setting => 'yahoo', :value => 'yippee'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file(<<-EOS
|
|
# This is a comment
|
|
[section1]
|
|
; This is also a comment
|
|
foo=foovalue
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz=bazvalue
|
|
url = http://192.168.1.1:8080
|
|
yahoo = yippee
|
|
[section:sub]
|
|
subby=bar
|
|
#another comment
|
|
; yet another comment
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should add a missing setting to the correct section with colon" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => 'section:sub', :setting => 'yahoo', :value => 'yippee'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file(<<-EOS
|
|
# This is a comment
|
|
[section1]
|
|
; This is also a comment
|
|
foo=foovalue
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz=bazvalue
|
|
url = http://192.168.1.1:8080
|
|
[section:sub]
|
|
subby=bar
|
|
#another comment
|
|
; yet another comment
|
|
yahoo = yippee
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should modify an existing setting with a different value" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:setting => 'baz', :value => 'bazvalue2'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should == 'bazvalue'
|
|
provider.value=('bazvalue2')
|
|
validate_file(<<-EOS
|
|
# This is a comment
|
|
[section1]
|
|
; This is also a comment
|
|
foo=foovalue
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz = bazvalue2
|
|
url = http://192.168.1.1:8080
|
|
[section:sub]
|
|
subby=bar
|
|
#another comment
|
|
; yet another comment
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should modify an existing setting with a different value - with colon in section" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => 'section:sub', :setting => 'subby', :value => 'foo'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should == 'bar'
|
|
provider.value.should == 'bar'
|
|
provider.value=('foo')
|
|
validate_file(<<-EOS
|
|
# This is a comment
|
|
[section1]
|
|
; This is also a comment
|
|
foo=foovalue
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz=bazvalue
|
|
url = http://192.168.1.1:8080
|
|
[section:sub]
|
|
subby = foo
|
|
#another comment
|
|
; yet another comment
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should be able to handle settings with non alphanumbering settings " do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:setting => 'url', :value => 'http://192.168.0.1:8080'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should == 'http://192.168.1.1:8080'
|
|
provider.value.should == 'http://192.168.1.1:8080'
|
|
provider.value=('http://192.168.0.1:8080')
|
|
|
|
validate_file( <<-EOS
|
|
# This is a comment
|
|
[section1]
|
|
; This is also a comment
|
|
foo=foovalue
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz=bazvalue
|
|
url = http://192.168.0.1:8080
|
|
[section:sub]
|
|
subby=bar
|
|
#another comment
|
|
; yet another comment
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should recognize an existing setting with the specified value" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:setting => 'baz', :value => 'bazvalue'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should == 'bazvalue'
|
|
end
|
|
|
|
it "should add a new section if the section does not exist" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => "section3", :setting => 'huzzah', :value => 'shazaam'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file(<<-EOS
|
|
# This is a comment
|
|
[section1]
|
|
; This is also a comment
|
|
foo=foovalue
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz=bazvalue
|
|
url = http://192.168.1.1:8080
|
|
[section:sub]
|
|
subby=bar
|
|
#another comment
|
|
; yet another comment
|
|
|
|
[section3]
|
|
huzzah = shazaam
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should add a new section if the section does not exist - with colon" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => "section:subsection", :setting => 'huzzah', :value => 'shazaam'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file(<<-EOS
|
|
# This is a comment
|
|
[section1]
|
|
; This is also a comment
|
|
foo=foovalue
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz=bazvalue
|
|
url = http://192.168.1.1:8080
|
|
[section:sub]
|
|
subby=bar
|
|
#another comment
|
|
; yet another comment
|
|
|
|
[section:subsection]
|
|
huzzah = shazaam
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should add a new section if no sections exists" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => "section1", :setting => 'setting1', :value => 'hellowworld', :path => emptyfile))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file("
|
|
[section1]
|
|
setting1 = hellowworld
|
|
", emptyfile)
|
|
end
|
|
|
|
it "should add a new section with colon if no sections exists" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => "section:subsection", :setting => 'setting1', :value => 'hellowworld', :path => emptyfile))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file("
|
|
[section:subsection]
|
|
setting1 = hellowworld
|
|
", emptyfile)
|
|
end
|
|
|
|
it "should be able to handle variables of any type" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => "section1", :setting => 'master', :value => true))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should == 'true'
|
|
provider.value.should == 'true'
|
|
end
|
|
|
|
end
|
|
|
|
context "when dealing with a global section" do
|
|
let(:orig_content) {
|
|
<<-EOS
|
|
# This is a comment
|
|
foo=blah
|
|
[section2]
|
|
foo = http://192.168.1.1:8080
|
|
; yet another comment
|
|
EOS
|
|
}
|
|
|
|
|
|
it "should add a missing setting if it doesn't exist" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => '', :setting => 'bar', :value => 'yippee'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file(<<-EOS
|
|
# This is a comment
|
|
foo=blah
|
|
bar = yippee
|
|
[section2]
|
|
foo = http://192.168.1.1:8080
|
|
; yet another comment
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should modify an existing setting with a different value" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => '', :setting => 'foo', :value => 'yippee'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should == 'blah'
|
|
provider.value.should == 'blah'
|
|
provider.value=('yippee')
|
|
validate_file(<<-EOS
|
|
# This is a comment
|
|
foo = yippee
|
|
[section2]
|
|
foo = http://192.168.1.1:8080
|
|
; yet another comment
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should recognize an existing setting with the specified value" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => '', :setting => 'foo', :value => 'blah'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should == 'blah'
|
|
end
|
|
end
|
|
|
|
context "when the first line of the file is a section" do
|
|
let(:orig_content) {
|
|
<<-EOS
|
|
[section2]
|
|
foo = http://192.168.1.1:8080
|
|
EOS
|
|
}
|
|
|
|
it "should be able to add a global setting" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => '', :setting => 'foo', :value => 'yippee'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file(<<-EOS
|
|
foo = yippee
|
|
[section2]
|
|
foo = http://192.168.1.1:8080
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should modify an existing setting" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => 'section2', :setting => 'foo', :value => 'yippee'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should == 'http://192.168.1.1:8080'
|
|
provider.value.should == 'http://192.168.1.1:8080'
|
|
provider.value=('yippee')
|
|
validate_file(<<-EOS
|
|
[section2]
|
|
foo = yippee
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should add a new setting" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => 'section2', :setting => 'bar', :value => 'baz'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file(<<-EOS
|
|
[section2]
|
|
foo = http://192.168.1.1:8080
|
|
bar = baz
|
|
EOS
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when overriding the separator" do
|
|
let(:orig_content) {
|
|
<<-EOS
|
|
[section2]
|
|
foo=bar
|
|
EOS
|
|
}
|
|
|
|
it "should fail if the separator doesn't include an equals sign" do
|
|
expect {
|
|
Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => 'section2',
|
|
:setting => 'foo',
|
|
:value => 'yippee',
|
|
:key_val_separator => '+'))
|
|
}.to raise_error Puppet::Error, /must contain exactly one/
|
|
end
|
|
|
|
it "should fail if the separator includes more than one equals sign" do
|
|
expect {
|
|
Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => 'section2',
|
|
:setting => 'foo',
|
|
:value => 'yippee',
|
|
:key_val_separator => ' = foo = '))
|
|
}.to raise_error Puppet::Error, /must contain exactly one/
|
|
end
|
|
|
|
it "should modify an existing setting" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => 'section2',
|
|
:setting => 'foo',
|
|
:value => 'yippee',
|
|
:key_val_separator => '='))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should == 'bar'
|
|
provider.value.should == 'bar'
|
|
provider.value=('yippee')
|
|
validate_file(<<-EOS
|
|
[section2]
|
|
foo=yippee
|
|
EOS
|
|
)
|
|
end
|
|
|
|
it "should add a new setting" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => 'section2',
|
|
:setting => 'bar',
|
|
:value => 'baz',
|
|
:key_val_separator => '='))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_nil
|
|
provider.create
|
|
validate_file(<<-EOS
|
|
[section2]
|
|
foo=bar
|
|
bar=baz
|
|
EOS
|
|
)
|
|
end
|
|
|
|
end
|
|
|
|
context "when ensuring that a setting is absent" do
|
|
let(:orig_content) {
|
|
<<-EOS
|
|
[section1]
|
|
; This is also a comment
|
|
foo=foovalue
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz=bazvalue
|
|
url = http://192.168.1.1:8080
|
|
[section:sub]
|
|
subby=bar
|
|
#another comment
|
|
; yet another comment
|
|
EOS
|
|
}
|
|
|
|
it "should remove a setting that exists" do
|
|
resource = Puppet::Type::Ini_setting.new(common_params.merge(
|
|
:section => 'section1', :setting => 'foo', :ensure => 'absent'))
|
|
provider = described_class.new(resource)
|
|
provider.exists?.should be_true
|
|
provider.destroy
|
|
validate_file(<<-EOS
|
|
[section1]
|
|
; This is also a comment
|
|
|
|
bar = barvalue
|
|
master = true
|
|
[section2]
|
|
|
|
foo= foovalue2
|
|
baz=bazvalue
|
|
url = http://192.168.1.1:8080
|
|
[section:sub]
|
|
subby=bar
|
|
#another comment
|
|
; yet another comment
|
|
EOS
|
|
)
|
|
end
|
|
end
|
|
|
|
end
|