Ensure the nginx::config::log_dir exists so that the access.log and error.log can be created. Also any nginx::vhost also put their access/error logs in this directory as well. This is done so that on platforms where /var/log/nginx is not created by package installation it exists so that nginx can startup and create the log files.
When vhost purge is enabled the log directory will not be touched and the log files will remain.
puppetlabs-apt 2.0.0 drops support in apt::source for key_source and required_packages.
* key_source will default to keyserver.ubuntu.com which carries both keys, so it
doesn't need to be explicitly defined
* required_packages can be emulated with the package resource
The big win is that it's now possible to test the future parser with the
latest Puppet release. In the past it wasn't possible to test future parser
with anything higher than 3.5.x.
Since commit 531ef9 of puppetlabs-apt, the gpg key (apt::key) is
checked, and should use the long format.
This value is validated with a regex enforcing it to only contain valid
hexadecimal characters, be precisely 8 or 16 hexadecimal characters long
and optionally prefixed with 0x for key IDs, or 40 hexadecimal
characters long for key fingerprints.
f588f2651a
The default value in nginx::config was the same as nginx's default,
so it's not necessary to be set in any version of nginx unless one
needs a specific value. This also allows us to use undef when we don't
want the directive to be set instead of false.
Also added a test for the default case.
The file wouldn't necessarily be at that location. According to Puppet it's installed in the first matching location:
* Custom directory specified by the ‘/etc/yum.conf’ reposdir property
* ‘/etc/yum/repos.d’
* ‘/etc/yum.repos.d’
* If none of these locations match, section will be created in ‘/etc/yum.conf’
* Removed some tests that no longer apply and/or are redundant
* Only set OS facts when testing OS-specific behaviors. This simplifies the
facts that must be set in the specs and saves running the same tests
several times when the results wouldn't differ by OS anyway.
* concat::fragment requires 'order' to be a string
* init parameters added in #373 referred to wrong variable name in params.pp
* cannot perform regex match on a number, so make {fastcgi,proxy}_cache_levels
a string by default
* bug fixed in test suite
Since librarian-puppet had locked to old versions of Forge modules
but puppetlabs_spec_helper is now pulling the latest version,
there's this incompatibility to take care of in the test suite.
This conversion is done by Transpec 2.3.4 with the following command:
transpec -c "rake spec" spec/classes/ spec/defines/ spec/spec_helper.rb
* 210 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 19 conversions
from: it { should_not ... }
to: it { is_expected.not_to ... }
* 15 conversions
from: == expected
to: eq(expected)
* 15 conversions
from: obj.should
to: expect(obj).to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
It should be possible to include array of arrays in order to have
duplicate configuration keys (when permitted), like:
nginx::http_cfg_append:
- [include, /etc/nginx/vhosts/*.ngx]
- [include, /etc/nginx/vhosts/*/*.ngx]
For some reason these have been broken forever. Travis was failing,
correctly. I have updated the tests to be correct to how the code
actually works.
I would also suggest that if this is merged, we stop merging PRs that
have failed test runs. Tests matter in a module like this.
