Set manage_pg_ident_conf to false for backward compatibility

I'd like to see this patch included ASAP -- the desirable default could
be manage_pg_ident_conf => true, but one could already manage this file
manually : we don't want to wipe it.

Please switch the default from false to true at the next major release
and write a line about this in the release notes.

README.md

@@ -476,7 +476,7 @@ This value defaults to `false`. Many distros ship with a fairly restrictive fire
 This value defaults to `true`. Whether or not manage the pg_hba.conf. If set to `true`, puppet will overwrite this file. If set to `false`, puppet will not modify the file.
 
 ####`manage_pg_ident_conf`
-This value defaults to `true`. Whether or not manage the pg_ident.conf. If set to `true`, puppet will overwrite this file. If set to `false`, puppet will not modify the file.
+This value defaults to `false`. Whether or not manage the pg_ident.conf. If set to `true`, puppet will overwrite this file. If set to `false`, puppet will not modify the file.
 
 ###Class: postgresql::client
 

manifests/params.pp

@@ -15,7 +15,8 @@ class postgresql::params inherits postgresql::globals {
   $service_provider           = $service_provider
   $manage_firewall            = $manage_firewall
   $manage_pg_hba_conf         = pick($manage_pg_hba_conf, true)
-  $manage_pg_ident_conf       = pick($manage_pg_ident_conf, true)
+  # TODO : the behavior of manage_pg_ident_conf should default to true in the next major relase, is now to false for backward compatibility (20140728)
+  $manage_pg_ident_conf       = pick($manage_pg_ident_conf, false)
   $package_ensure             = 'present'
 
   # Amazon Linux's OS Family is 'Linux', operating system 'Amazon'.

spec/unit/defines/server/pg_ident_rule_spec.rb

@@ -19,9 +19,12 @@ describe 'postgresql::server::pg_ident_rule', :type => :define do
     tmpfilename('pg_ident_rule')
   end
 
-  context 'test template 1' do
+  context 'managing pg_ident' do
     let :pre_condition do
       <<-EOS
+        class { 'postgresql::globals':
+          manage_pg_ident_conf => true,
+        }
         class { 'postgresql::server': }
       EOS
     end