Commit graph

996 commits

Author SHA1 Message Date
Hunter Haugen
a189ed7789 Merge pull request #560 from DECK36/master
Allowing validation of db connection for more than one user and port
2015-03-19 10:42:49 -07:00
Hunter Haugen
7018a5f5ad Merge pull request #582 from rvstaveren/rvstaveren-extension-postgresql_psql-fix
postgresql::server::extension needs to have defaults for postgresql_psql
2015-03-19 10:30:02 -07:00
Hunter Haugen
88dc7eeb6c Merge pull request #585 from backstop/master
Use space.  Join seems to be defaulting to comma.
2015-03-19 10:27:21 -07:00
Andreas Ntaflos
863a4b80de Fix setting postgres role password
Discussed in https://tickets.puppetlabs.com/browse/MODULES-1869

It seems env variables passed via `exec`'s `environment` parameter must
not be single-quoted, otherwise the single-quotes are interpreted
literally in the command strings in `command` and `unless`. For a
postgres password of `foobar` this leads to the `unless` code trying to
use literally `'foobar'` as password, and the `psql` line in `command`
setting literally `'$$foobar$$'` as password.
2015-03-19 03:16:27 +01:00
Travis Fields
0438db2f01 Merge pull request #588 from mhaskel/fix_for_586
Since this was in an osfamily block it was getting picked up on ubuntu
2015-03-18 08:38:13 -07:00
Morgan Haskel
72c6942759 Since this was in an osfamily block it was getting picked up on ubuntu
Fixes #586
2015-03-17 17:12:31 -07:00
Colleen Murphy
67577e8403 Merge pull request #587 from mhaskel/fix_postgresql_acceptance_tests
Fix acceptance tests for EL
2015-03-17 16:44:11 -07:00
Morgan Haskel
8053ea7232 Fix acceptance tests for EL
The return value of fact('selinux') is a stringified bool.
2015-03-17 16:35:31 -07:00
Morgan Haskel
57448a98f3 Merge pull request #583 from hunner/fix_4
Fix the handling of run_unless_sql_command in puppet 4
2015-03-17 15:10:43 -07:00
Morgan Haskel
0db1be08c1 Merge pull request #586 from raphink/dev/jessie
Adjust $service_status for Debian Jessie
2015-03-17 13:15:34 -07:00
Raphaël Pinson
3a2717111d Adjust $service_status for Debian Jessie 2015-03-17 16:20:27 +01:00
Ruben van Staveren
05c466c9d0 Provide postgresql_psql defaults for postgresql::server::initdb 2015-03-16 21:30:21 +01:00
Ruben van Staveren
977a7495f8 Fix indentation to 2 spaces 2015-03-16 21:22:08 +01:00
Ruben van Staveren
01b38f5bb4 postgresql::server::extension needs to have defaults for postgresql_psql
Using same pattern as with postgresql::server::database.
observed when installing the pg_trgm using pgsql 9.4
2015-03-16 21:22:07 +01:00
Kevin Wolf
fc580e1f93 Use space. Join seems to be defaulting to comma. 2015-03-16 13:56:44 -05:00
Hunter Haugen
8204bcdcaf Fix the handling of run_unless_sql_command in puppet 4
`Puppet::Util::SUIDManager.run_and_capture` (in puppet < 3.4) returns an
array of the output and the `Process::Status` object.
`Puppet::Util::Execution.execute` (in puppet >= 3.4) returns the output
and saves the `Process::Status` object to `$CHILD_STATUS`

This is handled in the provider, but the type was also trying to handle
it, and was not last updated when the provider was.
2015-03-13 15:20:27 -07:00
Morgan Haskel
7870b38db6 Merge pull request #584 from hunner/fix_spec
Fix specs for #567
2015-03-13 15:19:51 -07:00
Hunter Haugen
c323cea12a Fix specs for #567 2015-03-13 14:20:26 -07:00
Hunter Haugen
c58f327f46 Merge branch 'wavesoftware-feature/using-env-to-hide-dbpassword-in-output' 2015-03-12 10:59:38 -07:00
Hunter Haugen
6b8c3a9526 Don't make change to .gitignore
It will be stomped on by modulesync.

And remove trailing whitespace
2015-03-12 10:58:48 -07:00
Krzysztof Suszyński
a9b16b6ccf I've added some acceptance tests to 100% check that my method is valid and passwords ane not placed in report 2015-03-12 10:57:20 -07:00
Krzysztof Suszyński
5419384473 Fix for not running acceptance tests on CentOS box
This was caused by fact that SELinux is already disabled and `setenforce 0` returns 1 insted of 0 in that case.
2015-03-12 10:57:20 -07:00
Krzysztof Suszyński
cfbf2f9308 Using enviromental varables to hide actual password in psql commands displayed in output and reports. 2015-03-12 10:57:19 -07:00
Hunter Haugen
0f4c71850e Merge branch 'cwood-master' 2015-03-12 10:43:04 -07:00
Colin Wood
83b4ac1661 Allow management of logdir and add logdir parameter 2015-03-12 10:40:46 -07:00
Hunter Haugen
9e9aa9da85 Merge pull request #564 from antaflos/idempotency_for_grant_all_tables
Make granting on ALL TABLES IN SCHEMA idempotent
2015-03-12 10:28:34 -07:00
Hunter Haugen
a50a16d97d Merge pull request #580 from raphink/dev/replication
Replication type
2015-03-12 10:18:42 -07:00
Raphaël Pinson
76ab6f1160 Add a postgresql_replication_slot type 2015-03-12 18:14:58 +01:00
Morgan Haskel
d348cdb4b6 Merge pull request #579 from sathieu/template_encoding
(MODULES-1834) Be less strict when changing template1 encoding
2015-03-12 10:06:53 -07:00
JT (Jonny)
1f88cc3f93 Merge pull request #581 from mhaskel/merge_4.2.x_to_master
Merge 4.2.x to master
2015-03-11 16:35:26 +00:00
Mathieu Parent
f3a0db44ef (MODULES-1834) Be less strict when changing template1 encoding
We currently use: UTF8 != UTF-8
We should instead use: pg_char_to_encoding(UTF8) == pg_char_to_encoding(UTF-8)
2015-03-10 10:03:44 +01:00
JT (Jonny)
6c61f6cfac Merge pull request #578 from mhaskel/4.2.0-prep-pt2
Remove references to host parameter since the vote was to revert that
2015-03-10 08:48:16 +00:00
JT (Jonny)
f523a3e412 Merge pull request #577 from mhaskel/revert_host_param
Revert "(MODULES-661) Add host parameter to psql commands"
2015-03-10 00:23:19 +00:00
Morgan Haskel
33981b4032 Remove references to host parameter since the vote was to revert that 2015-03-09 17:21:40 -07:00
Morgan Haskel
8295b488cc Revert "(MODULES-661) Add host parameter to psql commands"
This reverts commit d92b2545e2.

Conflicts:
	spec/unit/puppet/provider/postgresql_psql/ruby_spec.rb
2015-03-09 17:00:06 -07:00
Travis Fields
62a774a90e Merge pull request #576 from mhaskel/4.2.0-prep
4.2.0 prep
2015-03-09 13:47:41 -07:00
Morgan Haskel
9236b21700 4.2.0 prep 2015-03-09 13:38:23 -07:00
Hunter Haugen
eaef089635 Merge pull request #574 from mhaskel/thankyou_geppetto
Rework defaults for `$object_name` in `postgresql::server::grant`
2015-03-09 09:50:05 -07:00
Morgan Haskel
154517aa32 There was a default case in the selector 2015-03-06 15:53:05 -08:00
Morgan Haskel
dcfe75eb95 Rework defaults for $object_name in postgresql::server::grant
You don't have access to parameters within the parameter list.
2015-03-06 15:49:07 -08:00
Colleen Murphy
317c146629 Merge pull request #573 from mhaskel/openbsd_support
Openbsd support
2015-03-06 14:39:56 -08:00
Morgan Haskel
1ca8ecda15 Merge pull request #561 from igalic/docs-current
doc links should point to /current/ rather than a specific version
2015-03-06 14:26:42 -08:00
Morgan Haskel
593e953bf7 Readme and test updates for service_reload parameter 2015-03-06 14:11:33 -08:00
Sebastian Reitenbach
ef1681f5e5 Changes to support OpenBSD.
Added $service_reload parameter to params.pp, in order to allow
a reload of the postgresql server on OpenBSD, which apparently doesn't
have a service binary.
2015-03-06 14:11:33 -08:00
Hunter Haugen
ab98ae34ce Merge pull request #572 from mhaskel/readme
README had outdated upgrade info
2015-03-06 13:52:27 -08:00
Morgan Haskel
a3d79445b0 README had outdated upgrade info
Info was on upgrading from 2.x->3.0, but this is 4.x.
2015-03-06 13:51:28 -08:00
Andreas Ntaflos
dbbb7aa2b3 Make granting on ALL TABLES IN SCHEMA idempotent
Define a proper SELECT statement to feed into Postgresql_psql's
`unless` parameter that checks if there are any tables in the specified
schema for which the specified role *does not* have the specified
privilege. Only then allow the GRANT statement to be executed. For
details see comments.

Note that this, too, suffers from the problem that there is no feasible
way to check if a role has ALL PRIVILEGES on a table in plain SQL. By
terrible convention the INSERT privilege represents ALL PRIVILEGES here.
2015-03-05 17:18:42 +01:00
TP Honey
4dbf624b2a Merge pull request #570 from petems/MAINT-fix-spec-describe
(MAINT) Fixes incorrect rspec it description
2015-03-04 18:25:30 +00:00
Peter Souter
d1c2144b74 (MAINT) Fixes incorrect rspec it description
Copy-paste error from before
2015-03-04 11:57:06 +00:00
Morgan Haskel
8b49b58f3c Merge pull request #568 from petems/MODULES-661-remote_postgres
(MODULES-661) Add host parameter to psql commands
2015-03-03 14:19:39 -08:00