(MODULES-1200) Fix inconsistent header across files

manifests/conf.pp

@@ -10,7 +10,7 @@ define apt::conf (
 
   file { "${apt_conf_d}/${priority}${name}":
     ensure  => $ensure,
-    content => $content,
+    content => template('apt/_header.erb', 'apt/conf.erb'),
     owner   => root,
     group   => root,
     mode    => '0644',

manifests/init.pp

@@ -92,7 +92,7 @@ class apt(
 
   file { '/etc/apt/apt.conf.d/15update-stamp':
     ensure  => 'file',
-    content => 'APT::Update::Post-Invoke-Success {"touch /var/lib/apt/periodic/update-success-stamp 2>/dev/null || true";};',
+    content => template('apt/_header.erb', 'apt/15update-stamp.erb'),
     group   => 'root',
     mode    => '0644',
     owner   => 'root',
@@ -144,7 +144,7 @@ class apt(
     true: {
       file { '99progressbar':
         ensure  => present,
-        content => 'Dpkg::Progress-Fancy "1";',
+        content => template('apt/_header.erb', 'apt/progressbar.erb'),
         path    => "${apt_conf_d}/99progressbar",
       }
     }
@@ -162,7 +162,7 @@ class apt(
     true: {
       file { '99unauth':
         ensure  => present,
-        content => "APT::Get::AllowUnauthenticated 1;\n",
+        content => template('apt/_header.erb', 'apt/unauth.erb'),
         path    => "${apt_conf_d}/99unauth",
       }
     }
@@ -188,7 +188,7 @@ class apt(
       file { '01proxy':
         ensure  => present,
         path    => "${apt_conf_d}/01proxy",
-        content => "Acquire::http::Proxy \"http://${proxy_host}:${proxy_port}\";\n",
+        content => template('apt/_header.erb', 'apt/proxy.erb'),
         notify  => Exec['apt_update'],
         mode    => '0644',
         owner   => root,

manifests/pin.pp

@@ -76,6 +76,6 @@ define apt::pin(
     owner   => root,
     group   => root,
     mode    => '0644',
-    content => template('apt/pin.pref.erb'),
+    content => template('apt/_header.erb', 'apt/pin.pref.erb'),
   }
 }

manifests/release.pp

@@ -12,6 +12,6 @@ class apt::release (
     owner   => root,
     group   => root,
     mode    => '0644',
-    content => "APT::Default-Release \"${release_id}\";"
+    content => template('apt/_header.erb', 'apt/release.erb'),
   }
 }

manifests/source.pp

@@ -44,7 +44,7 @@ define apt::source(
     owner   => root,
     group   => root,
     mode    => '0644',
-    content => template("${module_name}/source.list.erb"),
+    content => template('apt/_header.erb', 'apt/source.list.erb'),
     notify  => Exec['apt_update'],
   }
 

manifests/unattended_upgrades.pp

@@ -64,7 +64,7 @@ class apt::unattended_upgrades (
     owner   => 'root',
     group   => 'root',
     mode    => '0644',
-    content => template('apt/50unattended-upgrades.erb'),
+    content => template('apt/_header.erb', 'apt/50unattended-upgrades.erb'),
     require => Package['unattended-upgrades'],
   }
 
@@ -73,7 +73,7 @@ class apt::unattended_upgrades (
     owner   => 'root',
     group   => 'root',
     mode    => '0644',
-    content => template('apt/10periodic.erb'),
+    content => template('apt/_header.erb', 'apt/10periodic.erb'),
     require => Package['unattended-upgrades'],
   }
 }

spec/classes/apt_spec.rb

@@ -42,7 +42,7 @@ describe 'apt', :type => :class do
         'group' => 'root',
         'mode'  => '0644',
         'owner' => 'root',
-      }).with_content('APT::Update::Post-Invoke-Success {"touch /var/lib/apt/periodic/update-success-stamp 2>/dev/null || true";};')
+      }).with_content(/APT::Update::Post-Invoke-Success \{"touch \/var\/lib\/apt\/periodic\/update-success-stamp 2>\/dev\/null \|\| true";\};/)
     end
 
     it { should contain_file('old-proxy-file').that_notifies('Exec[apt_update]').only_with({
@@ -94,20 +94,20 @@ describe 'apt', :type => :class do
 
     it { should contain_file('99progressbar').only_with({
       'ensure'  => 'present',
-      'content' => 'Dpkg::Progress-Fancy "1";',
+      'content' => /Dpkg::Progress-Fancy "1";/,
       'path'    => '/etc/apt/apt.conf.d/99progressbar',
     })}
 
     it { should contain_file('99unauth').only_with({
       'ensure'  => 'present',
-      'content' => "APT::Get::AllowUnauthenticated 1;\n",
+      'content' => /APT::Get::AllowUnauthenticated 1;/,
       'path'    => '/etc/apt/apt.conf.d/99unauth',
     })}
 
     it { should contain_file('01proxy').that_notifies('Exec[apt_update]').only_with({
       'ensure'  => 'present',
       'path'    => '/etc/apt/apt.conf.d/01proxy',
-      'content' => "Acquire::http::Proxy \"http://foo:9876\";\n",
+      'content' => /Acquire::http::Proxy "http:\/\/foo:9876";/,
       'notify'  => 'Exec[apt_update]',
       'mode'    => '0644',
       'owner'   => 'root',

spec/classes/release_spec.rb

@@ -16,7 +16,7 @@ describe 'apt::release', :type => :class do
       "mode"    => "0644",
       "owner"   => "root",
       "group"   => "root",
-      "content" => "APT::Default-Release \"#{param_set[:release_id]}\";"
+      "content" => /APT::Default-Release "#{param_set[:release_id]}";/
     })
   }
 end

spec/defines/conf_spec.rb

@@ -19,7 +19,7 @@ describe 'apt::conf', :type => :define do
 
     it { should contain_file(filename).with({
           'ensure'    => 'present',
-          'content'   => "Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;\n",
+          'content'   => /Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;/,
           'owner'     => 'root',
           'group'     => 'root',
           'mode'      => '0644',
@@ -42,7 +42,7 @@ describe 'apt::conf', :type => :define do
 
     it { should contain_file(filename).with({
         'ensure'    => 'absent',
-        'content'   => "Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;\n",
+        'content'   => /Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;/,
         'owner'     => 'root',
         'group'     => 'root',
         'mode'      => '0644',

spec/defines/source_spec.rb

@@ -29,7 +29,7 @@ describe 'apt::source', :type => :define do
       'owner'  => 'root',
       'group'  => 'root',
       'mode'   => '0644',
-    }).with_content(/#file generated by puppet\n# my_source\ndeb-src  wheezy main\n/)
+    }).with_content(/# my_source\ndeb-src  wheezy main\n/)
     }
   end
 
@@ -65,7 +65,7 @@ describe 'apt::source', :type => :define do
       'owner'  => 'root',
       'group'  => 'root',
       'mode'   => '0644',
-    }).with_content(/#file generated by puppet\n# foo\ndeb \[arch=x86_64 trusted=yes\] http:\/\/debian\.mirror\.iweb\.ca\/debian\/ sid testing\n/).without_content(/deb-src/)
+    }).with_content(/# foo\ndeb \[arch=x86_64 trusted=yes\] http:\/\/debian\.mirror\.iweb\.ca\/debian\/ sid testing\n/).without_content(/deb-src/)
     }
 
     it { is_expected.to contain_apt__pin('my_source').that_comes_before('File[my_source.list]').with({
@@ -115,7 +115,7 @@ describe 'apt::source', :type => :define do
       'owner'  => 'root',
       'group'  => 'root',
       'mode'   => '0644',
-    }).with_content(/#file generated by puppet\n# my_source\ndeb \[trusted=yes\]  wheezy main\n/)
+    }).with_content(/# my_source\ndeb \[trusted=yes\]  wheezy main\n/)
     }
   end
 
@@ -140,7 +140,7 @@ describe 'apt::source', :type => :define do
       'owner'  => 'root',
       'group'  => 'root',
       'mode'   => '0644',
-    }).with_content(/#file generated by puppet\n# my_source\ndeb-src \[arch=x86_64 \]  wheezy main\n/)
+    }).with_content(/# my_source\ndeb-src \[arch=x86_64 \]  wheezy main\n/)
     }
   end
  

templates/15update-stamp.erb

@@ -0,0 +1 @@
+APT::Update::Post-Invoke-Success {"touch /var/lib/apt/periodic/update-success-stamp 2>/dev/null || true";};

templates/_header.erb

@@ -0,0 +1 @@
+# This file is managed by Puppet. DO NOT EDIT.

templates/conf.erb

@@ -0,0 +1 @@
+<%= @content -%>

templates/progressbar.erb

@@ -0,0 +1 @@
+Dpkg::Progress-Fancy "1";

templates/proxy.erb

@@ -0,0 +1 @@
+Acquire::http::Proxy "http://<%= @proxy_host %>:<%= @proxy_port %>";

templates/release.erb

@@ -0,0 +1 @@
+APT::Default-Release "<%= @release_id %>";

templates/source.list.erb

@@ -1,4 +1,3 @@
-#file generated by puppet
 # <%= @comment %>
 <%- if @include_deb then -%>
 deb <%- if @architecture or @trusted_source -%>

templates/unauth.erb

@@ -0,0 +1 @@
+APT::Get::AllowUnauthenticated 1;