From b2381c6673a8e86d38232bbef3276de0839b5d86 Mon Sep 17 00:00:00 2001 From: Morgan Haskel Date: Tue, 20 May 2014 16:24:28 -0400 Subject: [PATCH] Fixing lint and adding the trusty nodeset (not sure how that was missed) --- Rakefile | 6 ++++ manifests/init.pp | 2 +- manifests/ppa.pp | 2 +- manifests/unattended_upgrades.pp | 28 +++++++++---------- .../nodesets/ubuntu-server-1404-x64.yml | 11 ++++++++ 5 files changed, 33 insertions(+), 16 deletions(-) create mode 100644 spec/acceptance/nodesets/ubuntu-server-1404-x64.yml diff --git a/Rakefile b/Rakefile index 6d067dc..5868545 100644 --- a/Rakefile +++ b/Rakefile @@ -1,4 +1,10 @@ require 'puppetlabs_spec_helper/rake_tasks' require 'puppet-lint/tasks/puppet-lint' +PuppetLint.configuration.fail_on_warnings +PuppetLint.configuration.send('disable_80chars') +PuppetLint.configuration.send('disable_class_inherits_from_params_class') +PuppetLint.configuration.send('disable_class_parameter_defaults') +PuppetLint.configuration.send('disable_documentation') PuppetLint.configuration.send('disable_single_quote_string_with_variables') +PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"] diff --git a/manifests/init.pp b/manifests/init.pp index 48b62d1..5f5d0ac 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -134,7 +134,7 @@ class apt( owner => root, group => root, } - + file { 'old-proxy-file': ensure => absent, path => "${apt_conf_d}/proxy", diff --git a/manifests/ppa.pp b/manifests/ppa.pp index ab79b94..a55e1e0 100644 --- a/manifests/ppa.pp +++ b/manifests/ppa.pp @@ -15,7 +15,7 @@ define apt::ppa( } if $::operatingsystem != 'Ubuntu' { - fail("apt::ppa is currently supported on Ubuntu only.") + fail('apt::ppa is currently supported on Ubuntu only.') } $filename_without_slashes = regsubst($name, '/', '-', 'G') diff --git a/manifests/unattended_upgrades.pp b/manifests/unattended_upgrades.pp index c57a9ee..7e3ccc4 100644 --- a/manifests/unattended_upgrades.pp +++ b/manifests/unattended_upgrades.pp @@ -16,26 +16,26 @@ class apt::unattended_upgrades ( $origins = $::apt::params::origins, $blacklist = [], - $update = "1", - $download = "1", - $upgrade = "1", - $autoclean = "7", + $update = '1', + $download = '1', + $upgrade = '1', + $autoclean = '7', $auto_fix = true, $minimal_steps = false, $install_on_shutdown = false, - $mail_to = "NONE", + $mail_to = 'NONE', $mail_only_on_error = false, $remove_unused = true, $auto_reboot = false, - $dl_limit = "NONE", - $enable = "1", - $backup_interval = "0", - $backup_level = "3", - $max_age = "0", - $min_age = "0", - $max_size = "0", - $download_delta = "0", - $verbose = "0", + $dl_limit = 'NONE', + $enable = '1', + $backup_interval = '0', + $backup_level = '3', + $max_age = '0', + $min_age = '0', + $max_size = '0', + $download_delta = '0', + $verbose = '0', ) inherits ::apt::params { validate_bool( diff --git a/spec/acceptance/nodesets/ubuntu-server-1404-x64.yml b/spec/acceptance/nodesets/ubuntu-server-1404-x64.yml new file mode 100644 index 0000000..cba1cd0 --- /dev/null +++ b/spec/acceptance/nodesets/ubuntu-server-1404-x64.yml @@ -0,0 +1,11 @@ +HOSTS: + ubuntu-server-1404-x64: + roles: + - master + platform: ubuntu-14.04-amd64 + box : puppetlabs/ubuntu-14.04-64-nocm + box_url : https://vagrantcloud.com/puppetlabs/ubuntu-14.04-64-nocm + hypervisor : vagrant +CONFIG: + log_level : debug + type: git