Kaynağa Gözat

Merge pull request #505 from puppetlabs/install-lsb-release

Clear up lsb-release error
Morgan Haskel 9 yıl önce
ebeveyn
işleme
fe9741fe1d
3 değiştirilmiş dosya ile 4 ekleme ve 2 silme
  1. 2 0
      README.md
  2. 1 1
      manifests/params.pp
  3. 1 1
      spec/classes/params_spec.rb

+ 2 - 0
README.md

@@ -24,6 +24,8 @@ The apt module lets you use Puppet to manage Apt sources, keys, and other config
 
 Apt (Advanced Package Tool) is a package manager available on Debian, Ubuntu, and several other operating systems. The apt module provides a series of classes, defines, types, and facts to help you automate Apt package management.
 
+**Note**: For this module to be able to correctly auto detect which version of Debian/Ubuntu or derivative you're running you need to make sure the 'lsb-release' package is installed. We highly recommend making this part of your provisioning layer if you run many Debian or derivative systems or ensuring that you have at least Facter 2.2.0 installed which will pull in this dependency for you.
+
 ## Setup
 
 ### What apt affects

+ 1 - 1
manifests/params.pp

@@ -150,7 +150,7 @@ class apt::params {
       }
     }
     undef: {
-      fail('Unable to determine lsbdistid, is lsb-release installed?')
+      fail('Unable to determine lsbdistid, please install lsb-release first')
     }
     default: {
       $ppa_options = undef

+ 1 - 1
spec/classes/params_spec.rb

@@ -19,7 +19,7 @@ describe 'apt::params', :type => :class do
     it do
       expect {
         subject.call
-      }.to raise_error(Puppet::Error, /Unable to determine lsbdistid, is lsb-release installed/)
+      }.to raise_error(Puppet::Error, /Unable to determine lsbdistid, please install lsb-release first/)
     end
   end