Commit graph

289 commits

Author SHA1 Message Date
innyso
1a3d6625f4 Allow url or domain name for key_server parameter
As some places dont have port 11371 open, they are required to use URL as
key_server instead of domain name therefore adding the capability to use URL or
domain name as key_server parameter
2014-06-02 18:05:20 +01:00
Morgan Haskel
b2381c6673 Fixing lint and adding the trusty nodeset (not sure how that was missed) 2014-05-20 16:24:28 -04:00
François Conil
1891912f84 Fixed regex to actually follow APT requirements
Previous implementation would overwrite the file name and
potentially include characters that would cause apt to ignore
the pref file
2014-05-19 15:33:06 +10:00
Morgan Haskel
0da464de35 Merge pull request #287 from oc243/master
Implement fancy progress bars configuration.
2014-05-15 13:45:46 -04:00
Oliver Chick
2cdcd3b06d Implement fancy progress bars configuration.
Ubuntu 14.04 ships with apt 0.9.15, has a ``fancy progress bar'', which
is a green bar that shows at the bottom of the terminal showing progress
throughout install.

This patch enables the progress bar, which is usually done by running
echo 'Dpkg::Progress-Fancy "1";' > /etc/apt/apt.conf.d/99progressbar
2014-05-14 12:02:37 +01:00
Daniel Paulus
ee0233066e Some code cleaning 2014-05-05 12:06:39 +02:00
Daniel Paulus
e337a24389 Remove the preference file for all supported platforms when in purge mode 2014-05-02 23:35:54 +02:00
Daniel Paulus
d3d6fde6e7 Do not add bogus line to apt preference file on Debian Wheezy 2014-05-02 17:56:06 +02:00
Johan Fleury
9e789255c8 Writing proxy configuration in apt.conf.d/01proxy.
This commit changes the proxy file name to be more consistent with other files
in `apt.conf.d`. The old file (`apt.conf.d/proxy`) is removed.

Tests has been updated.
2014-04-11 13:56:29 +02:00
Ashley Penney
dfa3a62bd8 Merge pull request #280 from daenney/fix-pin-comments
Fix pin comments
2014-04-03 13:59:51 -04:00
Daniele Sluijters
fefd530362 unattended-upgrades: Fix origins for Squeeze.
Because Squeeze is now oldstable we need to add an oldstable line too
otherwise security updates won't be picked up. This is still because we
can't match on codename.
2014-04-02 11:17:04 +02:00
Daniele Sluijters
13788395e6 pin: caller_module_name is not a topscope variable 2014-03-28 08:49:18 +01:00
Ashley Penney
553611b16b Small patch to fix the spacing that makes lint fail. 2014-03-27 16:40:36 +00:00
Daniele Sluijters
eaebe2f82d unattended_upgrades: Fix matching security archive
The default configuration we were writing for Debian was only working
for Squeeze, from Wheezy and onwards this wasn't working anymore. This
has to do with the fact that we should now be using Origins-Pattern
according to the unattended-upgrades docs. However, Ubuntu didn't
entirely get with the program yet...

This change reflects the defaults that unattended-upgrade installs on
every platform we support. In order to do so the unattended-upgrades
Debian archive for Squeeze, Wheezy, Lucid, Precise and Trusty were
downloaded and the default /etc/apt/apt.conf.d/50unattended-upgrades
checked for its content with regard to using Allow-Origins or
Origins-Pattern.

Fixes #277
2014-03-27 13:56:25 +01:00
Daniele Sluijters
ed52e513db backports: Allow setting a custom priority.
The module used to always pin backports to a priority of 200. This
default is still retained but is now configurable.

Additionally the default is now an Integer, not a 'quoted Integer' and
the tests have been updated to reflect this. This matters for future
parser as it will now kick people if they pass in a stringified integer
as priority.
2014-03-26 19:10:37 +01:00
Frédéric DROUET
f546dc2d37 Fix typo in ppa.pp 2014-03-20 23:09:07 +01:00
Hunter Haugen
6691c2fade Merge pull request #248 from electrical/fix_params_fail
Fix fail message
2014-03-07 10:00:58 -08:00
Richard Pijnenburg
4d0bf7cbab Fail early when its not debian or ubuntu ( or debian like distro ) 2014-03-07 16:03:44 +01:00
Ian Unruh
7b932be82c Updated documentation 2014-03-05 16:01:37 -06:00
Ian Unruh
824da679d4 Added retry to update operation 2014-03-05 15:59:21 -06:00
Hunter Haugen
a35c30fe4b Merge pull request #209 from pabl0/proxy
Make apt.conf.d/proxy world readable and add a newline
2014-03-05 11:15:26 -08:00
Hunter Haugen
de095a173f Merge pull request #249 from ghoneycutt/define_apt_source_in_hiera
Add ability to specify hash of apt sources in hiera
2014-03-05 11:06:43 -08:00
Ashley Penney
c8c7659b0b Merge pull request #258 from sodabrew/patch-1
Add Ubuntu Trusty
2014-03-05 13:17:12 -05:00
Ashley Penney
3917e080f3 Merge pull request #259 from daenney/apt-hold
apt::hold: Add a mechanism to hold a package.
2014-03-05 13:16:38 -05:00
Daniele Sluijters
b560fa265f pin: Replace invalid chars with _ in file names.
This needs to be merged for #259 to work.
2014-03-05 19:11:13 +01:00
Daniele Sluijters
519babcfb6 apt::hold: Add a mechanism to hold a package.
I am aware this can be done with `dpkg --set-selections`, `apt-mark`
or `ensure => 'held'` on a package resource. The changes to the README
include the full rationale for wanting another mechanism.
2014-03-05 10:13:42 +01:00
Aaron Stone
f110d4a366 Oneiric is available on the old-releases mirror 2014-03-04 12:51:32 -08:00
Aaron Stone
62ea527c3e Remove hardy, maverick, natty
They are not on the mirrors anymore.
2014-03-04 12:50:37 -08:00
Aaron Stone
cba6bb4a42 Add Ubuntu Trusty
It's in Beta now and has landed on the main mirrors.
2014-03-04 12:46:27 -08:00
Daniele Sluijters
5790341890 apt:🔑 Redo apt::key, make it use apt_key.
Introducing a totally rewritten and tested apt::key. This commit also
patches the spec's of apt::source because it was passing in data that
is no longer allowed by the new validation rules in apt::key.

It does its best to not touch any other specs and where we touch them
only minimally to ensure that we're not introducing breaking changes.
2014-03-04 16:39:58 +01:00
Daniel Tremblay
46606c9a2b Add ability to specify hash of apt sources in hiera
This patch uses create_resources() to call apt::source which lets you
specify your sources in hiera.
2014-02-26 09:15:37 -05:00
Richard Pijnenburg
95c0634897 Fix fail message
the fail message was including a fact that was not used in the whole case statement and caused some confusion.
2014-02-26 11:52:54 +01:00
Henrik Ahlgren
eb40a7ae78 Make apt.conf.d/proxy world readable and add a newline 2014-02-25 19:57:10 +02:00
Hunter Haugen
1853951c0f Merge pull request #226 from mark0n/master
Update out of date Debian signing key for backports
2014-02-25 09:34:00 -08:00
Hunter Haugen
0e82e5498f Merge pull request #215 from lotherk/proxy_val_no_boolean
changed proxy_host default value from true to undef. fixes #211
2014-02-25 09:32:12 -08:00
Hunter Haugen
4c9174e517 Merge pull request #227 from daniellawrence/file_perms_apt_ppa
Force owner and mode on ppa files
2014-02-25 09:30:37 -08:00
Hunter Haugen
01cff19fa8 Merge pull request #240 from daenney/manage-preferences
apt: Allow managing of preferences file.
2014-02-25 09:25:49 -08:00
Ashley Penney
0a93286ff8 Merge pull request #241 from hunner/add_unsup
Add non Debian os family unsupported test.
2014-02-24 16:53:41 -05:00
Hunter Haugen
f6816c6bb3 Add non Debian os family unsupported test. 2014-02-24 13:52:13 -08:00
Hunter Haugen
944f9d5064 Merge branch '1.4.x' 2014-02-24 13:36:48 -08:00
Daniele Sluijters
2ca97c8210 apt: Allow managing of preferences file.
We already had a feature to manage and purge entries in preferences.d
but not the preferences file in /etc/apt. This commit adds that
capability.

Fixes #199
2014-02-22 11:00:22 +01:00
Hunter Haugen
8453d40138 Missed the - for -y, but also tests were missing lsbdistid 2014-02-21 09:34:46 -08:00
Hunter Haugen
904fb4a293 Don't pass options to ppa on lucid
Lucid (10.04) has `add-apt-repository` but it doesn't accept any
options. The define defaulted to `-y` but this changes that on lucid.

This was made 7 months ago, so apparently no one cares about 10.04 any
more.
2014-02-20 16:43:48 -08:00
Daniel Lawrence
0bf44fc167 Force owner and mode on ppa files 2014-02-19 11:41:01 +11:00
Martin Konrad
3aa293a53f Update out-of-date Debian signing key in remaining files. 2014-02-18 16:57:01 -05:00
Martin Konrad
d5efdf0016 Update Debian signing key for backports. 2014-02-18 13:37:05 -05:00
Daniele Sluijters
ef7d149d5a apt::pin: Allow for packages to be an array. 2014-02-16 14:51:39 +01:00
Hunter Haugen
4b8aa9e55a Revert "Undo backwards-incompatible changes and features."
This reverts commit f9e2fe2a7c.
2014-02-14 14:49:43 -08:00
Hunter Haugen
f9e2fe2a7c Undo backwards-incompatible changes and features.
Undoes the parameter changes in #140 and #184
2014-02-14 14:33:30 -08:00
Konrad Lother
0207fcd19a changed proxy_host default value from false to undef. fixes #211 2014-01-30 00:55:22 +01:00
Ashley Penney
558954bedf Ensure apt::ppa fails on non-Ubuntu. 2014-01-09 14:35:17 -05:00
Tsuharesu Luciel
2f6edabc4c (#201) Use root to exec
User root is needed to execute this command.

If someone changes the default Exec user, apt-add-repository will fail.
2013-12-30 16:01:56 -02:00
Marco Nenciarini
935d3ce15b Fix the name of sources.list.d file resource in apt::ppa 2013-12-02 13:40:22 +01:00
Ashley Penney
b549f7b848 Merge pull request #184 from RsrchBoy/topic/removable-ppas
add an 'ensure' parameter to apt::ppa
2013-11-18 14:51:45 -08:00
Erik Dalén
7a8e3d00f9 Retry package installs
Sometimes package installs can fail to aquire the lock file, so retry
the command in that case.
2013-11-14 11:02:18 +01:00
Chris Weyl
3499896505 add an 'ensure' parameter to apt::ppa
...as sometimes we want to get rid of them. :)

We leave this a little loose; rather than simply requiring a boolean for
$ensure, we set the stage for doing an easy switch to also allowing 'purge' at
some point in the future.
2013-11-08 16:54:11 -08:00
Ashley Penney
33064128b9 getparam() isn't available in all stdlib versions.
There's no need for getparam() here when a regular variable works
just fine.
2013-10-16 13:08:03 -04:00
Ashley Penney
d1e87d4774 Merge pull request #140 from hunner/apt_force
Handling of release parameter and apt provider in force manifest
2013-10-15 10:45:17 -07:00
Ashley Penney
39cbeeb9d2 This work flips from onlyif to unless (mistakenly looked at the
wrong return code).
2013-10-08 10:50:30 -07:00
Ashley Penney
2f9c16a273 This switches us to doing a test -s instead of checking for the
files existence as add-apt-repository --remove leaves a 0 byte file
behind instead of deleting everything properly.
2013-10-02 14:46:00 -04:00
Edwin Hermans
c07ab505c1 add an updates_timeout option to apt::params (PR fix) 2013-10-02 14:24:30 +02:00
Dan Carley
dc88fe6ef6 [#153] Install unattended configs after package
To ensure that the default configs from the package are always overwritten
within a single Puppet run.
2013-09-16 13:57:44 +01:00
Dan Carley
ea40999381 [#153] Convert t/f params to bools and validate
Per lint check: http://puppet-lint.com/checks/quoted_booleans/
2013-09-16 09:06:15 +01:00
Dan Carley
2fea399a09 [#153] Rename unattended_upgrades s/-/_/
It's preferable to use underscores rather than hyphens in class names. Refs:

- http://projects.puppetlabs.com/issues/5268
- http://docs.puppetlabs.com/puppet/3/reference/lang_reserved.html#classes-and-types
2013-09-16 08:53:01 +01:00
Philip Cohoe
df3ba6469c Added class for managing unattended-upgrades 2013-09-10 18:36:30 +00:00
Ryan Culbertson
e97942f2d6 Fixed several lint warnings and errors 2013-09-04 17:32:42 -04:00
Hunter Haugen
c0872c04a9 Merge pull request #150 from bionix/use_http_debian_net_as_geodns_redirector
Use the geoDNS http.debian.net instead of the main debian ftp server
2013-08-05 13:59:19 -07:00
Markus Rekkenbeil
5af4667f32 Use the geoDNS http.debian.net instead of the main debian ftp server
Signed-off-by: Markus Rekkenbeil <markus@bionix-it.de>
2013-08-05 13:19:50 +02:00
Markus Rekkenbeil
a1a677da66 Add wheezy backports support
Signed-off-by: Markus Rekkenbeil <markus@bionix-it.de>
2013-08-05 13:06:54 +02:00
Hunter Haugen
6cde028332 Merge pull request #145 from PierreGambarotto/master
ppa: fix empty environment definition in exec ressource when no proxy
2013-07-31 09:32:27 -07:00
nagas
63a0db4cf2 pass flags as string of single letter 2013-07-22 14:48:32 +02:00
Oleiade
878bc0217e Fix: apt::ppa options parameter to pass options to apt-add-repository command 2013-07-16 15:31:19 +02:00
Pierre Gambarotto
19fbdab794 ppa: fix empty environment definition in exec ressource when no proxy 2013-07-16 09:52:06 +02:00
Pierre Gambarotto
c21730c01d proxy support for apt::ppa 2013-07-11 15:29:38 +02:00
Andreas Teuchert
5f618da4bd Don't use hardcoded provider in force manifest.
Use $apt::params::provider instead.
2013-07-03 10:36:48 -07:00
Andreas Teuchert
9a968bbead Handle release parameter more sensibly in force manifest.
Use release parameter to construct $release_string.

The release parameter may also be set to false to use the system's
default release (so just force a specific version). Use false as the
default setting instead of 'testing'.

Change $install_check to also check if package is installed from the
right release, instead of just checking the version.
2013-07-03 10:36:15 -07:00
Hunter Haugen
9568ecf26d Merge pull request #134 from spali/my_changes
replace aptitude with apt in apt::force
2013-07-02 13:54:12 -07:00
Hunter Haugen
6f68c5180c Merge pull request #114 from johnnyrun/master
location change
2013-07-02 11:53:14 -07:00
Hunter Haugen
46d47f79d2 Merge pull request #118 from opeckojo/apt-sources-arch
Add optional architecture qualifier to apt-sources
2013-07-02 11:48:06 -07:00
Hunter Haugen
91d917495e Merge pull request #123 from ctrlaltdel/fix-required-packages
Install required_packages before 'apt-get update'
2013-07-02 11:37:39 -07:00
Hunter Haugen
add5060d64 Merge pull request #122 from strangeman/master
Add a $key_options parameter to apt::key.
2013-07-02 11:34:21 -07:00
Hunter Haugen
c00888f6d0 Merge pull request #131 from mbornoz/apt-preferences
apt::pin: handling all apt preferences properties
2013-07-01 17:46:24 -07:00
Hunter Haugen
84f1cfca0d Revert "Merge pull request #135 from CERIT-SC/master"
This reverts commit e17208a86c, reversing
changes made to 0665a5d77a.
2013-07-01 17:19:27 -07:00
Hunter Haugen
e17208a86c Merge pull request #135 from CERIT-SC/master
Support APT pinning by codename
2013-07-01 16:55:57 -07:00
Benjamin Knofe
733ece66e7 apt:🔑 trim keys to 8 chars to match with apt-key list, refs puppetlabs/puppetlabs-apt#100 2013-06-29 13:06:26 +02:00
Vlastimil Holer
3191f0552a Support APT pinning by codename (e.g. squeeze, wheezy) 2013-06-28 14:06:05 +02:00
Thomas Spalinger
ca810b37c6 Merge branch 'master' into my_changes 2013-06-25 22:53:14 +02:00
Raphaël Pinson
e8f11eac01 Fix apt::pin for Puppet 2.6 2013-06-18 15:14:00 +02:00
Mathieu Bornoz
414c57926c apt::pin: handling all apt preferences properties
The two forms of APT preferences records (general & specific) can now be
completely and not partially defined. All distribution properties can be passed
as resource parameters. This change is totally backward-compatible.
2013-06-18 11:31:38 +02:00
Francois Deppierraz
37a0dcd0b6 Install required_packages before 'apt-get update'
This is necessary when required_packages contains GPG keys that are used for
authenticating other packages. Tested with package ubuntu-cloud-keyring which
is included in Ubuntu main and used by the Ubuntu Cloud Archive.

I think the same problem applies to other *-keyring packages as well.
2013-06-03 09:57:58 +00:00
Markelov Anton
6283f6cf72 Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-apt
Conflicts:
	.travis.yml
	Modulefile
2013-06-03 10:10:03 +11:00
Joe O'Pecko
b3d67c8937 Add optional architecture qualifier to apt-sources 2013-06-02 11:55:36 -07:00
Scott Barber
041548bcbe Update manifests/init.pp 2013-06-02 18:51:27 +01:00
Scott Barber
f985752a1a Update manifests/init.pp 2013-06-02 18:51:27 +01:00
Scott Barber
1b07921c0c Update manifests/init.pp
If a proxy is set and then later unset we need to remove the proxy file. As it currently sits it'll just sit there hanging out.
2013-06-02 18:51:27 +01:00
johnnyrun
256c90e0fd Location changed:
http://backports.debian.org/news/Backports_integrated_into_the_main_archive/
2013-05-07 14:13:59 +02:00
Thomas Spalinger
7b5d30ed18 replace aptitude with apt in apt::force 2013-02-26 21:35:49 +01:00
Michael Moll
eee5ff8e38 whitespace fixes 2013-01-12 00:21:39 +01:00
Chris Rutter
c58d19f29a minor punctuation and quotation corrections in comments 2012-12-31 00:22:45 +00:00
Chris Rutter
5cdf186c45 fix minor comment typo 2012-12-31 00:16:29 +00:00
Jarl Nicolson
ac86fab459 Changed PPA manifest and tests for new package which started in Quantal 2012-11-05 19:33:38 +10:00
Erik Dalén
75092fdbf1 (#16076) Ability to fill in pin explanation
Adds the ability to fill it in and sets a reasonable default.
2012-10-25 15:44:20 -04:00
Markelov Anton
34f31ef4d9 Merge remote-tracking branch 'upstream/master' 2012-10-22 17:06:04 +11:00
Branan Purvine-Riley
bd68302783 Merge pull request #83 from dalen/pin_order
(#16070) Allow optional order parameter to apt::pin
2012-10-18 16:45:15 -07:00
Markelov Anton
00155ccf1b Add a $key_options parameter, which need to work apt-key via proxy. 2012-10-11 17:37:15 +11:00
Erik Dalén
40f8755217 (#16070) Allow optional order parameter to apt::pin
As the apt pinnings are parsed in ascending alphabetical order with
first match wins within a given scope it is useful to be able to specify
a ordering parameter. Then the name parameter can be kept to something
meaningful.
2012-08-23 11:25:17 +02:00
Dan Bode
f3d84c6744 Merge pull request #84 from dalen/pin_version
(#16075) Allow pinning on version numbers
2012-08-22 06:55:00 -07:00
Dan Bode
62d4557db6 Merge pull request #79 from sathlan/feature/apt-force-timeout
Add a way to specify a timeout for the apt::force define.
2012-08-22 06:47:01 -07:00
Dan Bode
32d312ea41 Merge pull request #78 from saz/source-remove-release
remove check, if $release is empty
2012-08-22 06:46:36 -07:00
Erik Dalén
14b2eb1ca0 (#16075) Allow pinning on version numbers
This is needed to be able to produce the following pinning from
apt_preferences(5):

Package: perl
Pin: version 5.8*
Pin-Priority: 1001
2012-08-22 10:11:48 +02:00
Erik Dalén
a3d782c3b5 Fix style errors 2012-08-21 22:55:24 +02:00
Steffen Zieger
d49dbb49ae fix check of release parameter 2012-07-10 01:39:53 +02:00
sathlan
fcb90f7b6c Add a way to specify a timeout for the apt::force define. 2012-07-09 05:24:49 +03:00
Jonathan Araña Cruz
145a2853d4 Add «main» to Ubuntu backports repos. 2012-06-29 13:15:13 +02:00
ytjohn
3adb53c4a6 Without puppetlabs/stdlib, you will get "err: Could not retrieve catalog from remote server: Error 400 on SERVER: Unknown function validate_bool" 2012-06-13 18:48:58 -03:00
Anton Lindström
74959d8f8e fix scoping of $lsbdistcodename in source.pp
Current unscoped variable yields deprecation warning:
warning: Dynamic lookup of $lsbdistcodename at
[..]/apt/manifests/source.pp:7 is deprecated.
2012-06-12 09:56:19 +02:00
Nan Liu
2dcec036ca Add logoutput on_failure for all exec resources.
We need more information to debug issues on exec failure. This change
enables logouput => on_failure.
2012-06-07 14:53:41 -07:00
Branan Purvine-Riley
bf1bb27998 Remove a trailing comma to fix older puppets 2012-05-25 12:38:53 -07:00
Roman Skvazh
f5b3c5bcdf Add functionality to pin source with originator "release o=..."
If you need to pin certain Launchpad PPA (ppa:rskvazh/php), you may do:
apt::pin { 'my-launchpad-repo':
   priority      => 700,
   originator  =>'LP-PPA-rskvazh-php',
}
2012-05-24 13:46:00 +04:00
James Turnbull
5f1cf4a245 Merge pull request #61 from xaque208/pin_origin
Pin origin
2012-05-23 10:17:31 -07:00
Branan Purvine-Riley
83e20806b2 (#14657) Fix filename when there is a period in the PPA 2012-05-22 17:22:18 -07:00
Zach Leslie
836f16e946 add .pref extension, which according to apt_preferences(5) may or may not be present, and is helpful if you are going to have an extension at all 2012-05-21 17:06:10 -07:00
Zach Leslie
f0d18b6ed7 use variable from params and also validate the purge_preferences_d 2012-05-21 15:56:29 -07:00
Zach Leslie
cfb6a35603 allow for purging preferences 2012-05-21 15:51:33 -07:00
Zach Leslie
6e9232a627 align = 2012-05-21 15:48:00 -07:00
Zach Leslie
3ac02c5c42 Preserve backwards compatibility 2012-05-21 15:03:30 -07:00
Zach Leslie
5d94369f15 pass ensure through so that we can remove pin prefs too 2012-05-21 14:52:36 -07:00
Zach Leslie
d28de44266 move pin out to a template 2012-05-21 14:49:30 -07:00
Zach Leslie
2d19d8664e Add functionality to support apt pinning to more than just the release.
Write the pin preference filename as ${name} rather than ${release}, so
that we can pin more than one thing.

Change apt::source so that when pin is set, that it pins to the origin
rather than the release.
2012-05-21 14:19:18 -07:00
Zach Leslie
989b95a12d Fixup name issue with apt::backports
The '.list' is not needed since the apt::source type handles this.
White space alignment.
2012-05-21 14:17:37 -07:00
Nan Liu
e3784987fc Fix dependency issues introduced with anchor.
apt::ppa and apt::builddep requires apt class. The anchor introduced for
containment of apt-get update causes a dependency loop. apt::ppa appears
to depend on apt class sources.d direcory. While apt::builddep have no
clear reason for a dependency on apt class. This change refactor both
define type, so they no longer cause a dependency loop.
2012-05-09 12:04:17 -07:00
Nan Liu
322f3b68e7 Fix style related issues in module. 2012-05-08 10:47:43 -07:00
Nan Liu
666a05dea1 (#11966) apt module containment for apt_update.
The update to separate Exec["apt-get update ${name}"] to single exec in
apt::update class resulted in apt-get update command to be dangled.
Previously if user specified Package['package_a'] <-
Apt::Resource['source_a'], the original refactor would no longer
guarantee apt-get update is executed before the package is installed.
This patch fixes the problem using the anchor resource and ensuring the
old behaviour is maintained and user can depend on apt-get update
command being invoked if they specify dependency on any apt::*
define resource type as well as the apt class.
2012-05-07 15:27:53 -07:00
Nan Liu
e8977deea1 (#14321) apt::pin resource support release.
apt::pin release should default to title, but should be able to
override. This update removes unnecessary "" around $name, and add spec
tests.

Conflicts:

	spec/defines/pin_spec.rb
2012-05-04 13:56:35 -07:00
albac
feee023b24 Update manifests/pin.pp 2012-05-04 13:55:15 -07:00
Thomas Broyer
0ffe484c7c Move Package['python-software-properties'] to apt:ppa
Also updates the apt-update in Apt::Ppa to use $apt::params::provider
instead of aptitude.
2012-05-04 13:46:08 -07:00
Nan Liu
f13f3cfac7 (#11966) Change apt update to apt_update.
Based on code review change exec from apt update to apt_update.
2012-05-04 13:35:25 -07:00
Nan Liu
82967a22fa (#11966) Update apt::ppa to use apt::update.
Change apt::ppa define type to also use the apt::update class to invoke
apt-get update once.
2012-05-04 13:35:25 -07:00
Nan Liu
3684f88372 (#11966) Only invoke apt-get update once.
Move apt-get update exec to a seperate class to minimize the number of
apt-get updates invoked by configuration changes.

* remove apt_update exec resource in apt class.
* remove apt-get-${name} in defines.
* apt::source notify Exec['apt update'].
* Remove dependency to Exec['apt_update'].
* fix rspec-puppet tests.

Conflicts:

	manifests/source.pp
2012-05-04 13:35:13 -07:00
Nan Liu
effb3f7ff3 (#14308) Add ensure=>absent for define resource.
Several apt::* define resource type does not support ensurable. This
update allows ensure=>absent to support the removal of these
configuration files.

* apt::conf
* apt::pin
* apt::source
2012-05-03 16:59:13 -07:00
Nan Liu
17b9ac3c7f Cleanup apt-module puppet-lint related issues. 2012-05-03 10:10:06 -07:00
Nan Liu
51a7596b03 Merge pull request #41 from tbroyer/install-proxy-first
Make sure we configure the proxy before doing apt-get update.
2012-05-02 17:31:57 -07:00
Nan Liu
4a788a60f9 Merge pull request #44 from relud/patch-1
(#14138) Modify apt::ppa's update-apt exec to use the ${apt::params::provider} parameter.
2012-05-02 17:29:31 -07:00
Nan Liu
42af4cdc74 Merge pull request #42 from ody/sync_with_pl_ops
Sync with pl ops
2012-05-02 17:27:12 -07:00
Nan Liu
d1e0e3ee37 (#14287) Fix apt::pin resource for rspec-puppet.
The shorthand syntax cause rspec-puppet failure for external modules
depending on the puppet-apt module. This patch uses the require
metaparameter to avoid this issue.
2012-05-02 16:00:27 -07:00
Daniel Thornton
a5ba24695f (#14138) Modify apt::ppa's update-apt exec to use the ${apt::params::provider} parameter rather than explicitly calling aptitude.
Previously the update-apt exec would always use /usr/bin/aptitude, which is not necessarily present. This change makes it use ${apt::params::provider} which defaults to /usr/bin/apt-get. This also adds some consistency so that ${apt::params::provider} is used everywhere.
2012-04-23 20:40:24 +00:00
Cody Herriges
644ed232a0 Tests to validate apt::{conf,backports}
This patch adds the appropriate spec tests to validate the changes
  introduced by e5f2dfe.  As a bonus it includes fixes to the manifests
  that were discovered while writing the tests.
2012-04-20 13:43:38 -07:00
Cody Herriges
e5f2dfe294 Adds apt::{conf,backports} and variable style.
With the addition of this patch two new defines will be added; one to
  manage APT configuration files (apt::conf) and one that abstracts out the
  requirements needed to turn on backport repositories (apt::backports).

  In addition, the patch takes the opportunity to clean up variable
  definitions so they follow a consistent pattern of setting local
  variables to the fully qualified value stored in the apt::params
  class.  Previously all variable used within a class directly addressed
  the apt::params namespace when ever the variable was used.  In the
  pattern they now adhere to we can more easily switch the namespace
  data lives in or externalize it even more using hiera.
2012-04-20 13:35:27 -07:00
Thomas Broyer
e656c65818 Make sure we configure the proxy before doing apt-get update. 2012-03-30 17:48:31 +02:00
Ken Barber
9c13872b5a (#13289) Fix some more style violations 2012-03-21 13:35:48 +00:00