e7fee16589
The /usr/lib/update-notifier/apt-check script returns its output to STDERR but a recent change to the script redirects STDERR to /dev/null. This will cause the array to always be empty. Combined with that problem, while we were checking for the result being nil, we never checked for an invalid array. As a result, the apt_has_updates was always true and the apt_updates and apt_security_updates facts were trying to read from an empty array and failing.
25 lines
787 B
Ruby
25 lines
787 B
Ruby
require 'spec_helper'
|
|
|
|
describe 'apt_security_updates fact' do
|
|
subject { Facter.fact(:apt_security_updates).value }
|
|
after(:each) { Facter.clear }
|
|
|
|
describe 'when apt has no updates' do
|
|
before {
|
|
Facter.fact(:apt_has_updates).stubs(:value).returns false
|
|
}
|
|
it { should be nil }
|
|
end
|
|
|
|
describe 'when apt has security updates' do
|
|
before {
|
|
Facter.fact(:osfamily).stubs(:value).returns 'Debian'
|
|
File.stubs(:executable?) # Stub all other calls
|
|
Facter::Util::Resolution.stubs(:exec) # Catch all other calls
|
|
File.expects(:executable?).with('/usr/lib/update-notifier/apt-check').returns true
|
|
Facter::Util::Resolution.expects(:exec).with('/usr/lib/update-notifier/apt-check 2>&1').returns "14;7"
|
|
}
|
|
it { should == 7 }
|
|
end
|
|
|
|
end
|