opuppet/module-puppetlabs-mysql
5
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
module-puppetlabs-mysql/manifests/server.pp

87 lines
3 KiB
ObjectPascal
Raw Normal View History

Add mysql::globals and refactor mysql::server. This work adds a new mysql::globals class which contains a hash used to build my.cnf from. It's used to share this data across multiple classes so that the client and server can share this data. End users can modify content in my.cnf by including mysql::globals and passing in override_options as a hash that looks like: override_options = { 'mysqld' => { 'max_connections' => '120' } } This completely replaces the mess of parameters that existed in the main mysql class before. Completely refactor mysql::server and rework the API. This changes ordering, changes from execs{} to mysql_user for the root password, removes some functionality (like the etc_root_password), and generally makes some tough decisions about how mysql::server should be built.
2013-09-13 19:04:42 +02:00
# Class: mysql::server: See README.md for documentation.
Major refactor of mysql module. This is a major change to the module and would be released as a new version. * Add self.instances to database and database_user for puppet resource. * Update database provider to use flush method. * Update module to conform to puppet-lint recommendations. * Cleanup some unecessary logic in mysql::db define type. * Move mysql_restart to config class. * Use class to class dependency instead of resource dependency. * Change appropriate rspec-puppet tests. * Add fixtures directory to simplify testing. * Update raketask and spec_helper to reflect fixture changes. * Update mysql_password function to support validation. * Move client installation to a separate class. * Update documentation and readme.
2012-02-09 20:26:00 +01:00
class mysql::server (
Remove mysql::globals. This turned out to be a fairly bad idea. It begun as a way to try and mirror what happens in the postgresql module for consistency but instead made things complex. I've changed it to have the override_options in mysql::server which leads much more naturally out of the design and shape of MySQL.
2013-09-25 00:04:29 +02:00
$config_file = $mysql::params::config_file,
Prametrize !includedir Hardcoded path provided by puppet is now replaced by providing only the final directory as on most systems includedir is provided by package and it's matter of user to provide it if he wants to override it. This also allows disabling including at all.
2014-06-04 14:05:39 +02:00
$includedir = $mysql::params::includedir,
[MODULES-1484] Add support for install_options for all package resources. Add install_options parameter to mysql::bindings, mysql::client, and mysql::server. The default is undef.
2014-10-29 20:59:59 +01:00
$install_options = undef,
Remove mysql::globals. This turned out to be a fairly bad idea. It begun as a way to try and mirror what happens in the postgresql module for consistency but instead made things complex. I've changed it to have the override_options in mysql::server which leads much more naturally out of the design and shape of MySQL.
2013-09-25 00:04:29 +02:00
$manage_config_file = $mysql::params::manage_config_file,
Add mysql::globals and refactor mysql::server. This work adds a new mysql::globals class which contains a hash used to build my.cnf from. It's used to share this data across multiple classes so that the client and server can share this data. End users can modify content in my.cnf by including mysql::globals and passing in override_options as a hash that looks like: override_options = { 'mysqld' => { 'max_connections' => '120' } } This completely replaces the mess of parameters that existed in the main mysql class before. Completely refactor mysql::server and rework the API. This changes ordering, changes from execs{} to mysql_user for the root password, removes some functionality (like the etc_root_password), and generally makes some tough decisions about how mysql::server should be built.
2013-09-13 19:04:42 +02:00
$old_root_password = $mysql::params::old_root_password,
Remove mysql::globals. This turned out to be a fairly bad idea. It begun as a way to try and mirror what happens in the postgresql module for consistency but instead made things complex. I've changed it to have the override_options in mysql::server which leads much more naturally out of the design and shape of MySQL.
2013-09-25 00:04:29 +02:00
$override_options = {},
Add mysql::globals and refactor mysql::server. This work adds a new mysql::globals class which contains a hash used to build my.cnf from. It's used to share this data across multiple classes so that the client and server can share this data. End users can modify content in my.cnf by including mysql::globals and passing in override_options as a hash that looks like: override_options = { 'mysqld' => { 'max_connections' => '120' } } This completely replaces the mess of parameters that existed in the main mysql class before. Completely refactor mysql::server and rework the API. This changes ordering, changes from execs{} to mysql_user for the root password, removes some functionality (like the etc_root_password), and generally makes some tough decisions about how mysql::server should be built.
2013-09-13 19:04:42 +02:00
$package_ensure = $mysql::params::server_package_ensure,
$package_name = $mysql::params::server_package_name,
Remove mysql::globals. This turned out to be a fairly bad idea. It begun as a way to try and mirror what happens in the postgresql module for consistency but instead made things complex. I've changed it to have the override_options in mysql::server which leads much more naturally out of the design and shape of MySQL.
2013-09-25 00:04:29 +02:00
$purge_conf_dir = $mysql::params::purge_conf_dir,
Add mysql::globals and refactor mysql::server. This work adds a new mysql::globals class which contains a hash used to build my.cnf from. It's used to share this data across multiple classes so that the client and server can share this data. End users can modify content in my.cnf by including mysql::globals and passing in override_options as a hash that looks like: override_options = { 'mysqld' => { 'max_connections' => '120' } } This completely replaces the mess of parameters that existed in the main mysql class before. Completely refactor mysql::server and rework the API. This changes ordering, changes from execs{} to mysql_user for the root password, removes some functionality (like the etc_root_password), and generally makes some tough decisions about how mysql::server should be built.
2013-09-13 19:04:42 +02:00
$remove_default_accounts = false,
Remove mysql::globals. This turned out to be a fairly bad idea. It begun as a way to try and mirror what happens in the postgresql module for consistency but instead made things complex. I've changed it to have the override_options in mysql::server which leads much more naturally out of the design and shape of MySQL.
2013-09-25 00:04:29 +02:00
$restart = $mysql::params::restart,
$root_group = $mysql::params::root_group,
Add mysql::globals and refactor mysql::server. This work adds a new mysql::globals class which contains a hash used to build my.cnf from. It's used to share this data across multiple classes so that the client and server can share this data. End users can modify content in my.cnf by including mysql::globals and passing in override_options as a hash that looks like: override_options = { 'mysqld' => { 'max_connections' => '120' } } This completely replaces the mess of parameters that existed in the main mysql class before. Completely refactor mysql::server and rework the API. This changes ordering, changes from execs{} to mysql_user for the root password, removes some functionality (like the etc_root_password), and generally makes some tough decisions about how mysql::server should be built.
2013-09-13 19:04:42 +02:00
$root_password = $mysql::params::root_password,
$service_enabled = $mysql::params::server_service_enabled,
$service_manage = $mysql::params::server_service_manage,
$service_name = $mysql::params::server_service_name,
Fix description for PE3.1 In PE3.1 it parses the comment #Deprecated at the top of the parameters as if it's the class description. Move this so PE3.1 doesn't falsely claim mysql::server is now deprecated.
2013-10-16 17:42:35 +02:00
$service_provider = $mysql::params::server_service_provider,
Add new parameters create_root_user and create_root_my_cnf. This allows the galera module and others to write ${::root_home}/.my.cnf independently from create the mysql user. This is useful for cluster setups where you want to create ${::root_home}/.my.cnf on every node but create the user only once.
2014-10-06 10:53:30 +02:00
$create_root_user = $mysql::params::create_root_user,
$create_root_my_cnf = $mysql::params::create_root_my_cnf,
Better hiera integration This adds hash parameters to mysql::server to allow specifying grants, users, and databases to create automatically, which works nicely with Hiera's automatic parameter lookup functionality
2013-11-11 04:25:55 +01:00
$users = {},
$grants = {},
$databases = {},
Fix description for PE3.1 In PE3.1 it parses the comment #Deprecated at the top of the parameters as if it's the class description. Move this so PE3.1 doesn't falsely claim mysql::server is now deprecated.
2013-10-16 17:42:35 +02:00
# Deprecated parameters
$enabled = undef,
$manage_service = undef
Remove mysql::globals. This turned out to be a fairly bad idea. It begun as a way to try and mirror what happens in the postgresql module for consistency but instead made things complex. I've changed it to have the override_options in mysql::server which leads much more naturally out of the design and shape of MySQL.
2013-09-25 00:04:29 +02:00
) inherits mysql::params {
Debian should not manage root password - previously setting the root password failed on Debian b/c a root password was already set during package installation - Debian already installs mysql with a maintainance user capable of performing any required database actions. - this patch splits setting of root password to be redhat specific. - as a consequence, users will not be able to specify a root password on Debian (which needs to be opened as a seperate ticket)
2011-06-16 19:49:15 +02:00
Add mysql::globals and refactor mysql::server. This work adds a new mysql::globals class which contains a hash used to build my.cnf from. It's used to share this data across multiple classes so that the client and server can share this data. End users can modify content in my.cnf by including mysql::globals and passing in override_options as a hash that looks like: override_options = { 'mysqld' => { 'max_connections' => '120' } } This completely replaces the mess of parameters that existed in the main mysql class before. Completely refactor mysql::server and rework the API. This changes ordering, changes from execs{} to mysql_user for the root password, removes some functionality (like the etc_root_password), and generally makes some tough decisions about how mysql::server should be built.
2013-09-13 19:04:42 +02:00
# Deprecated parameters.
if $enabled {
crit('This parameter has been renamed to service_enabled.')
$real_service_enabled = $enabled
} else {
$real_service_enabled = $service_enabled
}
if $manage_service {
crit('This parameter has been renamed to service_manage.')
$real_service_manage = $manage_service
} else {
$real_service_manage = $service_manage
}
Remove mysql::globals. This turned out to be a fairly bad idea. It begun as a way to try and mirror what happens in the postgresql module for consistency but instead made things complex. I've changed it to have the override_options in mysql::server which leads much more naturally out of the design and shape of MySQL.
2013-09-25 00:04:29 +02:00
# Create a merged together set of options. Rightmost hashes win over left.
Fixes issue #274 by using recursive hash merge.
2013-09-25 19:38:08 +02:00
$options = mysql_deepmerge($mysql::params::default_options, $override_options)
Remove mysql::globals. This turned out to be a fairly bad idea. It begun as a way to try and mirror what happens in the postgresql module for consistency but instead made things complex. I've changed it to have the override_options in mysql::server which leads much more naturally out of the design and shape of MySQL.
2013-09-25 00:04:29 +02:00
Refactor to use mysql::globals. This initial round of work focuses on adding the concept of mysql::globals to the module. This is a shared place to provide all the data the module needs, and then clients, servers, and providers can all rely on this information to set things up. This is being primarily used at first to allow a default_options hash that contains all the previous parameters and takes a overrides_options that allows you to then further customize any of the options in my.cnf.
2013-09-09 17:34:39 +02:00
Class['mysql::server::root_password'] -> Mysql::Db <| |>
Moved class dependency between sever and config to server Prevously, the server class declared the config class and the config class had a relationship to the server class. This actually meant that the config class could never be declared by itself b/c it exlicity depended on the server class (which it could never resolve externally b/c it would result in a redeclaration of the config class itself.) This issue actually made it impossible to test the manifest on its own with rspec-puppet. This commit makes it much easier to write rspec tests for the config class.
2012-03-15 08:51:35 +01:00
Refactor to use mysql::globals. This initial round of work focuses on adding the concept of mysql::globals to the module. This is a shared place to provide all the data the module needs, and then clients, servers, and providers can all rely on this information to set things up. This is being primarily used at first to allow a default_options hash that contains all the previous parameters and takes a overrides_options that allows you to then further customize any of the options in my.cnf.
2013-09-09 17:34:39 +02:00
include '::mysql::server::install'
include '::mysql::server::config'
include '::mysql::server::service'
include '::mysql::server::root_password'
Better hiera integration This adds hash parameters to mysql::server to allow specifying grants, users, and databases to create automatically, which works nicely with Hiera's automatic parameter lookup functionality
2013-11-11 04:25:55 +01:00
include '::mysql::server::providers'
Fix Puppet 2.6 compilation issues. In Puppet 2.6, negate boolean wasn't handled in resources attribues. Also hashes values were not accepted in functions. The manifests have been updated to resolve compilation issues in Puppet 2.6.
2012-03-18 07:56:13 +01:00
Add mysql::globals and refactor mysql::server. This work adds a new mysql::globals class which contains a hash used to build my.cnf from. It's used to share this data across multiple classes so that the client and server can share this data. End users can modify content in my.cnf by including mysql::globals and passing in override_options as a hash that looks like: override_options = { 'mysqld' => { 'max_connections' => '120' } } This completely replaces the mess of parameters that existed in the main mysql class before. Completely refactor mysql::server and rework the API. This changes ordering, changes from execs{} to mysql_user for the root password, removes some functionality (like the etc_root_password), and generally makes some tough decisions about how mysql::server should be built.
2013-09-13 19:04:42 +02:00
if $remove_default_accounts {
class { '::mysql::server::account_security':
require => Anchor['mysql::server::end'],
}
}
anchor { 'mysql::server::start': }
anchor { 'mysql::server::end': }
Add $restart support. Previously this parameter did nothing, lets make it actually work.
2013-12-18 19:59:56 +01:00
if $restart {
Anchor['mysql::server::start'] ->
Class['mysql::server::install'] ->
Add a comment to make this clearer.
2013-12-18 20:04:51 +01:00
# Only difference between the blocks is that we use ~> to restart if
# restart is set to true.
Add $restart support. Previously this parameter did nothing, lets make it actually work.
2013-12-18 19:59:56 +01:00
Class['mysql::server::config'] ~>
Class['mysql::server::service'] ->
Class['mysql::server::root_password'] ->
Class['mysql::server::providers'] ->
Anchor['mysql::server::end']
} else {
Anchor['mysql::server::start'] ->
Class['mysql::server::install'] ->
Class['mysql::server::config'] ->
Class['mysql::server::service'] ->
Class['mysql::server::root_password'] ->
Class['mysql::server::providers'] ->
Anchor['mysql::server::end']
}
Debian should not manage root password - previously setting the root password failed on Debian b/c a root password was already set during package installation - Debian already installs mysql with a maintainance user capable of performing any required database actions. - this patch splits setting of root password to be redhat specific. - as a consequence, users will not be able to specify a root password on Debian (which needs to be opened as a seperate ticket)
2011-06-16 19:49:15 +02:00
Created config class and extended params. It makes way more sense to just allow it as a class param. Also added some additional config for setting bind address and port. Added management of /etc/mysql/my.cnf Documented a dependency on create_resources 0.0.1
2011-06-22 20:38:11 +02:00
}
Reference in a new issue Copy permalink