Merge pull request #604 from mhaskel/rebase_581

Fixed test classes

manifests/bindings.pp

@@ -35,11 +35,11 @@ class mysql::bindings (
 
   case $::osfamily {
     'Archlinux': {
-      if $java_enable   { fatal("::mysql::bindings::java cannot be managed by puppet on ${::osfamily} as it is not in official repositories. Please disable java mysql binding.") }
+      if $java_enable   { fail("::mysql::bindings::java cannot be managed by puppet on ${::osfamily} as it is not in official repositories. Please disable java mysql binding.") }
       if $perl_enable   { include '::mysql::bindings::perl' }
-      if $php_enable    { warn("::mysql::bindings::php does not need to be managed by puppet on ${::osfamily} as it is included in mysql package by default.") }
+      if $php_enable    { warning("::mysql::bindings::php does not need to be managed by puppet on ${::osfamily} as it is included in mysql package by default.") }
       if $python_enable { include '::mysql::bindings::python' }
-      if $ruby_enable   { fatal("::mysql::bindings::ruby cannot be managed by puppet on ${::osfamily} as it is not in official repositories. Please disable ruby mysql binding.") }
+      if $ruby_enable   { fail("::mysql::bindings::ruby cannot be managed by puppet on ${::osfamily} as it is not in official repositories. Please disable ruby mysql binding.") }
     }
 
     default: {

tests/backup.pp

@@ -1,7 +1,8 @@
 class { 'mysql::server':
-  config_hash => {'root_password' => 'password'}
+  root_password => 'password'
 }
-class { 'mysql::backup':
+
+class { 'mysql::server::backup':
   backupuser     => 'myuser',
   backuppassword => 'mypassword',
   backupdir      => '/tmp/backups',

tests/bindings.pp

@@ -1,3 +1,3 @@
 class { 'mysql::bindings':
-  php_enable => 'true',
+  php_enable => true,
 }

tests/mysql_database.pp

@@ -1,16 +1,16 @@
 class { 'mysql::server':
-  config_hash => {'root_password' => 'password'}
+  root_password => 'password'
 }
-database{ ['test1', 'test2', 'test3']:
+mysql::db{ ['test1', 'test2', 'test3']:
   ensure  => present,
   charset => 'utf8',
   require => Class['mysql::server'],
 }
-database{ 'test4':
+mysql::db{ 'test4':
   ensure  => present,
   charset => 'latin1',
 }
-database{ 'test5':
+mysql::db{ 'test5':
   ensure  => present,
   charset => 'binary',
   collate => 'binary',

tests/mysql_db.pp

@@ -1,5 +1,5 @@
 class { 'mysql::server':
-  config_hash => {'root_password' => 'password'}
+  root_password => 'password'
 }
 mysql::db { 'mydb':
   user     => 'myuser',

tests/mysql_user.pp

@@ -1,9 +1,7 @@
 $mysql_root_pw = 'password'
 
 class { 'mysql::server':
-  config_hash => {
+  root_password => 'password',
-    root_password => 'password',
-  }
 }
 
 mysql_user{ 'redmine@localhost':

tests/perl.pp

@@ -1 +1 @@
-include mysql::perl
+include mysql::bindings::perl

tests/python.pp

@@ -1 +1 @@
-class { 'mysql::python':}
+class { 'mysql::bindings::python':}

tests/ruby.pp

@@ -1 +1 @@
-include mysql::ruby
+include mysql::bindings::ruby

tests/server/account_security.pp

@@ -1,4 +1,4 @@
 class { 'mysql::server':
-  config_hash => { 'root_password' => 'password', },
+  root_password => 'password',
 }
 class { 'mysql::server::account_security': }

tests/server/config.pp

@@ -1,11 +1,3 @@
 mysql::server::config { 'testfile':
-  settings => {
+  
-    'mysqld' => {
-      'bind-address' => '0.0.0.0',
-      'read-only'    => true,
-    },
-    'client' => {
-      'port' => '3306'
-    }
-  }
 }