From 6a79d2683833e87c9a8d6b21655bb268bf425f99 Mon Sep 17 00:00:00 2001
From: Dmitry Melanchenko <dmelanchenko@salesforce.com>
Date: Wed, 15 Apr 2015 21:25:37 +0000
Subject: [PATCH] references to README.md and default values were added to
 workaround warnings from puppet-lint

---
 manifests/backup/mysqlbackup.pp      | 30 +++++++++++++-------------
 manifests/backup/mysqldump.pp        | 30 +++++++++++++-------------
 manifests/backup/xtrabackup.pp       | 32 ++++++++++++++--------------
 manifests/client/install.pp          |  1 +
 manifests/server/account_security.pp |  1 +
 manifests/server/monitor.pp          |  6 +++---
 6 files changed, 51 insertions(+), 49 deletions(-)

diff --git a/manifests/backup/mysqlbackup.pp b/manifests/backup/mysqlbackup.pp
index bf54d0d..9d92b6c 100644
--- a/manifests/backup/mysqlbackup.pp
+++ b/manifests/backup/mysqlbackup.pp
@@ -1,21 +1,21 @@
 # See README.me for usage.
 class mysql::backup::mysqlbackup (
-  $backupuser,
-  $backuppassword,
-  $backupdir,
-  $backupdirmode = '0700',
-  $backupdirowner = 'root',
-  $backupdirgroup = $mysql::params::root_group,
-  $backupcompress = true,
-  $backuprotate = 30,
-  $ignore_events = true,
+  $backupuser         = '',
+  $backuppassword     = '',
+  $backupdir          = '',
+  $backupdirmode      = '0700',
+  $backupdirowner     = 'root',
+  $backupdirgroup     = $mysql::params::root_group,
+  $backupcompress     = true,
+  $backuprotate       = 30,
+  $ignore_events      = true,
   $delete_before_dump = false,
-  $backupdatabases = [],
-  $file_per_database = false,
-  $ensure = 'present',
-  $time = ['23', '5'],
-  $postscript = false,
-  $execpath   = '/usr/bin:/usr/sbin:/bin:/sbin',
+  $backupdatabases    = [],
+  $file_per_database  = false,
+  $ensure             = 'present',
+  $time               = ['23', '5'],
+  $postscript         = false,
+  $execpath           = '/usr/bin:/usr/sbin:/bin:/sbin',
 ) {
 
   mysql_user { "${backupuser}@localhost":
diff --git a/manifests/backup/mysqldump.pp b/manifests/backup/mysqldump.pp
index 9075838..51f912c 100644
--- a/manifests/backup/mysqldump.pp
+++ b/manifests/backup/mysqldump.pp
@@ -1,21 +1,21 @@
 # See README.me for usage.
 class mysql::backup::mysqldump (
-  $backupuser,
-  $backuppassword,
-  $backupdir,
-  $backupdirmode = '0700',
-  $backupdirowner = 'root',
-  $backupdirgroup = $mysql::params::root_group,
-  $backupcompress = true,
-  $backuprotate = 30,
-  $ignore_events = true,
+  $backupuser         = '',
+  $backuppassword     = '',
+  $backupdir          = '',
+  $backupdirmode      = '0700',
+  $backupdirowner     = 'root',
+  $backupdirgroup     = $mysql::params::root_group,
+  $backupcompress     = true,
+  $backuprotate       = 30,
+  $ignore_events      = true,
   $delete_before_dump = false,
-  $backupdatabases = [],
-  $file_per_database = false,
-  $ensure = 'present',
-  $time = ['23', '5'],
-  $postscript = false,
-  $execpath   = '/usr/bin:/usr/sbin:/bin:/sbin',
+  $backupdatabases    = [],
+  $file_per_database  = false,
+  $ensure             = 'present',
+  $time               = ['23', '5'],
+  $postscript         = false,
+  $execpath           = '/usr/bin:/usr/sbin:/bin:/sbin',
 ) {
 
   mysql_user { "${backupuser}@localhost":
diff --git a/manifests/backup/xtrabackup.pp b/manifests/backup/xtrabackup.pp
index 05699ab..fb4ed62 100644
--- a/manifests/backup/xtrabackup.pp
+++ b/manifests/backup/xtrabackup.pp
@@ -1,22 +1,22 @@
 # See README.me for usage.
 class mysql::backup::xtrabackup (
-  $backupuser,
-  $backuppassword,
-  $backupdir,
-  $backupmethod = 'mysqldump',
-  $backupdirmode = '0700',
-  $backupdirowner = 'root',
-  $backupdirgroup = $mysql::params::root_group,
-  $backupcompress = true,
-  $backuprotate = 30,
-  $ignore_events = true,
+  $backupuser         = '',
+  $backuppassword     = '',
+  $backupdir          = '',
+  $backupmethod       = 'mysqldump',
+  $backupdirmode      = '0700',
+  $backupdirowner     = 'root',
+  $backupdirgroup     = $mysql::params::root_group,
+  $backupcompress     = true,
+  $backuprotate       = 30,
+  $ignore_events      = true,
   $delete_before_dump = false,
-  $backupdatabases = [],
-  $file_per_database = false,
-  $ensure = 'present',
-  $time = ['23', '5'],
-  $postscript = false,
-  $execpath   = '/usr/bin:/usr/sbin:/bin:/sbin',
+  $backupdatabases    = [],
+  $file_per_database  = false,
+  $ensure             = 'present',
+  $time               = ['23', '5'],
+  $postscript         = false,
+  $execpath           = '/usr/bin:/usr/sbin:/bin:/sbin',
 ) {
 
   mysql_user { "${backupuser}@localhost":
diff --git a/manifests/client/install.pp b/manifests/client/install.pp
index 8ffff5b..26e5ec2 100644
--- a/manifests/client/install.pp
+++ b/manifests/client/install.pp
@@ -1,3 +1,4 @@
+# See README.md.
 class mysql::client::install {
 
   if $mysql::client::package_manage {
diff --git a/manifests/server/account_security.pp b/manifests/server/account_security.pp
index 07bdf01..252572e 100644
--- a/manifests/server/account_security.pp
+++ b/manifests/server/account_security.pp
@@ -1,3 +1,4 @@
+# See README.md.
 class mysql::server::account_security {
   mysql_user {
     [ 'root@127.0.0.1',
diff --git a/manifests/server/monitor.pp b/manifests/server/monitor.pp
index 9e86b92..6b18609 100644
--- a/manifests/server/monitor.pp
+++ b/manifests/server/monitor.pp
@@ -1,8 +1,8 @@
 #This is a helper class to add a monitoring user to the database
 class mysql::server::monitor (
-  $mysql_monitor_username,
-  $mysql_monitor_password,
-  $mysql_monitor_hostname
+  $mysql_monitor_username = '',
+  $mysql_monitor_password = '',
+  $mysql_monitor_hostname = ''
 ) {
 
   Anchor['mysql::server::end'] -> Class['mysql::server::monitor']