Commit graph

1282 commits

Author SHA1 Message Date
Julien Pivotto
c2b0b4cb2c Split package installation and database install
The current install pattern used by this module is the following:
1. Install package
2. Install the DB
3. Make the config files

In some cases this prevents MySQL to start, because some variables in
the config file have an impact on the DB installation.

Example with a custom innodb_data_file_path:
[ERROR] InnoDB: space header page consists of zero bytes in data file
/var/lib/mysql/ibdata

This commit changes the order to do:
1. Install package
2. Make the config files
3. Install the DB
2015-04-23 13:17:08 +02:00
Igor Galić
a4b7595fde Merge pull request #700 from mvisonneau/master
Bugfix on Xtrabackup crons
2015-04-22 15:39:48 +02:00
Maxime VISONNEAU
2b9e777637 Bugfix on Xtrabackup crons 2015-04-21 14:25:11 +02:00
Igor Galić
873dea342f Merge pull request #699 from melan/master
Adds default values for parameters and align assignments
2015-04-16 13:43:57 +02:00
Dmitry Melanchenko
6a79d26838 references to README.md and default values were added to workaround warnings from puppet-lint 2015-04-15 21:25:37 +00:00
Hunter Haugen
97c9eea81e Merge pull request #698 from mhaskel/MODULES-1928
MODULES-1928 - allow log-error to be undef
2015-04-14 10:37:29 -07:00
Morgan Haskel
298242e043 MODULES-1928 - allow log-error to be undef
Wrap the file resource so that this doesn't explode if log-error is
undef. This is required for syslogging.
2015-04-13 17:05:22 -07:00
Igor Galić
eb3fa4e9f5 Merge pull request #697 from fraenki/freebsd_support
fix FreeBSD support for backups
2015-04-13 15:39:15 +02:00
Morgan Haskel
c2ec74b1b5 Merge pull request #687 from igalic/provider-regr
mysql backup: fix regression in mysql_user call
2015-04-08 15:35:25 -07:00
Frank Wall
a2faed23ac fix FreeBSD support for backups 2015-03-31 12:58:49 +02:00
TP Honey
5de035c60d Merge pull request #696 from leoarnold/master
Corrected some typos in README
2015-03-30 10:24:09 +01:00
Justin Stoller
85a5d8be6f Merge pull request #695 from anodelman/master
(BKR-147) add Gemfile setting for BEAKER_VERSION for puppet...
2015-03-26 16:48:12 -07:00
Leo Arnold
91ca5a0542 Corrected some typos in README 2015-03-25 18:48:53 +01:00
Alice Nodelman
519371ff0a (BKR-147) add Gemfile setting for BEAKER_VERSION for puppet...
puppetdb, etc

- support for BEAKER_VERSION and BEAKER_RSPEC_VERSION in gemfile
2015-03-24 14:53:44 -07:00
Morgan Haskel
c05952a398 Merge pull request #694 from cmurphy/rspec-puppet-2
Test and future parser updates
2015-03-24 15:53:44 -04:00
Colleen Murphy
6104cfa445 Update .travis.yml
This commit makes the following changes to the test matrix:

- Runs tests on ruby 2.1.5 instead of 2.0.0
- Runs tests on ruby 1.8.7 with puppet 3.x
- Adds an environment to run on an intermediate 3.x puppet version
  instead of latest (specifically 3.4.x)
- Adds an environment to run with the future parser on latest puppet.
  This would affect the test runs for the validate and spec checks.
- Runs the tests on docker
2015-03-23 22:09:40 -07:00
Colleen Murphy
0e2e148a82 Keep testing on puppet 2.7
The modulesync config repo is dropping universal support for puppet
2.7, but individual repos should still keep support until the next
naturally-occuring major release.
2015-03-23 22:09:27 -07:00
Colleen Murphy
9b977ec943 Remove unneeded dependencies
puppetlabs_spec_helper handles these dependencies for us.
2015-03-23 22:09:27 -07:00
Colleen Murphy
a59c68b165 Update tests for rspec-puppet 2 and future parser
This patch changes the raise_error matchers to use `catalogue` instead
of `subject` since `subject` is not evaluated the way it used to be;
changes a parameter value from empty string to nil to be compatible
with the future parser, and unpins rspec-puppet.
2015-03-23 22:09:15 -07:00
Igor Galić
d8b7a9011e Merge pull request #690 from mremy/comment
Cosmetic: add comment managed by puppet
2015-03-18 18:59:15 +01:00
Morgan Haskel
97b7223f48 Merge pull request #691 from buzzdeee/master
Fix regression introduced by adding OpenBSD support.
2015-03-18 10:53:44 -07:00
Sebastian Reitenbach
5116883111 Fix regression introduced by adding OpenBSD support.
Add a $mysql_group parameter, and use that instead of the $root_group
parameter to define the group membership of the mysql error log file.
2015-03-18 08:47:25 +01:00
Jesse Cotton
a26b80d750 Remove default install root password if set 2015-03-17 15:21:07 +00:00
Marc Remy
18229c4d02 Cosmetic: add comment managed by puppet 2015-03-17 15:58:37 +01:00
Igor Galić
b09d2337aa Merge pull request #688 from mremy/master
Manage service only if managed
2015-03-16 14:31:35 +01:00
Marc Remy
04b806044a Manage service only if managed
In the case of an unmanaged mysql service, defined with:
class {'::mysql::server':
[...]
  service_manage => false,
[...]
}

We have the following error:
Undefined variable "service_ensure"

In this case, we don't want to have it "started" or "stopped", as it is
managed by another application (in our case by pacemaker).

This patch resolve this issue, by setting service_ensure to undef, in the
case of an unmanaged service.
2015-03-16 12:58:54 +01:00
Jesse Cotton
5b692a8f62 Deprecate mysql::server::old_root_password 2015-03-13 13:58:04 +00:00
Igor Galić
facb57a108 Merge pull request #567 from buzzdeee/master
Add OpenBSD support.
2015-03-12 10:55:17 +01:00
Igor Galić
32329b77b7 Merge pull request #672 from timmooney/master
Only set up ordering between the config file and the service if we're managing the config file.
2015-03-11 14:50:30 +01:00
Sebastian Reitenbach
db72fe8d86 Add OpenBSD support, only for OpenBSD -current, since
the recent switch to mariadb.
2015-03-11 14:46:29 +01:00
Igor Galić
1c3bf95e21 mysql backup: fix regression in mysql_user call
due to a mishappen rebase, in #649, we introduced a regression fixed
which was fixed in #655.

how come our tests don't catch this?
2015-03-05 14:33:44 +01:00
Morgan Haskel
d28e64bee3 Merge pull request #686 from tphoney/igalic-server_id
Added server_id fact
2015-03-04 08:23:15 -08:00
tphoney
78a787107f minor typos fixed 2015-03-04 10:56:32 +00:00
Igor Galić
d7077b43d2 document mysql_server_id fact and add spec tests
add spec tests, expand documentation to mention lo behaviour
also, rename fact, for, consistency.
2015-03-04 08:56:45 +01:00
Nick Le Mouton
dbf54cefe8 Added server_id fact
use mac address for "guaranteed" uniqueness ;)
2015-03-04 08:56:18 +01:00
Colleen Murphy
1a572d6070 Merge pull request #684 from mhaskel/merge_3.3.x_to_master
Merge 3.3.x to master
2015-03-03 12:30:36 -08:00
Morgan Haskel
c016825975 Merge branch 'jbondpdx-readme-rev' into 3.3.x 2015-03-02 14:33:14 -08:00
jbondpdx
35bc18355e DOCS: Minor edits on mysql readme
DOCS: minor pre-release fixes for mysql readme

added a subcategory to the TOC, couple of trivial proofreading things.

DOCS: fixed typo readme.md
2015-03-02 14:32:57 -08:00
Travis Fields
9158e25d49 Merge pull request #680 from mhaskel/3.3.0-prep
3.3.0 prep
2015-03-02 11:30:26 -08:00
Morgan Haskel
17ccf76e31 3.3.0 prep 2015-03-02 11:28:11 -08:00
Morgan Haskel
7ee3b8b708 Whitespace fix 2015-03-02 11:27:56 -08:00
Morgan Haskel
60c0bfb869 Merge pull request #679 from elricsfate/master
Modified Line 49 and 220 to fix broken links
2015-02-27 12:09:49 -08:00
Morgan Haskel
7a3fe1ca00 Merge pull request #617 from juniorsysadmin/package-manage-parameter
(MODULES-1143) Add package_manage parameters
2015-02-27 12:06:25 -08:00
Robert T
a1eca5f3a1 Modified Line 49 and 220 to fix broken links 2015-02-27 19:52:56 +00:00
Morgan Haskel
7eea731a3a Merge pull request #678 from hunner/fix_logerror
(MODULES-1804) Allow override of log-error
2015-02-27 10:41:07 -08:00
Hunter Haugen
ce43899af3 (MODULES-1804) Allow override of log-error
The mysqld log-error setting may be passed by override_options, but
server/service.pp was not using the overridden value. This fixes that.
2015-02-27 09:54:00 -08:00
Colleen Murphy
037d30d82c Merge pull request #677 from mhaskel/fix_for_654
PR 654 was incorrectly using stdlib dirname
2015-02-24 12:01:44 -08:00
Morgan Haskel
b630ecae50 Merge pull request #675 from jbondpdx/readme-rev
Readme rev
2015-02-24 11:13:55 -08:00
Morgan Haskel
c1191f1230 PR 654 was incorrectly using stdlib dirname
puppetlabs-mysql has a dependency on stdlib 3.2.0, which does not
include the dirname function.
2015-02-24 11:08:29 -08:00
Igor Galić
e323f69c04 Merge pull request #654 from NoodlesNZ/logbindir
Check for full path for log-bin to stop puppet from managing directory “."
2015-02-24 08:49:11 +01:00