Commit graph

64 commits

Author SHA1 Message Date
Sergio Oliveira
3d4a153797 [BUG] [Critical] Removing extra space after slash
This extra space was breaking the backup script when running with
`backupdatabases`
2014-03-10 08:22:15 -03:00
Robin Gloster
e4d63f7dc6 fix mysql not starting if ssl is not disabled 2014-03-06 14:03:13 +01:00
Robin Gloster
abcea00dcb handle mysql compiled without ssl
mysql doesn't allow ssl=true/false in my.cnf if it hasn't been compiled
with ssl, therefor add a new parameter ssl-disable which makes sure the
template doesn't write anything with ssl to the config.
2014-02-28 21:42:41 +01:00
Igor Galić
63e0da0b71 option to specify a script that runs after backups
This script could be used to sync backups to a central server, or just
to create a file to let external scripts know that backups are
(sucessfully) done and can be picked up.

The postscript option (defaults to false) and can be either a string or
an array of strings. These strings will be directly put into the
mysqlbackup.sh and as such can either be shell commands, or externally
managed files.
2014-02-06 16:44:07 +01:00
John Bond
10f346eaca Add logic to ignore mysql.events 2014-01-30 12:31:21 +01:00
Jim Radford
56e81a38c8 Allow override_options to set an option to undef to completely remove it
allowing reverting to mysql's default value.

Note that previously a value of :undef would have led to a nonsensical
my.cnf file.
2014-01-23 17:34:27 -08:00
Jim Radford
136b1aa646 Allow options with values of false to override things that mysql default to true
instead of being elided, leaving the default.
2014-01-23 16:53:57 -08:00
Jim Radford
08e8477e96 Noop indent and cleanup the my.cnf template 2014-01-23 16:17:51 -08:00
Guillaume Coré
dae8018520 Support multiple lines of the same option
Some MySQL options need to be passed several times. For example :

  http://dev.mysql.com/doc/refman/5.5/en/replication-options-slave.html#option_mysqld_replicate-do-db

  This is currently impossible with the override_options. This patch allows to
  pass array as value. Example :

    override_options => {
      'client' => {
        'password' => 'xxx',
      },
      'mysqld' => {
        'bind_address'    => '0.0.0.0',
        'replicate-do-db' => ['base1', 'base2', 'base3'],
      },
    }

  Which will be evaluated into :

    [client]
    password = xxx

    [mysqld]
    bind_address = 0.0.0.0
    replicate-do-db = base1
    replicate-do-db = base2
    replicate-do-db = base3
2013-12-18 16:00:12 -05:00
James Glenn
fc14afe4c0 Some options can not take a argument. Gets rid of the '= true' when an option is set to true. See Issues #338 and #363 2013-11-06 14:21:22 -06:00
Thomas Kenny
52083e6c6a Updated my.cnf template to support items with no values 2013-10-09 07:42:16 -07:00
Ashley Penney
0e7e415029 Use mysql::server::root_password instead of @options. 2013-09-27 10:31:59 -04:00
Ashley Penney
b81f64c8ab Rework templates to rely on the new hash and become vastly less complex. 2013-09-13 13:14:48 -04:00
Ashley Penney
e3843ceb6f Refactor to use mysql::globals.
This initial round of work focuses on adding the concept of
mysql::globals to the module.  This is a shared place to provide all the
data the module needs, and then clients, servers, and providers can all
rely on this information to set things up.

This is being primarily used at first to allow a default_options hash
that contains all the previous parameters and takes a overrides_options
that allows you to then further customize any of the options in my.cnf.
2013-09-09 11:34:39 -04:00
Trey Dockendorf
627699fc49 Add option to mysql::backup to set the backup script to perform a mysqldump on each database to its own file 2013-08-27 15:15:29 -05:00
Casey Feskens
ad479e6a81 Changed backupdatabases default from false to [] 2013-08-15 06:04:14 -07:00
Casey Feskens
359d88175c Added support to back up specified databases only with 'mysqlbackup'
parameter.  Each database is backed up separately to a named file.
2013-08-13 14:44:41 -07:00
Vincent Janelle
afb8561372 Fixing puppetlabs-mysql PR 174 spec tests 2013-07-16 15:01:58 -07:00
ThinkBriK
4edf5d48ec Update my.cnf.pass.erb 2013-07-16 15:00:53 -07:00
Matthew Haughton
6bd91d04c1 Remove redundant my.cnf parameters
The following new `mysql` class replication parameters were added in 0.8.0, however the existing hard coded parameters were not removed from the my.conf.erb template:

- `expire_logs_days`
- `max_binlog_size`
2013-07-15 16:18:12 -04:00
Ashley Penney
b00a6758a2 Simplify a few things. 2013-07-11 19:42:41 -04:00
Ashley Penney
926e94a4cb Merge pull request #170 from omalashenko/master
Harden mysqlbackup.sh script
2013-07-09 16:06:55 -07:00
Daniel De Marco
e12eb0e19f add ft_min_word_len and ft_max_word_len config options 2013-07-04 21:33:53 -04:00
Oleg Malashenko
d7460d4b02 backup: configurable cleanup sequence
$delete_before_dump controls whether old backups to be removed before
creating new one.
2013-07-05 11:27:29 +10:00
Oleg Malashenko
9e2540f4fc Harden mysqlbackup.sh script
* mysql::backup backuprotate parameter sets the number of backups to keep,
   default is 30.

 * Use bash in mysqlbackup.sh to get exit status of mysqldump when piped to
   bzip2. Unfortunately there is no easy portable way to do that.

 * Only delete old backups when current backup finished successfully.

 * Try hard not to delete files that we didn't create (i.e. README or other
   backups).
2013-07-05 11:27:29 +10:00
Lebedev Vadim
9d69afcae7 Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-mysql
Conflicts:
	manifests/config.pp
	spec/classes/mysql_config_spec.rb
2013-07-02 22:11:19 +04:00
Lebedev Vadim
ead86b5a3f Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-mysql
Conflicts:
	manifests/config.pp
2013-07-02 21:26:43 +04:00
Martin Hellmich
3089d3a59b add a maximum connection parameter and set the default to 1000
Conflicts:
	manifests/config.pp
	templates/my.cnf.erb
2013-06-28 10:15:58 +02:00
Lebedev Vadim
a42d5bea53 Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-mysql 2013-06-26 14:06:01 +04:00
Ewoud Kohl van Wijngaarden
59a6fb8097 Quote the password
It is possible to have a # in a password, which is parsed as a comment.
By quoting the password this is no problem.
2013-06-26 11:47:11 +02:00
Hunter Haugen
c459884dc9 Change tmpdir to @tmpdir 2013-06-25 15:06:07 -07:00
Niek Beernink
9dc1b946de make tmpdir configurable 2013-06-25 15:06:07 -07:00
Hunter Haugen
4b900ec44d Update template for #179 2013-06-25 15:03:12 -07:00
Hunter Haugen
a04038efb0 Merge pull request #179 from msmithgu/parameterize-max_allowed_packet
Parameterized max_allowed_packet my.conf config setting, because it is needed to setup puppet-dashboard.
2013-06-25 14:56:53 -07:00
Lebedev Vadim
6c81ea0d24 * Trying fix unit tests for Travis 2013-06-16 19:41:29 +04:00
Lebedev Vadim
b07c67ec18 Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-mysql 2013-06-10 16:36:41 +04:00
Gordon Franke
04fb83f456 fix puppet warning default_engine 2013-05-29 15:16:48 +03:00
Chris Rutter
6194354a7b use of variables w/ out a '@' has been deprecated, and as of 3.2.x Puppet warns about it 2013-05-24 10:01:52 -04:00
Mark Smith-Guerrero
242f6e5881 parameterized previously hardcoded max_allowed_packet config setting 2013-05-06 15:55:53 -04:00
Lebedev Vadim
5ea8e5f920 * Adding server_idparameter to mysql::config`
* Adding `sql_log_bin` parameter to `mysql::config`
* Adding `log_bin` parameter to `mysql::config`
* Adding `max_binlog_size` parameter to `mysql::config`
* Adding `binlog_do_db` parameter to `mysql::config`
* Adding `expire_logs_days` parameter to `mysql::config`
* Adding `log_bin_trust_function_creators` parameter to `mysql::config`
* Adding `replicate_ignore_table` parameter to `mysql::config`
* Adding `replicate_wild_do_table` parameter to `mysql::config`
* Adding `replicate_wild_ignore_table` parameter to `mysql::config`
* Adding `expire_logs_days`  parameter to `mysql::params`
* Adding `max_binlog_size` parameter to `mysql::params`
2013-04-08 19:23:24 +04:00
Lebedev Vadim
2a1b1e7962 * Adding key_buffer parameter to mysql::config
* Adding `thread_stack` parameter to `mysql::config`
* Adding `thread_cache_size` parameter to `mysql::config`
* Adding `myisam-recover` parameter to `mysql::config`
* Adding `query_cache_limit` parameter to `mysql::config`
* Adding `query_cache_size` parameter to `mysql::config`
* Adding `max_connections` parameter to `mysql::config`
* Adding `tmp_table_size` parameter to `mysql::config`
* Adding `table_open_cache` parameter to `mysql::config`
* Adding `long_query_time` parameter to `mysql::config`
* Updating mysql_config spec tests
* Fixing lint warnings
2013-04-08 00:20:36 +04:00
Lebedev Vadim
e3b6de2da2 Implement character_set. You can change the default server and
client character set
2013-04-04 14:02:58 +04:00
Steffen Zieger
2e0cbb47ba allow logging via syslog 2012-11-16 20:37:14 +01:00
Hunter Haugen
d212c87f0a Tweak template spacing to pass spec tests with clean output 2012-09-26 13:41:00 -07:00
Justin Brown
af30a52182 Backup Compression Optional
Added a parameter to mysql::backup to make bzip2 compression
optional. Compression is enabled by default, so current behavior
is not affected.

Rationale:
We are storing our MySQL backups on a system with deduplication.
Compression and dedup do not play well together, so it's advantagous
to be able to disable it.
2012-09-26 13:40:59 -07:00
Hunter Haugen
0e4de09934 Merge pull request #93 from Savar/master
new config define and a small bugfix
2012-08-29 11:54:58 -07:00
Hunter Haugen
036b97870b Update bind_address conditional for false 2012-08-23 18:30:37 -07:00
Luis Munoz
80521e12b6 Add posiblity to UNSET bind-address 2012-08-23 18:20:35 -07:00
Eugene Kirpichov
6869b77541 Parameterized pidfile; critical for successful first restart 2012-08-21 18:32:34 -07:00
Dan Bode
211da13545 Revert "Merge pull request #90 from emonty/master"
This reverts commit 063d72493c, reversing
changes made to 9c10b3a6c3.
2012-08-15 18:03:37 -07:00