Ashley Penney
90c5abc4bb
Add tests for all missing parameters.
...
This commit adds tests for the parameters that were previously untested.
Most of this testing is light, but all parameters of the module are now
called at least once. Generally we're testing the happy path, so these
need further work in future.
2013-12-10 16:56:20 -05:00
Hunter Haugen
0aed9e07f7
Adding beaker-rspec test files
...
These tests are more or less parity with the rspec-system tests, though
dependent on a few patches that still have to make it into beaker and
beaker-rspec
2013-12-06 14:52:41 -08:00
Igor Galić
38dc05a1b6
Merge pull request #375 from ezheidtmann/parameterize-backup-dir-mode
...
Parameterize backup directory mode and ownership
2013-11-17 07:49:56 -08:00
Igor Galić
6ae9bc61d4
Merge pull request #376 from w32-blaster/master
...
Type mysql_grant fixed, spec test created
2013-11-17 07:47:50 -08:00
Tamas Szasz
aee0e01d81
Type mysql_grant was limited to work only with resource names foo@localhost/*.* or foo@localhost/bar.* but NOT with root@localhost/@ which is the parsed value of "GRANT PROXY ON ''@'' TO 'root'@'localhost' WITH GRANT OPTION" grant line.
...
New spec test was created for the type mysql_grant.rb
2013-11-16 19:11:39 +01:00
Evan Heidtmann
c654fe1ba8
Parameterize backup directory mode and ownership
2013-11-15 20:55:21 -08:00
Ashley Penney
353c19dae8
Fix broken test on RedHat.
2013-11-14 18:40:46 -05:00
Ashley Penney
250932245f
How embarrassing, the tests were broken on Debian.
2013-11-12 19:39:08 -05:00
Ashley Penney
29952116ca
Merge pull request #367 from w32-blaster/master
...
Method for loading .my.cnf file is changed from "defaults-file" to "defaults-extra-file" (mysql option)
2013-11-12 13:16:11 -08:00
Tamas Szasz
4ac8879734
Fixed missing parent for global mysql class
...
Added "require" to the global mysql.rb file like in the other provider files.
defaults-file changed to defaults-extra-file in all the database_* (old) providers, the same as in the mysql_* providers.
Changed defaults-file to defaults-extra-file in all test files
2013-11-12 21:32:41 +01:00
Mason Malone
e947eaf6ee
Adding tests for mysql::server::providers
2013-11-11 10:56:55 -05:00
Marc Huffnagle
7ea41249e2
Fix raise_error deprecation warning
2013-10-31 12:42:42 -04:00
Ashley Penney
d271ab5f76
Fix an issue with lowercase privileges.
...
This fixes the case where a user passes in lowercase privileges and
we incorrectly assume this means a change and reapply them.
2013-10-28 12:44:48 -04:00
Ashley Penney
1dae474146
Add a moere complex test case for mysql_grant.
2013-10-10 15:07:47 -07:00
Ashley Penney
ce266fa893
Add in the @host users.
2013-10-08 10:18:14 -07:00
Ashley Penney
cc51d7ad7d
Improve mysql_grant to work with IPv6.
...
This work attempts to improve the situation for matching IPv6
IP addresses, as the previous regex couldn't handle them properly.
2013-10-07 11:57:02 -07:00
Ashley Penney
5d17f10f93
Port of a6101dc (mysql::server::monitor fix) to 2.x.
2013-10-07 09:55:13 -04:00
Ashley Penney
1d59505425
Extend coverage to the contents of /etc/my.cnf.
2013-10-04 14:47:31 -04:00
Ashley Penney
4a48d639f2
Add testing for mysql::server::root_password.
2013-10-04 13:22:21 -04:00
Ashley Penney
f8af684fe0
Merge pull request #276 from apenney/mysql_grant_fixes
...
Improvements to mysql_grant.
2013-10-02 09:54:09 -07:00
Nate Riffe
602ec1354f
Adjust the test to the new reality
2013-09-29 18:44:49 -05:00
Justin Burnham
1b4a486bf9
Fixes issue #274 by using recursive hash merge.
2013-09-25 10:38:08 -07:00
Ashley Penney
46fe1ea512
Remove mysql::globals.
...
This turned out to be a fairly bad idea. It begun as a way to try
and mirror what happens in the postgresql module for consistency
but instead made things complex.
I've changed it to have the override_options in mysql::server which
leads much more naturally out of the design and shape of MySQL.
2013-09-24 18:04:29 -04:00
Ashley Penney
003d5b3c6a
Improvements to mysql_grant.
...
Ensure that table and user are required properties, as well as remove
the optional table handling in the provider and enforce it.
2013-09-24 15:37:11 -04:00
Ashley Penney
ce893b5115
Fix spec tests on ruby 1.8.
2013-09-13 13:42:32 -04:00
Ashley Penney
803034e880
Rewrite spec tests to account for changes.
2013-09-13 13:14:48 -04:00
Ashley Penney
e3843ceb6f
Refactor to use mysql::globals.
...
This initial round of work focuses on adding the concept of
mysql::globals to the module. This is a shared place to provide all the
data the module needs, and then clients, servers, and providers can all
rely on this information to set things up.
This is being primarily used at first to allow a default_options hash
that contains all the previous parameters and takes a overrides_options
that allows you to then further customize any of the options in my.cnf.
2013-09-09 11:34:39 -04:00
Ashley Penney
2abccab4d9
Refactor and rename database_grant to mysql_grant.
...
This provider has undergone the largest set of changes and currently
just accepts a full SQL grant string as the name and then applies it,
making things easier for DBAs and removes the awkward attempts at
modelling grants into Puppet.
2013-09-03 17:24:21 -04:00
Ashley Penney
351c722fbd
Add rspec-system test for mysql_user.
2013-08-28 18:11:21 -04:00
Ashley Penney
88eea1708e
Add simplecov support in order to generate test coverage.
2013-08-28 18:11:21 -04:00
Ashley Penney
596d005a98
Rework tests for mysql_password to extend coverage.
2013-08-28 18:11:21 -04:00
Ashley Penney
369c83126b
Use new provider names in manifests.
...
Modify manifests and tests to handle the renamed providers.
2013-08-28 18:11:21 -04:00
Ashley Penney
16770faa29
Rename and refactor database_user to mysql_user.
...
This work adds max_connections_per_hour, max_queries_per_hour, and
max_updates_per_hour support to the provider and extends self.instances to add
in the new parameters when checking existing users. It also adds
self.prefetch in order to speed up Puppet runs.
Provider is also switched to using mk_resource_methods to generate
all the resource readers, and exists? and other methods now use the
property_hash where appropriate.
Tests rewritten to handle changes and extend code coverage.
2013-08-28 18:11:21 -04:00
Ashley Penney
7d4f9fc685
Rename and refactor database to mysql_database.
...
Add collate as a new managable parameter, and extend self.instances to
add in all parameters when checking existing databases. It also adds
self.prefetch in order to speed up Puppet runs.
Provider is also switched to using mk_resource_methods to generate
all the resource readers, and exists? and other methods now use the
property_hash where appropriate.
Tests rewritten to handle changes and extend code coverage.
2013-08-28 18:11:21 -04:00
Trey Dockendorf
627699fc49
Add option to mysql::backup to set the backup script to perform a mysqldump on each database to its own file
2013-08-27 15:15:29 -05:00
Ashley Penney
40db3e801d
Merge pull request #244 from willametteuniversity/master
...
Added support to back up specified databases only with 'mysqlbackup'
2013-08-27 09:26:25 -07:00
Casey Feskens
359d88175c
Added support to back up specified databases only with 'mysqlbackup'
...
parameter. Each database is backed up separately to a named file.
2013-08-13 14:44:41 -07:00
Hunter Haugen
82c4b81ba3
Add environment variable for .my.cnf and specs
2013-08-13 13:08:39 -07:00
Ashley Penney
7c7195ba33
Refactor MySQL bindings and client packages.
...
The current MySQL module is hard to modify, test, and drop in
replacement components to. This work starts out by refactoring
the bindings support in MySQL to a completely seperate bindings
class in order to reduce the amount of parameters in the main
class for a feature that is infrequently used.
In addition to this start the movement of client configuration
and packages to the mysql::client::* namespace.
2013-07-19 18:39:55 -04:00
Vincent Janelle
afb8561372
Fixing puppetlabs-mysql PR 174 spec tests
2013-07-16 15:01:58 -07:00
Ashley Penney
cc58668d19
Various fixes suggested by RubyMine. (style for the most part).
2013-07-11 19:41:42 -04:00
Ashley Penney
1bd970d8e5
Merge pull request #215 from mbakke/max_connections
...
Support max_user_connections in database_user
2013-07-10 07:40:23 -07:00
Marius Bakke
f3b3a7e39f
fix database_user tests after changing creation method
2013-07-10 10:23:02 +02:00
Ashley Penney
588af2a89d
Merge pull request #218 from hunner/rspec_system_serverspec
...
Add rspec-system / serverspec tests
2013-07-09 16:15:17 -07:00
Ashley Penney
926e94a4cb
Merge pull request #170 from omalashenko/master
...
Harden mysqlbackup.sh script
2013-07-09 16:06:55 -07:00
Marius Bakke
5f3708ff24
add spec for max_user_connections on database_user
2013-07-08 17:49:59 +02:00
Martin Magr
e3d74a65b0
Use $root_home for .my.cnf
2013-07-08 11:49:30 +02:00
Hunter Haugen
c34bcc0f73
Add rspec-system / serverspec tests
2013-07-05 15:19:02 -07:00
Ashley Penney
4d811e4704
Add basic specs for database provider.
2013-07-05 15:04:04 -04:00
Ashley Penney
d35261dc16
Tweak spec file to account for days of rotation.
2013-07-05 12:32:19 -04:00
Daniel De Marco
e12eb0e19f
add ft_min_word_len and ft_max_word_len config options
2013-07-04 21:33:53 -04:00
Oleg Malashenko
1521a2ea4f
Fixed tests for mysqlbackup.sh
2013-07-05 11:27:29 +10:00
Ashley Penney
8bf03681f3
Various changes to the provider to ensure commands are successful,
...
as well as improvements to the tests.
2013-07-03 16:08:48 -04:00
Ashley Penney
00130ef6c6
Add initial spec tests for database_user.
2013-07-03 13:22:48 -04:00
Ashley Penney
e961b83226
Fix spelling of privileges across the spec file.
2013-07-02 16:57:36 -04:00
Lebedev Vadim
9d69afcae7
Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-mysql
...
Conflicts:
manifests/config.pp
spec/classes/mysql_config_spec.rb
2013-07-02 22:11:19 +04:00
Ashley Penney
aa5d1f070b
Merge pull request #198 from mhellmic/maxconnections
...
add a maximum connection parameter and set the default to 1000
2013-07-02 10:43:29 -07:00
Lebedev Vadim
6cef2e8af4
Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-mysql
2013-07-02 21:42:49 +04:00
Ashley Penney
f3e5c89551
Merge pull request #187 from RsrchBoy/topic/perl
...
add mysql::perl helper class
2013-07-02 10:37:10 -07:00
Lebedev Vadim
ead86b5a3f
Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-mysql
...
Conflicts:
manifests/config.pp
2013-07-02 21:26:43 +04:00
Simon Effenberg
7f7e886d71
handling of my.cnf config file is now optional
...
This adds a parameter (default value is like old behavior) so that the
my.cnf file isn't managed (created/updated) by the mysql module at all
which is necessary for our environment. We need to set all parameters by
ourself. If we don't set a parameter then the default from the mysqld
binary should be used instead of any default parameter the mysql module
provides us.
2013-07-02 10:01:21 +02:00
Martin Hellmich
880eaae3e8
changed the max_connections default to 151
...
this is the default according to the mysql manual.
https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_max_connections
2013-06-28 11:21:58 +02:00
Martin Hellmich
1263d89a98
changed the test accordingly to the new max-connections parameter
...
Conflicts:
spec/classes/mysql_config_spec.rb
2013-06-28 11:03:36 +02:00
Lebedev Vadim
a42d5bea53
Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-mysql
2013-06-26 14:06:01 +04:00
Ewoud Kohl van Wijngaarden
59a6fb8097
Quote the password
...
It is possible to have a # in a password, which is parsed as a comment.
By quoting the password this is no problem.
2013-06-26 11:47:11 +02:00
Hunter Haugen
a04038efb0
Merge pull request #179 from msmithgu/parameterize-max_allowed_packet
...
Parameterized max_allowed_packet my.conf config setting, because it is needed to setup puppet-dashboard.
2013-06-25 14:56:53 -07:00
Hunter Haugen
16affe5af8
Merge pull request #199 from hunner/ansi_quotes
...
Fix SQL when ANSI_QUOTES is enabled in mysql config.
2013-06-25 10:22:00 -07:00
Hunter Haugen
d68aa838e4
Update specs for ansi quoting
2013-06-24 14:51:12 -07:00
Steve Traylen
b9b122e65a
change the distribution osfamily from Redhat into RedHat
2013-06-24 16:24:50 +02:00
Lebedev Vadim
6c81ea0d24
* Trying fix unit tests for Travis
2013-06-16 19:41:29 +04:00
Lebedev Vadim
1a13580f49
Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-mysql
...
Conflicts:
manifests/config.pp
manifests/params.pp
2013-05-21 20:40:50 +04:00
Lebedev Vadim
a171c52a89
* Puppet 2.6 fix
2013-05-21 01:21:38 +04:00
Mark Smith-Guerrero
7f94bc3c97
added spec test for parameterized max_allowed_packet
2013-05-06 15:54:47 -04:00
Chris Weyl
0dec443517
mysql::perl tests
2013-05-03 09:25:31 -07:00
Francois Deppierraz
a555848e7d
Test to avoid broken default-storage-engine settings
2013-04-26 00:30:09 +02:00
Wolf Noble
0f6886bd99
Refactor of classes to put everything as a param to mysql to prepare for autoloading from hiera
...
put a handle on all the params of the class in init.pp so that they can be autoloaded from hiera, and easily fed to the class from a profile class
2013-04-09 13:45:55 -05:00
Lebedev Vadim
5ea8e5f920
* Adding server_idparameter to
mysql::config`
...
* Adding `sql_log_bin` parameter to `mysql::config`
* Adding `log_bin` parameter to `mysql::config`
* Adding `max_binlog_size` parameter to `mysql::config`
* Adding `binlog_do_db` parameter to `mysql::config`
* Adding `expire_logs_days` parameter to `mysql::config`
* Adding `log_bin_trust_function_creators` parameter to `mysql::config`
* Adding `replicate_ignore_table` parameter to `mysql::config`
* Adding `replicate_wild_do_table` parameter to `mysql::config`
* Adding `replicate_wild_ignore_table` parameter to `mysql::config`
* Adding `expire_logs_days` parameter to `mysql::params`
* Adding `max_binlog_size` parameter to `mysql::params`
2013-04-08 19:23:24 +04:00
Lebedev Vadim
2a1b1e7962
* Adding key_buffer
parameter to mysql::config
...
* Adding `thread_stack` parameter to `mysql::config`
* Adding `thread_cache_size` parameter to `mysql::config`
* Adding `myisam-recover` parameter to `mysql::config`
* Adding `query_cache_limit` parameter to `mysql::config`
* Adding `query_cache_size` parameter to `mysql::config`
* Adding `max_connections` parameter to `mysql::config`
* Adding `tmp_table_size` parameter to `mysql::config`
* Adding `table_open_cache` parameter to `mysql::config`
* Adding `long_query_time` parameter to `mysql::config`
* Updating mysql_config spec tests
* Fixing lint warnings
2013-04-08 00:20:36 +04:00
Matt Rogers
b42d4355f0
fix mocha deprecation warnings
2013-02-28 22:36:11 -06:00
Paul Chechetin
90947afd2f
Fix tests for Puppet 3.0 target
2013-02-18 15:03:18 +04:00
Hunter Haugen
6b9a5efc0a
Add tests for absent /root/.my.cnf
2013-01-10 15:55:42 -08:00
Hunter Haugen
cea77802ac
Updating specs for .my.cnf
2013-01-10 15:31:21 -08:00
Hunter Haugen
02c4da48a5
Add php support
...
PHP libraries are required by many apps. This class assumes 'normal'
names for these packages, but allows other packages names to be passed
for variances such as 'php53-mysql' on RedHat and FreeBSD.
2013-01-04 10:59:17 -08:00
Ryan Coleman
5a167c9eef
Merge pull request #125 from bodepd/create_my_cnf
...
Create /root/.my.cnf even when root passwd is not managed
2012-10-13 10:14:23 -07:00
Ryan Coleman
bb4f15b8fe
Merge pull request #117 from hunner/optional_compression
...
Mysql::backup Compression Optional
2012-10-13 10:09:55 -07:00
Dan Bode
765b5c2527
Create /root/.my.cnf even when root passwd is not managed
...
When the root password is not managed, it causes mysql to
fail b/c it does not create the /root/.my.cnf file (which causes
all mysql commands from the provider to fail)
2012-10-13 02:35:38 -07:00
Hunter Haugen
64d38890c6
Add mysql argument to use mysql database back
2012-10-09 14:02:05 -07:00
Hunter Haugen
24444ce119
Stub the $root_home fact
2012-10-09 14:00:09 -07:00
Nate Riffe
bdb416053a
Use root's credentials when executing mysql.
...
This is necessary when running puppet as root using sudo because mysql
will still look in the user's home directory in that case unless told
otherwise.
2012-10-09 13:59:58 -07:00
Hunter Haugen
81889c9992
Adding specs for manage_service parameter
2012-10-04 16:27:06 -07:00
Hunter Haugen
6a7d84369e
Add spec tests for backup compression enabled/disabled
2012-09-26 13:40:59 -07:00
Hunter Haugen
d98efe3b7a
Merge pull request #113 from janoszen/ipv6
...
IPv6
2012-09-05 11:01:12 -07:00
Janos Pasztor
e77576d8e7
Added spec for IPv6 changes as requested by upstream
2012-09-05 09:58:42 +02:00
Hunter Haugen
8b9f17348c
Update mysql::backup privs for #108
2012-09-04 17:04:26 -07:00
Hunter Haugen
0e4de09934
Merge pull request #93 from Savar/master
...
new config define and a small bugfix
2012-08-29 11:54:58 -07:00
Simon Effenberg
e47b4d19e7
fixed documentation and added rspec
...
* fixed a typo in the documentation
* added documentation for parameter +notify_service+
* added rspec test
2012-08-24 08:01:33 +02:00
Hunter Haugen
bfd19998d1
Merge pull request #101 from martasd/manage-db-status
...
Added an option to specify db status.
2012-08-22 11:30:46 -07:00
Eugene Kirpichov
6869b77541
Parameterized pidfile; critical for successful first restart
2012-08-21 18:32:34 -07:00
Martin Dluhos
04537908a9
Added an option to specify db status.
2012-08-21 15:40:42 -07:00
Michael Arnold
605fa718e1
Escape $root_password during execs.
...
Some characters used in a password can cause the shell in an exec to do
unexpected things unless the password is enclosed in single quotes.
Updated the rspec tests to deal with the password quoting.
2012-08-09 00:34:09 -07:00