Commit graph

1251 commits

Author SHA1 Message Date
Igor Galić
3cd0938800 Merge pull request #426 from radford/my-cnf-false
Allow an option with a value of false to override something that mysql defaults to true rather than eliding it
2014-01-24 10:59:16 -08:00
Jim Radford
16baff686c mysql_deepmerge should treat underscore and dash equivalently, as mysql does 2014-01-23 22:41:58 -08:00
Jim Radford
56e81a38c8 Allow override_options to set an option to undef to completely remove it
allowing reverting to mysql's default value.

Note that previously a value of :undef would have led to a nonsensical
my.cnf file.
2014-01-23 17:34:27 -08:00
Jim Radford
136b1aa646 Allow options with values of false to override things that mysql default to true
instead of being elided, leaving the default.
2014-01-23 16:53:57 -08:00
Jim Radford
08e8477e96 Noop indent and cleanup the my.cnf template 2014-01-23 16:17:51 -08:00
Hunter Haugen
f348e12a37 Merge pull request #425 from radford/fix-service-provider
Actually use upstart on Ubuntu by fixing misspelled variable name
2014-01-23 13:39:38 -08:00
Jim Radford
dabb29dd6e Actually use upstart on Ubuntu by fixing misspelled variable name 2014-01-23 13:01:08 -08:00
Hunter Haugen
ba0ef0497e Merge pull request #424 from ghoneycutt/test_puppet_3_4
Test against Puppet v3.4.0
2014-01-23 11:09:37 -08:00
Hunter Haugen
9662dfd07f Merge pull request #423 from ghoneycutt/travis_enable_fast_finish
Enable fast finish in Travis
2014-01-23 11:09:19 -08:00
Garrett Honeycutt
708d8eff5a Test against Puppet v3.4.0 2014-01-23 14:05:13 -05:00
Garrett Honeycutt
23f64bbd8d Enable fast finish in Travis
http://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
2014-01-23 14:03:47 -05:00
Steve Saliman
21aca48e02 fixed a problem with the mysql_database provider 2014-01-22 12:44:59 -07:00
Igor Galić
aa3e1d62cf Merge pull request #412 from n1tr0g/master
mysql_grant fixed to properly handle PROCEDURE grants
2014-01-22 09:48:50 -08:00
Igor Galić
5a93c7bc56 Merge pull request #421 from lboynton/patch-1
Remove duplicate service_provider description
2014-01-22 09:20:28 -08:00
Lee Boynton
a5887080e0 Remove duplicate service_provider description
The `service_provider` parameter was explained in the README twice, so I've removed one of them.
2014-01-20 17:19:59 +00:00
Dejan Golja
4f12b0c7f9 Add system test to cover procedure creation scenario 2014-01-20 23:56:26 +11:00
Dejan Golja
ce7b661f10 Bugfix for mysql_grant provider when we try to grant remove privileges
on PROCEDURE. Resolve for bug https://tickets.puppetlabs.com/browse/MODULES-130
(https://github.com/puppetlabs/puppetlabs-mysql/issues/378)
2014-01-20 23:56:26 +11:00
Ashley Penney
8a6f74fdb7 Merge pull request #410 from laurenrother/readme
Update README
2014-01-15 16:41:30 -08:00
Lauren Rother
2091b8b8cf Changes '[version]' and paragraph about override options
Changes '[version]' to 'x.y.z' based on feedback from ashp. Adds additional options to override options paragraphs.
2014-01-08 14:44:03 -08:00
Lauren Rother
c752a3da8f Update README
Edits sentences for spelling, capitalization, and grammar. Edits sentences for contextual consistency and clarity. Adds some missing descriptions.
2014-01-08 13:48:19 -08:00
Igor Galić
e667d52c91 Merge pull request #407 from johnsyweb/fix-documentation
Fix documentation
2014-01-02 16:30:36 -08:00
Ashley Penney
961cece2f9 Merge pull request #408 from zacharyalexstern/master
Fixed typo.
2013-12-27 19:25:00 -08:00
Zachary Alex Stern
0f3664f764 Fixed typo.
Noticed typo, figured I'd fix it.
2013-12-27 14:30:34 -08:00
Pete Johns
85afc5ca95 Fix typos 2013-12-27 19:48:27 +11:00
Pete Johns
52396510e8 s/options_override/override_options/g to prevent confusion 2013-12-27 19:43:35 +11:00
Ashley Penney
edfaeccfa8 Merge pull request #394 from danielfoglio/master
changed log_error to log-error and pid_file to pid-file to match the mys...
2013-12-19 16:39:56 -08:00
Ashley Penney
2df5aee8d5 Merge pull request #403 from apenney/fix-tests
Minor fix to beaker tests.
2013-12-19 16:36:02 -08:00
Ashley Penney
8c64e812d9 Minor fix to beaker tests. 2013-12-19 19:35:20 -05:00
Ashley Penney
c081327b1f Merge pull request #397 from srinathman/feature-create-db-if-exists
Added [if not exists] to [create database] clause.
2013-12-19 16:12:16 -08:00
Igor Galić
d5fd46de59 Merge pull request #400 from duritong/fix_backupuser_dependency
Fix backupuser dependency
2013-12-18 22:13:27 -08:00
Ashley Penney
3736fcb718 Merge pull request #398 from fridim/support_multiple_values_in_config
Support multiple lines of the same option
2013-12-18 13:41:32 -08:00
Guillaume Coré
dae8018520 Support multiple lines of the same option
Some MySQL options need to be passed several times. For example :

  http://dev.mysql.com/doc/refman/5.5/en/replication-options-slave.html#option_mysqld_replicate-do-db

  This is currently impossible with the override_options. This patch allows to
  pass array as value. Example :

    override_options => {
      'client' => {
        'password' => 'xxx',
      },
      'mysqld' => {
        'bind_address'    => '0.0.0.0',
        'replicate-do-db' => ['base1', 'base2', 'base3'],
      },
    }

  Which will be evaluated into :

    [client]
    password = xxx

    [mysqld]
    bind_address = 0.0.0.0
    replicate-do-db = base1
    replicate-do-db = base2
    replicate-do-db = base3
2013-12-18 16:00:12 -05:00
Hunter Haugen
8fbd595f89 Merge pull request #401 from apenney/restart
Restart
2013-12-18 12:22:21 -08:00
Ashley Penney
c32ae645e0 Apparently we were restarting no matter what the parameter said,
awkward.
2013-12-18 15:12:04 -05:00
Ashley Penney
5bba2e04b3 Add a comment to make this clearer. 2013-12-18 14:13:00 -05:00
Ashley Penney
ce77d067ef Fix a few tests. 2013-12-18 14:13:00 -05:00
Ashley Penney
b7dcdd1714 Add $restart support.
Previously this parameter did nothing, lets make it actually work.
2013-12-18 13:59:56 -05:00
mh
c57aa23e6f Use https url to make puppet-librarian more proxy-friendly
For people in restricted networks it's quite common to not
be able to use git:// urls, but https-urls work through proxies.
2013-12-18 13:36:49 +01:00
mh
765afe4f61 Fix #321 - root_user should be setup before configuring backup user
Otherwise puppet might try to setup the backup user even before
the service is running and will fail.
2013-12-18 13:35:20 +01:00
Foglio, Daniel
3d98b1de0d changed log_error to log-error and pid_file to pid-file to match the mysqld service script 2013-12-17 17:39:04 -05:00
Srinath M
a571df4c79 Fixed testing for creating a DB with the [if not exists] clause 2013-12-16 09:59:43 -05:00
Srinath M
1cc07977c5 Added [if not exists] to [create database] clause.
this should avoid errors like:
ERROR 1007 (HY000): Can't create database 'MyDB'; database exists

This error can cause a multi-master replication to stop due to conflicting
commands between nodes. For  example, if the command create DB is run in
 different nodes and then they will send it in the replication logs to each
other and then they will try to run them second time and fail.
2013-12-15 21:47:10 -05:00
Igor Galić
62eb73db07 Merge pull request #395 from doc75/fixes_my_cnf
my.cnf: typo fix (bind-address) + migrate key_buffer (deprecated) to key_buffer_size
2013-12-15 04:50:25 -08:00
Guillaume Virlet
3da12ac622 migrate key_buffer (deprecated) to key_buffer_size in config_file 2013-12-14 23:15:13 +01:00
Guillaume Virlet
9460db2ec1 fix typo on bind-address in config_file 2013-12-14 23:14:01 +01:00
Ashley Penney
9603d9a8aa Merge pull request #390 from apenney/add-more-tests
Add tests for all missing parameters.
2013-12-11 08:22:21 -08:00
Ashley Penney
50f0ef8477 Merge pull request #391 from vicinus/mysql_grant_fixes
Mysql grant fixes
2013-12-11 07:18:28 -08:00
Reinhard Vicinus
07c3b76eb9 mysql_grant bugfix: remove duplicate privileges and GRANT privilege, otherwise the resource gets changed every puppet run 2013-12-11 13:17:52 +01:00
Reinhard Vicinus
9de42ac43e mysql_grant bugfix: REVOKE ALL PRIVILEGES doesn't revoke GRANT OPTION 2013-12-11 13:16:14 +01:00
Reinhard Vicinus
f5a78f1c5f mysql_grant bugfix: on table *.* SHOW GRANT can return 'WITH MAX_QUERIES_PER_HOUR' which breaks the captures on the match 2013-12-11 13:15:21 +01:00