opuppet/puppetlabs-stdlib
4
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
puppetlabs-stdlib/spec/functions/getvar_spec.rb

29 lines
1.2 KiB
Ruby
Raw Normal View History

(Maint) use PuppetlabsSpec::PuppetSeams.parser_scope Without this patch all of the spec tests for parser functions in stdlib would instantiate their own scope instances. This is a problem because the standard library is tightly coupled with the internal behavior of Puppet. Tight coupling like this creates failures when we change the internal behavior of Puppet. This is exactly what happened recently when we changed the method signature for the initializer of Puppet::Parser::Scope instances. This patch fixes the problem by creating scope instances using the puppet labs spec helper. The specific method that provides scope instances in Puppet-version-independent way is something like this: let(:scope) { PuppetlabsSpec::PuppetSeams.parser_scope } This patch simply implements this across the board.
2012-07-20 01:14:37 +02:00
require 'spec_helper'
(#8010) Add getvar() rvalue function This isn't directly related to #8010, but rather indirectly fills the need to allow the end user to configure where data values are looked up. This allows the namespace to be passed as a class parameter. A module may then quickly and easily look up data from the user-defined namespace.
2011-06-21 23:10:33 +02:00
Convert tests to use plain rspec-puppet Tests in the new style produces the following documentation output: abs should not eq nil should run abs() and raise an Puppet::ParseError should run abs(-34) and return 34 should run abs("-34") and return 34 should run abs(34) and return 34 should run abs("34") and return 34
2015-06-01 13:21:59 +02:00
describe 'getvar' do
it { is_expected.not_to eq(nil) }
it { is_expected.to run.with_params().and_raise_error(Puppet::ParseError, /wrong number of arguments/i) }
it { is_expected.to run.with_params('one', 'two').and_raise_error(Puppet::ParseError, /wrong number of arguments/i) }
it { is_expected.to run.with_params().and_raise_error(Puppet::ParseError, /wrong number of arguments/i) }
(#8010) Add getvar() rvalue function This isn't directly related to #8010, but rather indirectly fills the need to allow the end user to configure where data values are looked up. This allows the namespace to be passed as a class parameter. A module may then quickly and easily look up data from the user-defined namespace.
2011-06-21 23:10:33 +02:00
Convert tests to use plain rspec-puppet Tests in the new style produces the following documentation output: abs should not eq nil should run abs() and raise an Puppet::ParseError should run abs(-34) and return 34 should run abs("-34") and return 34 should run abs(34) and return 34 should run abs("34") and return 34
2015-06-01 13:21:59 +02:00
context 'given variables in namespaces' do
let(:pre_condition) {
<<-'ENDofPUPPETcode'
class site::data { $foo = 'baz' }
include site::data
ENDofPUPPETcode
}
Use rvalue functions correctly A bug fix in Puppet exposed that several tests were using rvalue functions incorrectly (this was not properly checked by puppet before). This fixes those tests.
2012-08-09 23:18:30 +02:00
Convert tests to use plain rspec-puppet Tests in the new style produces the following documentation output: abs should not eq nil should run abs() and raise an Puppet::ParseError should run abs(-34) and return 34 should run abs("-34") and return 34 should run abs(34) and return 34 should run abs("34") and return 34
2015-06-01 13:21:59 +02:00
it { is_expected.to run.with_params('site::data::foo').and_return('baz') }
it { is_expected.to run.with_params('::site::data::foo').and_return('baz') }
context 'with strict variable checking', :if => RSpec.configuration.strict_variables do
it { is_expected.to run.with_params('::site::data::bar').and_raise_error(ArgumentError, /undefined_variable/) }
(#8010) Add getvar() rvalue function This isn't directly related to #8010, but rather indirectly fills the need to allow the end user to configure where data values are looked up. This allows the namespace to be passed as a class parameter. A module may then quickly and easily look up data from the user-defined namespace.
2011-06-21 23:10:33 +02:00
end
Convert tests to use plain rspec-puppet Tests in the new style produces the following documentation output: abs should not eq nil should run abs() and raise an Puppet::ParseError should run abs(-34) and return 34 should run abs("-34") and return 34 should run abs(34) and return 34 should run abs("34") and return 34
2015-06-01 13:21:59 +02:00
context 'without strict variable checking', :unless => RSpec.configuration.strict_variables do
it { is_expected.to run.with_params('::site::data::bar').and_return(nil) }
(#8010) Add getvar() rvalue function This isn't directly related to #8010, but rather indirectly fills the need to allow the end user to configure where data values are looked up. This allows the namespace to be passed as a class parameter. A module may then quickly and easily look up data from the user-defined namespace.
2011-06-21 23:10:33 +02:00
end
end
end
Reference in a new issue Copy permalink