opuppet/puppetlabs-stdlib
4
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

(maint) Memoize scope in domain_name spec

Browse source 
This is an opportunity improvement since I'm in the code.  Get rid of
instance variables in the spec test and replace them with a memo let
method block.
This commit is contained in:
Jeff McCune 2012-01-11 18:55:21 -08:00
parent dc674419ae
commit 39d28497a3
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
spec/unit/puppet/parser/functions/is_domain_name_spec.rb
View file

@ -6,51 +6,48 @@ describe "the is_domain_name function" do
Puppet::Parser::Functions.autoloader.loadall
end
before :each do
@scope = Puppet::Parser::Scope.new
end
let(:scope) { Puppet::Parser::Scope.new }
it "should exist" do
Puppet::Parser::Functions.function("is_domain_name").should == "function_is_domain_name"
end
it "should raise a ParseError if there is less than 1 arguments" do
lambda { @scope.function_is_domain_name([]) }.should( raise_error(Puppet::ParseError))
lambda { scope.function_is_domain_name([]) }.should( raise_error(Puppet::ParseError))
end
it "should return true if a valid domain name" do
result = @scope.function_is_domain_name(["foo.bar.com"])
result = scope.function_is_domain_name(["foo.bar.com"])
result.should(be_true)
end
it "should allow domain parts to start with numbers" do
result = @scope.function_is_domain_name(["3foo.2bar.com"])
result = scope.function_is_domain_name(["3foo.2bar.com"])
result.should(be_true)
end
it "should allow domain to end with a dot" do
result = @scope.function_is_domain_name(["3foo.2bar.com."])
result = scope.function_is_domain_name(["3foo.2bar.com."])
result.should(be_true)
end
it "should allow a single part domain" do
result = @scope.function_is_domain_name(["orange"])
result = scope.function_is_domain_name(["orange"])
result.should(be_true)
end
it "should return false if domain parts start with hyphens" do
result = @scope.function_is_domain_name(["-3foo.2bar.com"])
result = scope.function_is_domain_name(["-3foo.2bar.com"])
result.should(be_false)
end
it "should return true if domain contains hyphens" do
result = @scope.function_is_domain_name(["3foo-bar.2bar-fuzz.com"])
result = scope.function_is_domain_name(["3foo-bar.2bar-fuzz.com"])
result.should(be_true)
end
it "should return false if domain name contains spaces" do
result = @scope.function_is_domain_name(["not valid"])
result = scope.function_is_domain_name(["not valid"])
result.should(be_false)
end
end