opuppet/puppetlabs-stdlib
4
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Moved to unless from if not to improve code clarity. Added TODO

Browse source 
for future reference.  Changed wording of few error messages.

Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
This commit is contained in:
Krzysztof Wilczynski 2011-04-30 02:48:25 +01:00
parent 9ec50e7968
commit 3c4c1c7c20
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
num2bool.rb
View file

@ -2,6 +2,8 @@
# num2bool.rb
#
# TODO(Krzysztof Wilczynski): We probably need to approach numeric values differently ...
module Puppet::Parser::Functions
newfunction(:num2bool, :type => :rvalue, :doc => <<-EOS
EOS
@ -13,20 +15,20 @@ module Puppet::Parser::Functions
number = arguments[0]
# Only numbers allowed ...
if not number.match(/^\-?\d+$/)
raise(Puppet::ParseError, 'num2bool(): Requires a number to work with')
unless number.match(/^\-?\d+$/)
raise(Puppet::ParseError, 'num2bool(): Requires integer to work with')
end
result = case number
when /^0$/
false
when /^\-?\d+$/
# In Puppet numbers are often string-encoded ...
# Numbers in Puppet are often string-encoded which is troublesome ...
number = number.to_i
# We yield true for any positive number and false otherwise ...
number > 0 ? true : false
else
raise(Puppet::ParseError, 'num2bool(): Unknown number format given')
raise(Puppet::ParseError, 'num2bool(): Unknown numeric format given')
end
return result