opuppet/puppetlabs-stdlib
4
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Adding more error checking ...

Browse source 
Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
This commit is contained in:
Krzysztof Wilczynski 2011-04-24 20:55:35 +01:00
parent eefd7a9fc4
commit 4a72b0efde
1 changed files with 18 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
collect_indices.rb
View file

@ -11,6 +11,7 @@ module Puppet::Parser::Functions
"given (#{arguments.size} for 2)") if arguments.size < 2
array = arguments.shift
array_size = array.size
if not array.is_a?(Array)
raise(Puppet::ParseError, 'Requires an array to work with')
@ -29,17 +30,29 @@ module Puppet::Parser::Functions
start = m[1].to_i
stop = m[2].to_i
if start > stop
raise(Puppet::ParseError, 'Stop index in given indices range ' +
'is smaller than the start index') if start > stop
'is smaller than the start index')
elsif stop > array_size - 1 # First element is at index 0 is it not?
raise(Puppet::ParseError, 'Stop index in given indices range ' +
'exceeds array size')
end
(start .. stop).each { |i| indices_list << i.to_i }
else
if not i.match(/^\w+$/)
# Only positive numbers allowed ...
if not i.match(/^\d+$/)
raise(Puppet::ParseError, 'Unknown format of given index')
end
# In Puppet numbers are often string-encoded ...
indices_list << i.to_i
i = i.to_i
if i > array_size - 1 # Same story. First element is at index 0 ...
raise(Puppet::ParseError, 'Given index exceeds array size')
end
indices_list << i
end
end