opuppet/puppetlabs-stdlib
4
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #412 from seanmil/MODULES-1771

Browse source 
(MODULES-1771) Don't modify input to is_domain_name()
This commit is contained in:
Morgan Haskel 2015-02-19 11:33:34 -08:00
commit fcd2f53908
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/puppet/parser/functions/is_domain_name.rb
View file

@ -13,7 +13,7 @@ Returns true if the string passed to this function is a syntactically correct do
"given #{arguments.size} for 1") "given #{arguments.size} for 1")
end end
domain = arguments[0] domain = arguments[0].dup
# Limits (rfc1035, 3.1) # Limits (rfc1035, 3.1)
domain_max_length=255 domain_max_length=255

7
spec/functions/is_domain_name_spec.rb
View file

@ -61,4 +61,11 @@ describe "the is_domain_name function" do
result = scope.function_is_domain_name(["not valid"]) result = scope.function_is_domain_name(["not valid"])
expect(result).to(be_falsey) expect(result).to(be_falsey)
end end
# Values obtained from Facter values will be frozen strings
# in newer versions of Facter:
it "should not throw an exception if passed a frozen string" do
result = scope.function_is_domain_name(["my.domain.name".freeze])
expect(result).to(be_truthy)
end
end end