David Schmitt
f49eb6b8e2
range(): fix TypeError(can't convert nil into Integer) when using range syntax
2015-05-06 10:13:27 +01:00
David Schmitt
6a0a6153d5
spec_helper: Remove unneccesary stubbing
...
This only roots all Facter instances into memory, while something already
creates a new Facter instance each run.
2015-05-05 13:30:57 +01:00
David Schmitt
24680aceec
spec_helper: use proper mocha import to avoid warning
2015-05-05 13:30:54 +01:00
David Schmitt
29f09e2181
spec_helper: set parser config if requested
2015-05-05 13:27:46 +01:00
David Schmitt
c0cf14e774
spec_helper_acceptance: fix FUTURE_PARSER usage
...
Use the more common "yes", instead of "true" to detect FUTURE_PARSER.
2015-05-05 13:27:46 +01:00
David Schmitt
a3016c45c5
specs: move function specs to where rspec-puppet expects them
2015-05-05 13:27:46 +01:00
David Schmitt
b664fec30f
specs: loosen certain error expectations to make tests pass on future parser
2015-04-23 16:40:53 -07:00
Morgan Haskel
8a1d1e2f34
Merge pull request #314 from amateo/feature/loadyaml_check_file
...
Check if file exists before loading with loadyaml. If not, return nil
2015-04-16 10:48:10 -07:00
Angel L. Mateo
ac24e7acc7
test case for when the file does not exist
2015-04-13 09:27:03 +02:00
Bryan Jen
601e2e2574
Modules-2474: Only runs enhanced salts functional test on systems that support it.
2015-04-10 11:38:15 -07:00
Bryan Jen
cf7dbef1e8
Merge pull request #433 from cmurphy/fix_acceptance
...
Fix acceptance tests for #405
2015-04-10 10:05:02 -07:00
Colleen Murphy
65116dafd5
Fix acceptance tests for #405
...
This fixes the acceptance tests by:
- Ensuring the fqdn_rand_string spec is passed undef as the second
parameter so that the seed is not used as the charset
- Ensuring the pw_hash spec is passed the key specifying the type of
hash, rather than the value that will be used to generate the
password
- Expecting puppet to report nil instead of empty string for undef
passwords
- Removing the fqdn_rand_base64 test because there is no such function
2015-04-10 09:15:15 -07:00
David Schmitt
afec0ab981
Merge pull request #425 from jeffcoat/validate_augeas_spec
...
Fix off-by-one error in validate_augeas_spec.rb that was causing rspec failure
Even without the gem installed always, this is helpful to avoid errors should augeas be enabled/installed due to something else.
2015-04-10 13:28:48 +01:00
Morgan Haskel
5ee6e960f6
Merge pull request #431 from bmjen/file-line-refactor
...
File_line checks provided after param if no match is found
2015-04-09 16:47:34 -07:00
Colleen Murphy
e43f058296
Fix unsupported platforms variable name in tests
...
unsupported_platforms is not a valid identifier, and trying to use it
causes acceptance tests to error out before running any tests. The
correct identifier for the unsupported platforms constants is
UNSUPPORTED_PLATFORMS.
2015-04-09 15:53:16 -07:00
Travis Fields
0af0d7e539
Add spec tests and pulled in PR #427
...
Changed append line to open in 'w' mode and have to rewrite lines in order to append new line
2015-04-09 15:24:39 -07:00
Hunter Haugen
8fba5c058b
Merge pull request #405 from elyscape/feature/fqdn_rand_strings
...
(MODULES-1715) Add FQDN-based random string generator
2015-04-09 10:45:38 -07:00
Eli Young
23be4020dd
(MODULES-1737) Add pw_hash() function
2015-04-05 17:21:17 -07:00
Eli Young
a82266c256
(MODULES-1715) Add fqdn_rand string generators
2015-03-31 17:33:04 -07:00
Mark Jeffcoat
3fec51ac65
Fix off-by-one error in validate_augeas_spec.rb that was causing rspec failure.
2015-03-10 17:43:51 -05:00
Rod Montgomery
ee13438d2a
If present, top-level domain must be alphabetic
...
See RFC 1123, Section 2.1
http://tools.ietf.org/html/rfc1123#section-2
2015-03-05 21:51:12 -06:00
TP Honey
bf8e5b0573
Merge pull request #422 from cyberious/assert_private
...
Assert private
2015-03-05 19:15:41 +00:00
Travis Fields
4a68b224c4
Add private function back and forward to assert_private with deprecation warning
2015-03-05 11:12:51 -08:00
Hunter Haugen
668b3c31b5
Merge pull request #369 from rfugina/dirname_typecheck
...
Dirname typecheck
2015-03-05 11:00:36 -08:00
Franz Pletz
56d815bcfc
Rename private() to assert_private()
...
As mentioned in #270 , private is a reserved keyword in the future parser
which is to be released with Puppet 4. As it stands, this function is
not useable with the future parser so it needs to renamed.
This is a breaking change.
2015-03-05 10:59:31 -08:00
Hunter Haugen
41965fd2c9
Merge pull request #375 from poikilotherm/feature/master/validate_integer_and_numeric
...
(MODULES-560) Add new functions validate_numeric() and validate_integer().
2015-03-05 10:57:43 -08:00
Stefan Goethals
0236cd51bc
Add support for hashes in the prefix function
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2015-03-03 16:20:55 -08:00
Bryon Roché
41baef8502
URI.escape for the array case was incorrect.
...
The previous commit to uriescape() changed the implementation to use the ruby default escape list for URI.escape(), but did not change the call triggered when uriescape() was called on an array, triggering ruby errors.
2015-03-03 16:05:47 -08:00
Morgan Haskel
055083c117
Merge pull request #407 from adamcrews/ceiling_function
...
Add a ceiling function to complement the floor function.
2015-03-03 15:59:06 -08:00
Travis Fields
85e81f9bdf
Loosen the restrictions of upcase and allow for recursion of the objects and only worry if the object responds to upcase
2015-03-02 10:45:43 -08:00
Travis Fields
7021b1f55c
Add Hash to upcase
2015-02-25 11:39:27 -08:00
Sean Millichamp
1321d586a8
(MODULES-1771) Don't modify input to is_domain_name()
...
Fix is_domain_name() so it dup's its incoming argument
to avoid changing the original with a later chomp!
2015-02-14 10:49:26 -05:00
Eli Young
84f866ffaf
(MODULES-1738) Don't modify global seed in fqdn_rotate()
...
As per puppetlabs/puppet@292233c , this leaves the global seed in a
deterministic state, which is bad. Puppet::Util.deterministic_rand()
exists to avoid running into this issue, but is only present starting in
Puppet 3.2.0.
2015-02-12 14:04:47 -08:00
Adam Crews
53b1802a92
Add a ceiling function to complement the floor function.
2015-02-01 22:46:16 -08:00
Hunter Haugen
bfb526899f
Change all to each
...
The existence of this directory is behavior for each test, but will also
stop rspec 3 from complaining.
2015-01-13 17:21:28 -08:00
Hunter Haugen
7c8ae311ca
(MODULES-1473) Deprecate type() function for new parser
...
The `type()` function will cease to work on the new parser because 'type'
is a reserved keyword. The `type3x()` function may be used to continue
similar functionality, but will be deprecated in favor of the built-in
typing system.
The `type_of()` function has been included to introspect types in the
new parser.
2015-01-07 16:40:06 -08:00
Travis Fields
8ec6f8dbfd
MODULES-1606 add ability to pass array to delete for items to delete
2014-12-19 10:26:01 -08:00
Morgan Haskel
31a6d89410
Fix bad check in test
2014-12-18 16:20:02 -08:00
Hunter Haugen
1ae0a10707
Merge pull request #388 from mhaskel/merge_4.5.x_into_master
...
Merge 4.5.x into master
2014-12-18 15:55:33 -08:00
Peter Souter
cc8b147b5d
(MODULES-1582) Specs for the new % placeholder
...
These specs are pretty much the same as the originals, but now check that the output has the correct replacement for file location
2014-12-18 23:08:33 +00:00
Morgan Haskel
696c89de99
Merge pull request #372 from poikilotherm/feature/master/validate_absolute_path_allow_arrays
...
Allow array of pathes in validate_absolute_path
2014-12-17 14:19:30 -08:00
Morgan Haskel
841b0df210
Merge pull request #368 from rfugina/basename
...
Basename implementation
2014-12-17 11:00:23 -08:00
Rob Fugina
2a3babc348
Added type checks for dirname(), and additional tests
2014-12-17 12:55:48 -06:00
Rob Fugina
ef3d42f7bb
Added basename() based on Ruby's File.basename
...
Based on dirname code. Includes RSpec tests and docs.
2014-12-17 12:39:40 -06:00
Hunter Haugen
c6c203fca8
Remove line match validation
...
The `match` attribute was validated to match `line`, except that in many
cases (even the example given in the docs) a user would want to match a
line entirely different from the new line.
See comments on the original commit
a06c0d8115
and ask
https://ask.puppetlabs.com/question/14366/file_line-resource-match-problems/
for further examples of confusion.
2014-12-16 15:05:31 -08:00
Oliver Bertuch
260c1f4b92
Add new functions validate_numeric() and validate_integer().
2014-12-04 22:33:15 +01:00
Peter Souter
368c97f080
(MODULES-444) - Check for accepting > 2 args
2014-12-04 14:27:55 +00:00
Peter Souter
7a1c4a6d9e
(MODULES-444) Change test to > 2 arguments
...
Also add extra test for just 1 argument
2014-12-04 14:27:38 +00:00
Peter Souter
5e49c50458
(MODULES-444) Acceptance for multiple arrays
...
Acceptance test to take multiple arrays for concatenation
2014-12-04 14:15:33 +00:00
Peter Souter
7c570f75a5
(MODULES-444) Acceptance test for primitives
...
`concat` should be able to concat arrays and primitives
2014-12-04 14:15:03 +00:00