Commit graph

1299 commits

Author SHA1 Message Date
Hunter Haugen
b4090184c7 Add ability to unittest puppet 4 2015-05-27 08:14:19 -07:00
TP Honey
3fafad88b3 Merge pull request #460 from DavidS/fix-fqdn_rotate-seed
fqdn_rotate: reset srand seed correctly on old ruby versions
2015-05-26 15:48:22 +01:00
David Schmitt
0dc0e0dbcf fqdn_rotate: reset srand seed correctly on old ruby versions
Without this, the global seed is reseeded on every use
of fqdn_rotate, which is a waste. Older rubies might even use a
time-base seed which adversly impacts the quality of the RNG.
2015-05-26 14:25:43 +01:00
Bryan Jen
6cf64f1028 Merge pull request #454 from elyscape/document_facts.d_cache
(FM-2130) Document new location of facts.d cache
2015-05-21 10:42:32 -07:00
Morgan Haskel
06ebdf3ef7 Merge pull request #455 from hunner/change_type_of_test
Remove all the pops stuff
2015-05-21 10:41:41 -07:00
Morgan Haskel
1401e267b3 Merge pull request #458 from ghoneycutt/patch-1
Update CHANGELOG.md
2015-05-21 10:20:40 -07:00
Garrett Honeycutt
48e516be6b Update CHANGELOG.md 2015-05-20 15:16:45 -04:00
Bryan Jen
97ee232ed0 Merge pull request #456 from jtappa/readme-edits
DOC-1504: Readme edits
2015-05-14 15:08:52 -07:00
Jorie Tappa
593f74ced7 DOC-1504: README edits 2015-05-14 15:03:23 -07:00
Hunter Haugen
732f7e8b35 Remove all the pops stuff
The rspec-puppet matchers don't allow to check the return types, but
this is a pretty rare thing to need to do anyway, so probably not worth
patching rspec-puppet
2015-05-12 15:03:27 -07:00
Eli Young
3b8ded184d (FM-2130) Document new location of facts.d cache 2015-05-11 11:12:15 -07:00
David Schmitt
35c77c7a7a Merge pull request #449 from puppetlabs/modulesync_updates
sync via modulesync
2015-05-07 11:03:39 +01:00
Morgan Haskel
ecd4f3e4dc sync via modulesync 2015-05-06 14:10:40 -07:00
TP Honey
4f6c6fa3e5 Merge pull request #448 from DavidS/fix_range
range(): fix TypeError(can't convert nil into Integer) when using range ...
2015-05-06 13:55:22 +01:00
David Schmitt
f49eb6b8e2 range(): fix TypeError(can't convert nil into Integer) when using range syntax 2015-05-06 10:13:27 +01:00
David Schmitt
cf251303be Merge pull request #447 from elyscape/fix_range
Restore removed functionality to range()
2015-05-06 09:48:31 +01:00
David Schmitt
20669e39b1 Merge pull request #446 from elyscape/fix_pw_hash
Fix pw_hash() on JRuby < 1.7.17
2015-05-06 09:11:37 +01:00
Eli Young
25ed4b43c4 range: Clean up and clarify function contents 2015-05-05 16:06:35 -07:00
Eli Young
8cf011d7a2 Revert "range: remove dead code"
This reverts commit 063c58a992, which
actually removed non-dead code. Specifically, it removed the ability to
make calls such as `range('2..3')`, `range('2...3')`, and
`range('2-3')`.

cf. https://github.com/puppetlabs/puppetlabs-stdlib/pull/443#commitcomment-11055565
2015-05-05 16:06:08 -07:00
Eli Young
7d7e905b54 pw_hash: Fix functionality on JRuby < 1.7.17
The previous change to this function broke it on JRuby before 1.7.17 by
attempting to use a variable that wasn't defined (`salt`). To fix this,
define `salt` ahead of time and use that instead of building the salt
later.

cf. https://github.com/puppetlabs/puppetlabs-stdlib/pull/443#discussion_r29718588
2015-05-05 15:53:34 -07:00
TP Honey
7181e4ebca Merge pull request #443 from DavidS/prep-work-for-new-specs
Prep work for new specs
2015-05-05 14:35:48 +01:00
David Schmitt
d4f3d57f16 validate_augeas: fix URL to docs 2015-05-05 13:55:18 +01:00
David Schmitt
063c58a992 range: remove dead code
Since a ParseError is always thrown for zero arguments, the if and all
dependent code can be removed.
2015-05-05 13:30:57 +01:00
David Schmitt
9bae8356fd pw_hash: avoid ruby magic when running on java 2015-05-05 13:30:57 +01:00
David Schmitt
6a0a6153d5 spec_helper: Remove unneccesary stubbing
This only roots all Facter instances into memory, while something already
creates a new Facter instance each run.
2015-05-05 13:30:57 +01:00
David Schmitt
24680aceec spec_helper: use proper mocha import to avoid warning 2015-05-05 13:30:54 +01:00
David Schmitt
29f09e2181 spec_helper: set parser config if requested 2015-05-05 13:27:46 +01:00
David Schmitt
c0cf14e774 spec_helper_acceptance: fix FUTURE_PARSER usage
Use the more common "yes", instead of "true" to detect FUTURE_PARSER.
2015-05-05 13:27:46 +01:00
David Schmitt
a3016c45c5 specs: move function specs to where rspec-puppet expects them 2015-05-05 13:27:46 +01:00
David Schmitt
b664fec30f specs: loosen certain error expectations to make tests pass on future parser 2015-04-23 16:40:53 -07:00
Hunter Haugen
c7a23b226d Merge pull request #441 from mrzarquon/change_stdlib_to_include
uses include type class declaration
2015-04-20 10:21:40 -07:00
Chris Barker
cf499315c1 uses include type class declaration
previous behavior used class { 'stdlib::stages':} which isn't singleton and could cause duplication resource declaration on the stages class.

Since many community modules work by calling 'include stdlib' we should make stdlib's include of stages singleton as well.
2015-04-20 10:06:00 -07:00
TP Honey
2a8d7acd7e Merge pull request #440 from DavidS/fix-error-message
fqdn_rand_string: fix argument error message
2015-04-18 20:51:17 +01:00
David Schmitt
c27513463d fqdn_rand_string: fix argument error message 2015-04-17 14:24:40 -07:00
Morgan Haskel
2c6cff6f72 Merge pull request #439 from puppetlabs/4.6.x
4.6.x
2015-04-16 11:55:42 -07:00
Morgan Haskel
8a1d1e2f34 Merge pull request #314 from amateo/feature/loadyaml_check_file
Check if file exists before loading with loadyaml. If not, return nil
2015-04-16 10:48:10 -07:00
Bryan Jen
73474b00b5 Merge pull request #438 from hunner/fix_date
Fix the 4.6.0 release date
2015-04-14 15:26:49 -07:00
Hunter Haugen
ba4033ed25 Fix the 4.6.0 release date 2015-04-14 15:24:50 -07:00
Morgan Haskel
4c90e4df52 Merge pull request #437 from hunner/release_4.6.0
Prep for 4.6.0
2015-04-14 11:41:51 -07:00
Hunter Haugen
5382ca0176 Prep for 4.6.0 2015-04-14 11:39:22 -07:00
Angel L. Mateo
ac24e7acc7 test case for when the file does not exist 2015-04-13 09:27:03 +02:00
Hunter Haugen
59b3fb4472 Merge pull request #434 from bmjen/modules-2474
Modules-2474: Only runs enhanced salts functions test on systems that ...
2015-04-10 11:58:09 -07:00
Bryan Jen
601e2e2574 Modules-2474: Only runs enhanced salts functional test on systems that support it. 2015-04-10 11:38:15 -07:00
Bryan Jen
cf7dbef1e8 Merge pull request #433 from cmurphy/fix_acceptance
Fix acceptance tests for #405
2015-04-10 10:05:02 -07:00
Colleen Murphy
65116dafd5 Fix acceptance tests for #405
This fixes the acceptance tests by:
 - Ensuring the fqdn_rand_string spec is passed undef as the second
   parameter so that the seed is not used as the charset
 - Ensuring the pw_hash spec is passed the key specifying the type of
   hash, rather than the value that will be used to generate the
   password
 - Expecting puppet to report nil instead of empty string for undef
   passwords
 - Removing the fqdn_rand_base64 test because there is no such function
2015-04-10 09:15:15 -07:00
David Schmitt
afec0ab981 Merge pull request #425 from jeffcoat/validate_augeas_spec
Fix off-by-one error in validate_augeas_spec.rb that was causing rspec failure

Even without the gem installed always, this is helpful to avoid errors should augeas be enabled/installed due to something else.
2015-04-10 13:28:48 +01:00
Morgan Haskel
5ee6e960f6 Merge pull request #431 from bmjen/file-line-refactor
File_line checks provided after param if no match is found
2015-04-09 16:47:34 -07:00
Morgan Haskel
acf57bbe31 Merge pull request #432 from cmurphy/fix_acceptance_undefined_var
Fix unsupported platforms variable name in tests
2015-04-09 15:53:41 -07:00
Colleen Murphy
e43f058296 Fix unsupported platforms variable name in tests
unsupported_platforms is not a valid identifier, and trying to use it
causes acceptance tests to error out before running any tests. The
correct identifier for the unsupported platforms constants is
UNSUPPORTED_PLATFORMS.
2015-04-09 15:53:16 -07:00
Travis Fields
0af0d7e539 Add spec tests and pulled in PR #427
Changed append line to open in 'w' mode and have to rewrite lines in order to append new line
2015-04-09 15:24:39 -07:00