Commit graph

5 commits

Author SHA1 Message Date
Dan Bode
b42c82af19 Revert "Revert "Merge pull request #86 from bodepd/ensure_resource""
This reverts commit 1e09833624.
2012-08-15 15:56:57 -07:00
Jeff McCune
1e09833624 Revert "Merge pull request #86 from bodepd/ensure_resource"
This reverts commit 42ddd7fe54, reversing
changes made to 53243605b2.
2012-08-14 18:26:17 -07:00
Dan Bode
5ffd33e8f1 re-formatting
This commit refactors to ensure 80 character lines.
2012-08-13 18:53:47 -07:00
Dan Bode
fe85f467c8 Handle undef for parameter argument
This commit adds better handling of the case where
undef is passed as the parameter value.

This works by converting '' into []
2012-08-13 18:52:00 -07:00
Dan Bode
ba789deac5 Add function ensure_resource and defined_with_params
This commit adds 2 new functions with unit tests.

defined_with_params works similarily to puppet's defined
function, except it allows you to also specify a hash of
params. defined_with_params will return true if a resource
also exists that matches the specified type/title (just like
with defined) as well as all of the specified params.

ensure_resource is a function that basically combines defined_with_params
with create_resources to conditionally create resources only if the
specified resource (title, type, params) does not already exist.

These functions are created to serve as an alternative to using
defined as follows:

    if ! defined(Package['some_package']) {
      package { 'some_package': ensure => present,
    }

The issue with this usage is that there is no guarentee about
what parameters were set in the previous definition of the package
that made its way into the catalog.

ensure_resource could be used instead, as:

    ensure_resource('package', 'some_package', { 'ensure' => 'present' })

This will creat the package resources only if another resource does
not exist with the specified parameters.
2012-08-13 17:09:10 -07:00