Commit graph

11 commits

Author SHA1 Message Date
Mathias Klette
0d11bde507 ensure_resource: be more verbose in debug mode
helps discovering duplication issues, especially when figthing boolean vs. string arguments
2014-10-10 22:57:26 +02:00
Chris Boot
7f98203f18 ensure_resource: fix documentation typo 2013-06-27 17:51:36 +01:00
Alex Cline
d38bce0488 Terser method of string to array conversion courtesy of ethooz. 2013-05-06 16:16:38 -04:00
Alex Cline
de253db564 Changed str-to-array conversion and removed abbreviation. 2013-05-06 13:52:57 -04:00
Alex Cline
e08734af5a (#20548) Allow an array of resource titles to be passed into the ensure_resource function
This patch allows an array of resource titles to be passed into
the ensure_resource function.  Each item in the array will be
checked for existence and will be created if it doesn't already
exist.
2013-05-03 15:47:27 -04:00
Dan Bode
5d99cdf09c Explicitly load functions used by ensure_resource
The ensure_resource function actually calls two
other functions, create_resources and defined_with_param.

When calling Puppet functions from Ruby, you sometimes have
to load the functions manually if they have not been called
before.

This commit explicitly loads the functions that ensure_resource
depends on from within the function.
2012-08-15 15:57:45 -07:00
Dan Bode
b42c82af19 Revert "Revert "Merge pull request #86 from bodepd/ensure_resource""
This reverts commit 1e09833624.
2012-08-15 15:56:57 -07:00
Jeff McCune
1e09833624 Revert "Merge pull request #86 from bodepd/ensure_resource"
This reverts commit 42ddd7fe54, reversing
changes made to 53243605b2.
2012-08-14 18:26:17 -07:00
Dan Bode
5ffd33e8f1 re-formatting
This commit refactors to ensure 80 character lines.
2012-08-13 18:53:47 -07:00
Dan Bode
222a65dfe2 Add better docs about duplicate resource failures
This commit adds better inline documentation
explaining how replicate resource definitions can
occur if the resource exists and does not have
matching parameters.
2012-08-13 18:52:56 -07:00
Dan Bode
ba789deac5 Add function ensure_resource and defined_with_params
This commit adds 2 new functions with unit tests.

defined_with_params works similarily to puppet's defined
function, except it allows you to also specify a hash of
params. defined_with_params will return true if a resource
also exists that matches the specified type/title (just like
with defined) as well as all of the specified params.

ensure_resource is a function that basically combines defined_with_params
with create_resources to conditionally create resources only if the
specified resource (title, type, params) does not already exist.

These functions are created to serve as an alternative to using
defined as follows:

    if ! defined(Package['some_package']) {
      package { 'some_package': ensure => present,
    }

The issue with this usage is that there is no guarentee about
what parameters were set in the previous definition of the package
that made its way into the catalog.

ensure_resource could be used instead, as:

    ensure_resource('package', 'some_package', { 'ensure' => 'present' })

This will creat the package resources only if another resource does
not exist with the specified parameters.
2012-08-13 17:09:10 -07:00