30e994fb6e
When pick function fail return a better error message like
the other stdlib functions, indicating that the error
is on function pick.
This would help people that see the error to identity it is
related to a incorrect use of stdlib function pick, instead of having
to grep all puppet libraries and manifests source for the old message.
I had also changed the spec test.
pick function change spec as suggested GH-179
Fix the spec test to use expect {}.to instead of lambda {}.should
as explained by Adrienthebo.
"Using expect { }.to is preferred over lambda { }.should.
In addition it's best practice to do a string match against the
error message to ensure that we're catching the right error,
instead of any error of the right type."
Also fixed a typo on the error message, it was missing one space.
pick function stylish fix as suggested on GH179
29 lines
1 KiB
Ruby
29 lines
1 KiB
Ruby
module Puppet::Parser::Functions
|
|
newfunction(:pick, :type => :rvalue, :doc => <<-EOS
|
|
|
|
This function is similar to a coalesce function in SQL in that it will return
|
|
the first value in a list of values that is not undefined or an empty string
|
|
(two things in Puppet that will return a boolean false value). Typically,
|
|
this function is used to check for a value in the Puppet Dashboard/Enterprise
|
|
Console, and failover to a default value like the following:
|
|
|
|
$real_jenkins_version = pick($::jenkins_version, '1.449')
|
|
|
|
The value of $real_jenkins_version will first look for a top-scope variable
|
|
called 'jenkins_version' (note that parameters set in the Puppet Dashboard/
|
|
Enterprise Console are brought into Puppet as top-scope variables), and,
|
|
failing that, will use a default value of 1.449.
|
|
|
|
EOS
|
|
) do |args|
|
|
args = args.compact
|
|
args.delete(:undef)
|
|
args.delete(:undefined)
|
|
args.delete("")
|
|
if args[0].to_s.empty? then
|
|
fail Puppet::ParseError, "pick(): must receive at last one non empty value"
|
|
else
|
|
return args[0]
|
|
end
|
|
end
|
|
end
|