199ca9c78b
Issue #20200 notes that the merge function does not support nested hashes. To prevent unintended side effects with changing merge, add a deep_merge function instead.
77 lines
3 KiB
Ruby
77 lines
3 KiB
Ruby
#! /usr/bin/env ruby -S rspec
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Puppet::Parser::Functions.function(:deep_merge) do
|
|
let(:scope) { PuppetlabsSpec::PuppetInternals.scope }
|
|
|
|
describe 'when calling deep_merge from puppet' do
|
|
it "should not compile when no arguments are passed" do
|
|
pending("Fails on 2.6.x, see bug #15912") if Puppet.version =~ /^2\.6\./
|
|
Puppet[:code] = '$x = deep_merge()'
|
|
expect {
|
|
scope.compiler.compile
|
|
}.to raise_error(Puppet::ParseError, /wrong number of arguments/)
|
|
end
|
|
|
|
it "should not compile when 1 argument is passed" do
|
|
pending("Fails on 2.6.x, see bug #15912") if Puppet.version =~ /^2\.6\./
|
|
Puppet[:code] = "$my_hash={'one' => 1}\n$x = deep_merge($my_hash)"
|
|
expect {
|
|
scope.compiler.compile
|
|
}.to raise_error(Puppet::ParseError, /wrong number of arguments/)
|
|
end
|
|
end
|
|
|
|
describe 'when calling deep_merge on the scope instance' do
|
|
it 'should require all parameters are hashes' do
|
|
expect { new_hash = scope.function_deep_merge([{}, '2'])}.to raise_error(Puppet::ParseError, /unexpected argument type String/)
|
|
expect { new_hash = scope.function_deep_merge([{}, 2])}.to raise_error(Puppet::ParseError, /unexpected argument type Fixnum/)
|
|
end
|
|
|
|
it 'should accept empty strings as puppet undef' do
|
|
expect { new_hash = scope.function_deep_merge([{}, ''])}.not_to raise_error(Puppet::ParseError, /unexpected argument type String/)
|
|
end
|
|
|
|
it 'should be able to deep_merge two hashes' do
|
|
new_hash = scope.function_deep_merge([{'one' => '1', 'two' => '1'}, {'two' => '2', 'three' => '2'}])
|
|
new_hash['one'].should == '1'
|
|
new_hash['two'].should == '2'
|
|
new_hash['three'].should == '2'
|
|
end
|
|
|
|
it 'should deep_merge multiple hashes' do
|
|
hash = scope.function_deep_merge([{'one' => 1}, {'one' => '2'}, {'one' => '3'}])
|
|
hash['one'].should == '3'
|
|
end
|
|
|
|
it 'should accept empty hashes' do
|
|
scope.function_deep_merge([{},{},{}]).should == {}
|
|
end
|
|
|
|
it 'should deep_merge subhashes' do
|
|
hash = scope.function_deep_merge([{'one' => 1}, {'two' => 2, 'three' => { 'four' => 4 } }])
|
|
hash['one'].should == 1
|
|
hash['two'].should == 2
|
|
hash['three'].should == { 'four' => 4 }
|
|
end
|
|
|
|
it 'should append to subhashes' do
|
|
hash = scope.function_deep_merge([{'one' => { 'two' => 2 } }, { 'one' => { 'three' => 3 } }])
|
|
hash['one'].should == { 'two' => 2, 'three' => 3 }
|
|
end
|
|
|
|
it 'should append to subhashes 2' do
|
|
hash = scope.function_deep_merge([{'one' => 1, 'two' => 2, 'three' => { 'four' => 4 } }, {'two' => 'dos', 'three' => { 'five' => 5 } }])
|
|
hash['one'].should == 1
|
|
hash['two'].should == 'dos'
|
|
hash['three'].should == { 'four' => 4, 'five' => 5 }
|
|
end
|
|
|
|
it 'should append to subhashes 3' do
|
|
hash = scope.function_deep_merge([{ 'key1' => { 'a' => 1, 'b' => 2 }, 'key2' => { 'c' => 3 } }, { 'key1' => { 'b' => 99 } }])
|
|
hash['key1'].should == { 'a' => 1, 'b' => 99 }
|
|
hash['key2'].should == { 'c' => 3 }
|
|
end
|
|
end
|
|
end
|